]> err.no Git - linux-2.6/commit
[TCP]: Fix two off-by-one errors in fackets_out adjusting logic
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Mon, 8 Oct 2007 06:36:41 +0000 (23:36 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:54:47 +0000 (16:54 -0700)
commit29d0a309d11bac9e57af914d0d6a35cde0080861
treea0625867361e0932e89f4bc35f2607aa732f96fa
parent182f6ed5188ccb46d1c54c3334943a54110d0118
[TCP]: Fix two off-by-one errors in fackets_out adjusting logic

1) Passing wrong skb to tcp_adjust_fackets_out could corrupt
fastpath_cnt_hint as tcp_skb_pcount(next_skb) is not included
to it if hint points exactly to the next_skb (it's lagging
behind, see sacktag).

2) When fastpath_skb_hint is put backwards to avoid dangling
skb reference, the skb's pcount must also be removed from count
(not included like above).

Reported by Cedric Le Goater <legoater@free.fr>

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_output.c