]> err.no Git - linux-2.6/commit
fs/ext3: use BUG_ON
authorJulia Lawall <julia@diku.dk>
Mon, 28 Apr 2008 09:16:09 +0000 (02:16 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 28 Apr 2008 15:58:44 +0000 (08:58 -0700)
commit269b26191650be46ce6c91dec24cf20f59650529
tree9ff8863d02d709dcb75deef345b3a6eb8c0d30c0
parent33575f8ffe99bf9e381161ccd76b39079c0aa92f
fs/ext3: use BUG_ON

if (...) BUG(); should be replaced with BUG_ON(...) when the test has no
side-effects to allow a definition of BUG_ON that drops the code completely.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@ disable unlikely @ expression E,f; @@

(
  if (<... f(...) ...>) { BUG(); }
|
- if (unlikely(E)) { BUG(); }
+ BUG_ON(E);
)

@@ expression E,f; @@

(
  if (<... f(...) ...>) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ext3/balloc.c