]> err.no Git - linux-2.6/commit
[PATCH] USB Storage: close a race condition in disconnect near queuecommand
authorMatthew Dharm <mdharm-usb@one-eyed-alien.net>
Thu, 28 Jul 2005 21:45:50 +0000 (14:45 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 8 Sep 2005 23:22:55 +0000 (16:22 -0700)
commit26186ba77b493204ae0fadc3c88a67b14f22168f
tree6fc0d50a4d286df33b18f21e0994b09637d0c6c8
parent77f46328fb83b64befd889ebce6d7fb959932509
[PATCH] USB Storage: close a race condition in disconnect near queuecommand

This patch started life as as534, and has been re-diffed against the latest
tree.

usb-storage has a small loophole, a window between the time queuecommand
accepts a new command and the time the control thread starts to execute
it.  If disconnect is called during that window, the driver won't cancel
the pending command -- we've been relying on the SCSI core to cancel it
for us during host removal.  But it's better for usb-storage to cancel
it;  this avoids races and reduces reliance on the SCSI core.
Fortunately cancelling these commands is easy to do; the key is to do it
_before_ calling scsi_remove_host.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/storage/usb.c