]> err.no Git - linux-2.6/commit
[PATCH] knfsd: nfsd4: Wrong error handling in nfs4acl
authorNeilBrown <neilb@suse.de>
Tue, 11 Apr 2006 05:55:24 +0000 (22:55 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Tue, 11 Apr 2006 13:18:51 +0000 (06:18 -0700)
commit249920527f9e6e5c305538bbf1ea882ee7dc1c06
tree39c2a10a05f75a23cca797727649f4e231385610
parente465a77f943f51df1a169426df879340bd0db3f3
[PATCH] knfsd: nfsd4: Wrong error handling in nfs4acl

this fixes coverity id #3.  Coverity detected dead code, since the == -1
comparison only returns 0 or 1 to error.  Therefore the if ( error < 0 )
statement was always false.  Seems that this was an if( error = nfs4...  )
statement some time ago, which got broken during cleanup.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/nfsd/nfs4acl.c