]> err.no Git - linux-2.6/commit
[TCP] cubic: scaling error
authorStephen Hemminger <shemminger@osdl.org>
Thu, 26 Oct 2006 06:04:12 +0000 (23:04 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 26 Oct 2006 06:04:12 +0000 (23:04 -0700)
commit22119240b1c8f64eebb6ffb368c927b2f8be4136
tree0cdd861c612941b11ff24d4726cda11fb3e785b1
parent291b58d663862c3d42d2e8092f8b0dd3f15a94f8
[TCP] cubic: scaling error

Doug Leith observed a discrepancy between the version of CUBIC described
in the papers and the version in 2.6.18. A math error related to scaling
causes Cubic to grow too slowly.

Patch is from "Sangtae Ha" <sha2@ncsu.edu>. I validated that
it does fix the problems.

See the following to show behavior over 500ms 100 Mbit link.

Sender (2.6.19-rc3) ---  Bridge (2.6.18-rt7) ------- Receiver (2.6.19-rc3)
                    1G      [netem]           100M

http://developer.osdl.org/shemminger/tcp/2.6.19-rc3/cubic-orig.png
http://developer.osdl.org/shemminger/tcp/2.6.19-rc3/cubic-fix.png

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_cubic.c