]> err.no Git - linux-2.6/commit
[NET]: Undo code bloat in hot paths due to print_mac().
authorDavid S. Miller <davem@davemloft.net>
Tue, 8 Apr 2008 23:50:44 +0000 (16:50 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Apr 2008 23:50:44 +0000 (16:50 -0700)
commit21f644f3eabde637f255f75ad05d0821a7a36b7f
tree2dc70aade59bf77c2d156b8e2544906128368f87
parent6adb4f733e9996b4fd68a6db50dd51bd2463ccac
[NET]: Undo code bloat in hot paths due to print_mac().

If print_mac() is used inside of a pr_debug() the compiler
can't see that the call is redundant so still performs it
even of pr_debug() ends up being a nop.

So don't use print_mac() in such cases in hot code paths,
use MAC_FMT et al. instead.

As noted by Joe Perches, pr_debug() could be modified to
handle this better, but that is a change to an interface
used by the entire kernel and thus needs to be validated
carefully.  This here is thus the less risky fix for
2.6.25

Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/starfire.c
drivers/net/tokenring/olympic.c
drivers/net/virtio_net.c
drivers/net/wireless/hostap/hostap_80211_rx.c
drivers/net/wireless/hostap/hostap_80211_tx.c
drivers/net/wireless/hostap/hostap_ap.c
drivers/net/wireless/ipw2200.c
net/atm/lec.c
net/ieee80211/ieee80211_rx.c