]> err.no Git - linux-2.6/commit
sound: Use BUG_ON
authorJulia Lawall <julia@diku.dk>
Tue, 4 Mar 2008 23:07:24 +0000 (15:07 -0800)
committerTakashi Iwai <tiwai@suse.de>
Thu, 24 Apr 2008 10:00:22 +0000 (12:00 +0200)
commit21ac1f9934d33ea2ffa71d13fa2f6286127d3caf
tree931b6ad7de0da9e5b745f74c8431d5d2a11b30ae
parent0ccb541c96e6d40844d00ec88fae734568bdd0bd
sound: Use BUG_ON

if (...) BUG(); should be replaced with BUG_ON(...) when the test has no
side-effects to allow a definition of BUG_ON that drops the code completely.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@ disable unlikely @ expression E,f; @@

(
  if (<... f(...) ...>) { BUG(); }
|
- if (unlikely(E)) { BUG(); }
+ BUG_ON(E);
)

@@ expression E,f; @@

(
  if (<... f(...) ...>) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
sound/oss/trident.c