]> err.no Git - linux-2.6/commit
arch/x86/kernel/io_apic_{64,32}.c: use time_before
authorJulia Lawall <julia@diku.dk>
Wed, 30 Jan 2008 12:32:19 +0000 (13:32 +0100)
committerIngo Molnar <mingo@elte.hu>
Wed, 30 Jan 2008 12:32:19 +0000 (13:32 +0100)
commit1d16b53e387b255d8e30f00594220b23b1290e6b
tree602de196943f3d555d46fef7ef75e251652dc519
parent4f2479f03c06e29d7d9e1e02191f8b5ba8ad4eef
arch/x86/kernel/io_apic_{64,32}.c: use time_before

The functions time_before, time_before_eq, time_after, and time_after_eq
are more robust for comparing jiffies against other values.

A simplified version of the semantic patch making this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@ change_compare_np @
expression E;
@@

(
- jiffies <= E
+ time_before_eq(jiffies,E)
|
- jiffies >= E
+ time_after_eq(jiffies,E)
|
- jiffies < E
+ time_before(jiffies,E)
|
- jiffies > E
+ time_after(jiffies,E)
)

@ include depends on change_compare_np @
@@

#include <linux/jiffies.h>

@ no_include depends on !include && change_compare_np @
@@

  #include <linux/...>
+ #include <linux/jiffies.h>
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/kernel/io_apic_32.c
arch/x86/kernel/io_apic_64.c