]> err.no Git - linux-2.6/commit
A potential bug in inotify_user.c
authorYan Zheng <yanzheng@21cn.com>
Wed, 6 Feb 2008 09:36:09 +0000 (01:36 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 6 Feb 2008 18:41:00 +0000 (10:41 -0800)
commit1c17d18e3775485bf1e0ce79575eb637a94494a2
tree3a5d8e5d2731e7dda7ce0c43b0c00270bd01c8c4
parent19c561a60ffe52df88dd63de0bff480ca094efe4
A potential bug in inotify_user.c

Following comment is at fs/inotify_user.c:287
/* coalescing: drop this event if it is a dupe of the previous */

I think the previous event in the comment should be the last event in the
link list.  But inotify_dev_get_event return the first event in the list.
In addition, it doesn't check whether the list is empty

Signed-off-by: Yan Zheng<yanzheng@21cn.com>
Acked-by: Robert Love <rlove@rlove.org>
Cc: John McCutchan <ttb@tentacle.dhs.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/inotify_user.c