]> err.no Git - linux-2.6/commit
[patch 05/14] hpfs: dont call permission()
authorMiklos Szeredi <mszeredi@suse.cz>
Wed, 21 May 2008 17:15:03 +0000 (19:15 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 27 Jul 2008 00:53:13 +0000 (20:53 -0400)
commit1bd5191d9f5d1928c4efdf604c4164b04bb88dbe
treea0395f9e5a05c093ee3f5f1d816b2a053bad1f5c
parent9043476f726802f4b00c96d0c4f418dde48d1304
[patch 05/14] hpfs: dont call permission()

hpfs_unlink() calls permission() prior to truncating the file.  HPFS
doesn't define a .permission method, so replace with explicit call to
generic_permission().

This is equivalent, except that devcgroup_inode_permission() and
security_inode_permission() are not called.

The truncation is just an implementation detail of the unlink, so
these security checks are unnecessary.

I suspect that even calling generic_permission() is unnecessary, since
we shouldn't mind if the file isn't writable.  But I leave that to the
maintainer to decide.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
fs/hpfs/namei.c