]> err.no Git - linux-2.6/commit
[XFS] fix valid but harmless sparse warning
authorChristoph Hellwig <hch@infradead.org>
Wed, 19 Sep 2007 05:27:30 +0000 (15:27 +1000)
committerTim Shimmin <tes@chook.melbourne.sgi.com>
Thu, 20 Sep 2007 09:40:40 +0000 (19:40 +1000)
commit1bc5858d0d40e07697b5eda47ed8628b8a934235
treee393b4f69b21d1d074a5ba5142f06ffa727079eb
parentbcc7b445eff295664a3a3ab14e742b3c9d88e6e3
[XFS] fix valid but harmless sparse warning

The new xlog_recover_do_reg_buffer checks call be16_to_cpu on di_gen which
is a 32bit value so sparse rightly complains. Fortunately the warning is
harmless because we don't care for the value, but only whether it's
non-NULL. Due to that fact we can simply kill the endian swaps on this and
the previous di_mode check entirely.

SGI-PV: 969656
SGI-Modid: xfs-linux-melb:xfs-kern:29709a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Signed-off-by: Tim Shimmin <tes@sgi.com>
fs/xfs/xfs_log_recover.c