]> err.no Git - linux-2.6/commit
[PATCH] forcedeth: Initialize link settings in every nv_open()
authorManfred Spraul <manfred@colorfullife.com>
Sat, 6 Aug 2005 21:47:55 +0000 (23:47 +0200)
committerJeff Garzik <jgarzik@pobox.com>
Fri, 19 Aug 2005 06:12:16 +0000 (02:12 -0400)
commit1b1b3c9b6d346d441a99e2de0b34f3ba93963ad8
treee140e27b52b70ecad6c79c46ed7653b2c7002283
parenta3bc068022b968a3042b48eb9a8e8b0418fb9cdd
[PATCH] forcedeth: Initialize link settings in every nv_open()

RĂ¼diger found a bug in nv_open that explains some of the reports
with duplex mismatches:
nv_open calls nv_update_link_speed for initializing the hardware link speed
registers. If current link setting matches the values in np->linkspeed and
np->duplex, then the function does nothing.
Usually, doing nothing is the right thing, but not in nv_open: During
nv_open, the registers must be initialized because the nic was reset.

The attached patch fixes that by setting np->linkspeed to an invalid value
before calling nv_update_link_speed from nv_open.

Signed-Off-By: Manfred Spraul <manfred@colorfullife.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
drivers/net/forcedeth.c