]> err.no Git - linux-2.6/commit
fuse: fix permission checking
authorMiklos Szeredi <mszeredi@suse.cz>
Sat, 23 Feb 2008 23:23:27 +0000 (15:23 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Sun, 24 Feb 2008 01:12:13 +0000 (17:12 -0800)
commit1a823ac9ff09cbdf39201df37b7ede1f9395de83
tree8b61341ef969a3107cb5d3c8fb9317ec250507a6
parentfddd9cf82c9f9617d134ae878a8f6b116ebbd43d
fuse: fix permission checking

I added a nasty local variable shadowing bug to fuse in 2.6.24, with the
result, that the 'default_permissions' mount option is basically ignored.

How did this happen?

 - old err declaration in inner scope
 - new err getting declared in outer scope
 - 'return err' from inner scope getting removed
 - old declaration not being noticed

-Wshadow would have saved us, but it doesn't seem practical for
the kernel :(

More testing would have also saved us :((

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/fuse/dir.c