]> err.no Git - linux-2.6/commit
[SCSI] aacraid: probe related code cleanup
authorSalyzyn, Mark <mark_salyzyn@adaptec.com>
Mon, 11 Jun 2007 20:17:55 +0000 (16:17 -0400)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Sun, 17 Jun 2007 19:57:01 +0000 (14:57 -0500)
commit1a655040c24ebf3954ad5cf8848391cb420b1ffb
tree897ffe220b7b1e113c335283316f3b6d3c7efe2d
parentbeb87c33393142200df7bfdc901dde97bd576650
[SCSI] aacraid: probe related code cleanup

Sundry cleanups:
1) Use kzalloc instead of kmalloc.
2) Make sure probe worked before recalling the SCSI command to finalize
processing.
3) _aac_probe_container2 and _aac_probe_container1 return value goes
unused, change return to void.
4) Use a lower depth pointer reference to pick up the driver instance
variable.
5) Although effectively unused except to fake for scsicmd validity, set
the scsi_done in probe code to aac_probe_container_callback1 instead of
the less valid dummy reference to _aac_probe_container1.
6) SCp.phase is set in aac_valid_context, drop setting up this value in
caller when unnecessary.
7) take container target id at the beginning, rather than referencing
scmd_id() to pick it up.

There should be no side effects or functionality changes.

Signed-off-by: Mark Salyzyn <aacraid@adaptec.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/aacraid/aachba.c