]> err.no Git - linux-2.6/commit
[GFS2] Fix runtime issue with UP kernels
authorFabio Massimo Di Nitto <fabbione@ubuntu.com>
Fri, 16 Nov 2007 09:50:40 +0000 (09:50 +0000)
committerSteven Whitehouse <swhiteho@redhat.com>
Fri, 25 Jan 2008 08:08:06 +0000 (08:08 +0000)
commit1a2781cfa5ed8eb82bb311d684f268c1822dae69
treed65a551d4e0b8b12365fd150fe70cfd9f14f80e2
parent00c134756c5ad570a1ad3d6f93a67fc9c25a67ea
[GFS2] Fix runtime issue with UP kernels

The issue is indeed UP vs SMP and it is totally random.

spin_is_locked() is a bad assertion because there is no correct answer on UP.
on UP spin_is_locked() has to return either one value or another, always.

This means that in my setup I am lucky enough to trigger the issue and your you
are lucky enough not to.

the patch in attachment removes the bogus calls to BUG_ON and according to David
(in CC and thanks for the long explanation on the problem) we can rely upon
things like lockdep to find problem that might be trying to catch.

Signed-off-by: Fabio M. Di Nitto <fabbione@ubuntu.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/glock.c
fs/gfs2/log.c