]> err.no Git - linux-2.6/commit
[PATCH] Char: isicom, fix tty index check
authorJiri Slaby <jirislaby@gmail.com>
Fri, 8 Dec 2006 10:38:57 +0000 (02:38 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Fri, 8 Dec 2006 16:28:58 +0000 (08:28 -0800)
commit17c4edf0c8ee670de7b33d2a24eddd7c6b7edcf6
tree3c6d65a9f49d2319272e11ab14094266f381147d
parent11c838772d58d9807b1cb7fa4e0bec1b0302e318
[PATCH] Char: isicom, fix tty index check

Since tty->index is signed and may be < 0, we should assign this to int not
uint.  There is already a check to ensure if it is not negative, but gcc
complains with -W flag enabled and it is perfectly correct:
drivers/char/isicom.c:953: warning: comparison of unsigned expression < 0
is always false

Fix this issue by converting `line' variable from uint to int.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/isicom.c