]> err.no Git - linux-2.6/commit
md: fix use-after-free bug when dropping an rdev from an md array
authorNeilBrown <neilb@suse.de>
Wed, 6 Feb 2008 09:39:56 +0000 (01:39 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 6 Feb 2008 18:41:19 +0000 (10:41 -0800)
commit177a99b23ef9878c0cedcc7273108eba8a6e9472
tree616dd718e94a1e5e8ca536114d5fb91fa780bbc8
parenta17184a911195c274104df98a79bec10f57e735d
md: fix use-after-free bug when dropping an rdev from an md array

Due to possible deadlock issues we need to use a schedule work to kobject_del
an 'rdev' object from a different thread.

A recent change means that kobject_add no longer gets a refernce, and
kobject_del doesn't put a reference.  Consequently, we need to explicitly hold
a reference to ensure that the last reference isn't dropped before the
scheduled work get a chance to call kobject_del.

Also, rename delayed_delete to md_delayed_delete to that it is more obvious in
a stack trace which code is to blame.

Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/md/md.c