]> err.no Git - linux-2.6/commit
PCI: drivers/pci/pci-sysfs.c: Add missing pci_dev_put
authorJulia Lawall <julia@diku.dk>
Tue, 20 Nov 2007 07:41:16 +0000 (08:41 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 28 Nov 2007 22:35:26 +0000 (14:35 -0800)
commit151fc5dfc87964e85a1cbbb9cc2c0703c017c2ed
tree3c5bf6adaee5a5c3545071de5154c6e43b6bb901
parentbf164410d08dc83df416e3a6a43ab29bf88890ed
PCI: drivers/pci/pci-sysfs.c: Add missing pci_dev_put

There should be a pci_dev_put when breaking out of a loop that iterates
over calls to pci_get_device and similar functions.

This was fixed using the following semantic patch.

// <smpl>
@@
identifier d;
type T;
expression e;
iterator for_each_pci_dev;
@@

T *d;
...
for_each_pci_dev(d)
  {... when != pci_dev_put(d)
       when != e = d
(
   return d;
|
+  pci_dev_put(d);
?  return ...;
)
...}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/pci/pci-sysfs.c