]> err.no Git - linux-2.6/commit
Fix inequality comparison against "task->state"
authorLinus Torvalds <torvalds@g5.osdl.org>
Sat, 1 Oct 2005 18:04:18 +0000 (11:04 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 1 Oct 2005 18:04:18 +0000 (11:04 -0700)
commit14bf01bb0599c89fc7f426d20353b76e12555308
tree4d9c164faaff5df25044b15afa235debc96091dc
parentfd2e54b35bd70d11c160ded4834e2378e915356e
Fix inequality comparison against "task->state"

We should always use bitmask ops, rather than depend on some ordering of
the different states.  With the TASK_NONINTERACTIVE flag, the inequality
doesn't really work.

Oleg Nesterov argues (likely correctly) that this test is unnecessary in
the first place.  However, the minimal fix for now is to at least make
it work in the presense of TASK_NONINTERACTIVE.  Waiting for consensus
from Roland & co on potential bigger cleanups.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/exit.c