]> err.no Git - linux-2.6/commit
[IPV4]: Fix null dereference in ip_defrag
authorPhil Oester <kernel@linuxace.com>
Fri, 21 Mar 2008 22:01:50 +0000 (15:01 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 Mar 2008 22:01:50 +0000 (15:01 -0700)
commit12b101555f4a67db67a66966a516075bd477741f
tree940f5aab5d774a7265ffa47977ab1cad8e3bcc6b
parent94833dfb8c98ed4ca1944dd2c1339d88a2d1c758
[IPV4]: Fix null dereference in ip_defrag

Been seeing occasional panics in my testing of 2.6.25-rc in ip_defrag.
Offending line in ip_defrag is here:

net = skb->dev->nd_net

where dev is NULL.  Bisected the problem down to commit
ac18e7509e7df327e30d6e073a787d922eaf211d ([NETNS][FRAGS]: Make the
inet_frag_queue lookup work in namespaces).

Below patch (idea from Patrick McHardy) fixes the problem for me.

Signed-off-by: Phil Oester <kernel@linuxace.com>
Acked-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_fragment.c