]> err.no Git - linux-2.6/commit
pids: sys_getpgid: fix unsafe *pid usage, s/tasklist/rcu/
authorOleg Nesterov <oleg@tv-sign.ru>
Wed, 30 Apr 2008 07:54:29 +0000 (00:54 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 30 Apr 2008 15:29:49 +0000 (08:29 -0700)
commit12a3de0a965826096d8adc593bcf4392a7d5b459
tree764d69c2973e67cb3ae58bec02e29cd616c40f90
parent1dd768c0815334d2319d6377f0750ace075b6142
pids: sys_getpgid: fix unsafe *pid usage, s/tasklist/rcu/

1. sys_getpgid() needs rcu_read_lock() to derive the pgrp _nr, even if
   the task is current, otherwise we can race with another thread which
   does sys_setpgid().

2. Use rcu_read_lock() instead of tasklist_lock when pid != 0, make sure
   that we don't use the NULL pid if the task exits right after successful
   find_task_by_vpid().

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/sys.c