]> err.no Git - linux-2.6/commit
[PATCH] audit: fix audit_filter_user_rules() initialization bug
authorIngo Molnar <mingo@elte.hu>
Sat, 10 Feb 2007 09:46:09 +0000 (01:46 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Sun, 11 Feb 2007 18:51:34 +0000 (10:51 -0800)
commit11f57cedcf382574a1e41d6cec2349f287fcea67
treea8f2e930a6ef2a5aba1c63e254e41c731ac5c77b
parentead6596b9e776ac32d82f7d1931d7638e6d4a7bd
[PATCH] audit: fix audit_filter_user_rules() initialization bug

gcc emits this warning:

 kernel/auditfilter.c: In function 'audit_filter_user':
 kernel/auditfilter.c:1611: warning: 'state' is used uninitialized in this function

I tend to agree with gcc - there are a couple of plausible exit paths from
audit_filter_user_rules() where it does not set 'state', keeping the
variable uninitialized.  For example if a filter rule has an AUDIT_POSSIBLE
action.  Initialize to 'wont audit'.  Fix whitespace damage too.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/auditfilter.c