]> err.no Git - linux-2.6/commit
[PATCH] Fix root hole in pktcdvd
authorPeter Osterlund <petero2@telia.com>
Sat, 14 May 2005 07:58:30 +0000 (00:58 -0700)
committerGreg KH <gregkh@suse.de>
Tue, 17 May 2005 04:07:31 +0000 (21:07 -0700)
commit118326e940bdecef6c459d42ccf05256ba86daa7
tree13b1e48f4f3700603ed258c41e9e39978babf5ee
parent68f66feb300423bb9ee5daecb1951af394425a38
[PATCH] Fix root hole in pktcdvd

ioctl_by_bdev may only be used INSIDE the kernel.  If the "arg" argument
refers to memory that is accessed by put_user/get_user in the ioctl
function, the memory needs to be in the kernel address space (that's the
set_fs(KERNEL_DS) doing in the ioctl_by_bdev).  This works on i386 because
even with set_fs(KERNEL_DS) the user space memory is still accessible with
put_user/get_user.  That is not true for s390.  In short the ioctl
implementation of the pktcdvd device driver is horribly broken.

Signed-off-by: Peter Osterlund <petero2@telia.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/block/pktcdvd.c