]> err.no Git - linux-2.6/commit
[PATCH] uml: Fix process exit race
authorBodo Stroesser <bstroesser@fujitsu-siemens.com>
Sat, 7 May 2005 04:30:54 +0000 (21:30 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Sat, 7 May 2005 05:09:30 +0000 (22:09 -0700)
commit0f7e663dea7f0e22f3b2d07156c5e9d2e8656610
tree669450b10e1677d3ea65aa7695a7834f791ce329
parentb8bd0220c1ac6273eda66e25d992654219f846b6
[PATCH] uml: Fix process exit race

tt-mode closes switch_pipes in exit_thread_tt and kills processes in
switch_to_tt, if the exit_state is EXIT_DEAD or EXIT_ZOMBIE.

In very rare cases the exiting process can be scheduled out after having set
exit_state and closed switch_pipes (from release_task it calls proc_pid_flush,
which might sleep).  If this process is to be restarted, UML failes in
switch_to_tt with:

   write of switch_pipe failed, err = 9

We fix this by closing switch_pipes not in exit_thread_tt, but later in
release_thread_tt.  Additionally, we set switch_pipe[0] = 0 after closing.
switch_to_tt must not kill "from" process depending on its exit_state, but
must kill it after release_thread was processed only, so it examines
switch_pipe[0] for its decision.

Signed-off-by: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/um/kernel/process_kern.c
arch/um/kernel/skas/include/mode_kern-skas.h
arch/um/kernel/skas/process_kern.c
arch/um/kernel/tt/include/mode_kern-tt.h
arch/um/kernel/tt/process_kern.c