]> err.no Git - linux-2.6/commit
[VLAN]: Don't copy ALLMULTI/PROMISC flags from underlying device
authorPatrick McHardy <kaber@trash.net>
Wed, 26 Mar 2008 07:15:17 +0000 (00:15 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Mar 2008 07:15:17 +0000 (00:15 -0700)
commit0ed21b321a13421e2dfeaa70a6c324e05e3e91e6
treeedaabd8f35f77f6ef4e39c659621d3017845d944
parentf0c88f9c45f39acd017328515890481adcb32607
[VLAN]: Don't copy ALLMULTI/PROMISC flags from underlying device

Changing these flags requires to use dev_set_allmulti/dev_set_promiscuity
or dev_change_flags. Setting it directly causes two unwanted effects:

- the next dev_change_flags call will notice a difference between
  dev->gflags and the actual flags, enable promisc/allmulti
  mode and incorrectly update dev->gflags

- this keeps the underlying device in promisc/allmulti mode until
  the VLAN device is deleted

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/8021q/vlan_dev.c