]> err.no Git - linux-2.6/commit
projects / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f2df824) | patch
net: Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags()
authorDavid Woodhouse <dwmw2@infradead.org>
Tue, 20 May 2008 21:36:14 +0000 (14:36 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 May 2008 21:36:14 +0000 (14:36 -0700)
commit0e91796eb46e29edc791131c832a2232bcaed9dd
treee175a4b0de48e9e44b94e52dd634d38618193addtree | snapshot
parentf2df824948d559ea818e03486a8583e42ea6ab37commit | diff
net: Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags()

Am I just being particularly dim today, or can the call to
dev->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() never
happen?

We've just set dev->flags = flags & IFF_MULTICAST, effectively. So the
condition '(dev->flags ^ flags) & IFF_MULTICAST' is _never_ going to be
true.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c diff | blob | history
Linux 2.6 source tree