]> err.no Git - linux-2.6/commit
[PATCH] uml: fix UML network driver endianness bugs
authorBodo Stroesser <bstroesser@fujitsu-siemens.com>
Mon, 7 Nov 2005 08:58:47 +0000 (00:58 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 7 Nov 2005 15:53:30 +0000 (07:53 -0800)
commit0e76422ca5f34bb43b97c0945646ef072bcc1776
treeebd8509a9e94b01121c3da1b44a4df02ef60f973
parent4f0272415ad1867cea2a7ef5659769243ae50fbe
[PATCH] uml: fix UML network driver endianness bugs

ifa->ifa_address and ifa->ifa_mask are defined as __u32, but used as if they
were char[4].

Network code uses htons() to convert it.  So UML's method to access these
fields is wrong for bigendians (e.g.  s390)

I replaced bytewise copying by memcpy(), maybe even that might be removed, if
ifa->ifa_address/mask may be used immediately.

Signed-off-by: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo Giarrusso <blaisorblade@yahoo.it>
Cc: <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/um/drivers/net_kern.c
arch/um/include/net_user.h