]> err.no Git - linux-2.6/commit
V4L/DVB (6642): xc2028: don't duplicate max_len in priv
authorChris Pascoe <c.pascoe@itee.uq.edu.au>
Mon, 19 Nov 2007 12:29:59 +0000 (09:29 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Fri, 25 Jan 2008 21:02:27 +0000 (19:02 -0200)
commit0a196b6fa9b42a2bb49733b37565aaaa97ffb07f
treeaa968a19dd739ecd17bf1a4fe7dac8d603c6ec55
parenta44f1c43dfa98e2eb763968890157bfaf9001add
V4L/DVB (6642): xc2028: don't duplicate max_len in priv

There is no need to duplicate the max_len field from the ctrl structure
in the private data.  If we use it directly from priv->ctrl, we can memcpy
the structure (apart from strings) to reduce maintenance as it grows.

Enforce a minimum max_len length of 8 data bytes (+ 1 address byte) as seems
to be required by the tuner.

Also, use kstrdup instead of open coding the string duplication.

Signed-off-by: Chris Pascoe <c.pascoe@itee.uq.edu.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/tuner-xc2028.c