]> err.no Git - linux-2.6/commit
sata_promise: simplify port setup
authorMikael Pettersson <mikpe@it.uu.se>
Sun, 25 Feb 2007 16:51:15 +0000 (17:51 +0100)
committerJeff Garzik <jeff@garzik.org>
Sun, 25 Feb 2007 20:41:40 +0000 (15:41 -0500)
commit098cdff3d40286f87062c17cd07e98ca7ad94184
tree5507d29e76b66c6a5f06835777df7267fbaa38a7
parent540477b4d93f5b49f9e9ce3ae2437071103a0f8e
sata_promise: simplify port setup

Each place in pdc_ata_init_one() that initialises a SATA
port first calls pdc_ata_setup_port(), and then manually
assigns the port's ->scr_addr. Simplify the code by extending
pdc_ata_setup_port() to also handle scr_addr initialisation;
for PATA ports we pass NULL as scr_addr.

The initialisation of the PATA-only 20619 redundantly set
up scr_addr for the ports. Remove this.

Tested on 20619, 20575, and 20775 chips.

Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/sata_promise.c