]> err.no Git - linux-2.6/commit
[PATCH] ll_rw_blk: prevent huge request allocations
authorJens Axboe <axboe@suse.de>
Tue, 28 Jun 2005 14:35:11 +0000 (16:35 +0200)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Tue, 28 Jun 2005 21:56:50 +0000 (14:56 -0700)
commit082cf69eb82681f4eacb3a5653834c7970714bef
treea0817817c787a89abd0eb7e5bf6f217523060b63
parentf8b58edf3acf0dcc186b8330939000ecf709368a
[PATCH] ll_rw_blk: prevent huge request allocations

Currently we cap request allocations at q->nr_requests, but we allow a
batching io context to allocate up to 32 more (default setting).  This
can flood the queue with request allocations, with only a few batching
processes.  The real fix would be to limit the number of batchers, but
as that isn't currently tracked, I suggest we just cap the maximum
number of allocated requests to eg 50% over the limit.

This was observed in real life, users typically see this as vmstat bo
numbers going off the wall with seconds of no queueing afterwards.
Behaviour this bursty is not beneficial.

Signed-off-by: Jens Axboe <axboe@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/block/ll_rw_blk.c