]> err.no Git - linux-2.6/commit
knfsd: simplify a 'while' condition in svcsock.c
authorNeilBrown <neilb@suse.de>
Wed, 9 May 2007 09:34:55 +0000 (02:34 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 9 May 2007 19:30:54 +0000 (12:30 -0700)
commit05ed690efbb28b54af79f97af8c9705e82a6fbd7
treef6c5a437cb8f8c0a666cd1f1a13e39d1fa354146
parentc5e434c98b49f4877ea1614a629499e082b1a818
knfsd: simplify a 'while' condition in svcsock.c

This while loop has an overly complex condition, which performs a couple of
assignments.  This hurts readability.

We don't really need a loop at all.  We can just return -EAGAIN and (providing
we set SK_DATA), the function will be called again.

So discard the loop, make the complex conditional become a few clear function
calls, and hopefully improve readability.

Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
net/sunrpc/svcsock.c