]> err.no Git - linux-2.6/commit
serial8250: sanity check nr_uarts on all paths.
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 12 Jul 2008 20:47:53 +0000 (13:47 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 12 Jul 2008 21:33:41 +0000 (14:33 -0700)
commit05d81d2222beec7b63ac8c1c8cdb5bb4f82c2bad
tree787aaa15af631f6466476ee3ef6ec6c16888d59e
parentf31ad92f34913043cf008d6e479e92dfbaf02df1
serial8250: sanity check nr_uarts on all paths.

I had 8250.nr_uarts=16 in the boot line of a test kernel and I had a weird
mysterious crash in sysfs.  After taking an in-depth look I realized that
CONFIG_SERIAL_8250_NR_UARTS was set to 4 and I was walking off the end of
the serial8250_ports array.

Ouch!!!

Don't let this happen to someone else.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Acked-by: Alan Cox <alan@redhat.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/serial/8250.c