]> err.no Git - linux-2.6/commit
[PATCH] enum safety (sata_qstor)
authorAl Viro <viro@ftp.linux.org.uk>
Fri, 21 Oct 2005 05:46:02 +0000 (06:46 +0100)
committerJeff Garzik <jgarzik@pobox.com>
Fri, 21 Oct 2005 06:05:31 +0000 (02:05 -0400)
commit0420dd121d395e76f6b80fe232e7b4bc6a046f18
treeb45a5dbd3e1dda91eb92f856063146563f8f6f2a
parentb181d3b0121e141cb410ea3126b4dbe4f8e1751a
[PATCH] enum safety (sata_qstor)

sata_qstor strays into a nasty area - gcc handling of wide enums is
full of bugs that got fixed between gcc versions creating portability
nightmare.  Single-member enums are safe, so are ones that stay within
the range of int or unsigned int.  Anything beyond that is asking for
trouble.

Declaration of constants split in two enums, taking the ~0UL one into
a separate enum.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
drivers/scsi/sata_qstor.c