]> err.no Git - linux-2.6/commit
[PATCH] idmouse cleanup and overflow fix
authorAl Viro <viro@ftp.linux.org.uk>
Sat, 29 Oct 2005 10:56:13 +0000 (11:56 +0100)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 29 Oct 2005 17:35:08 +0000 (10:35 -0700)
commit018a2cdf1e633497bb4f01eb86a7cbffa611776d
tree515fd2723973f28a738c597d8630526b88650d40
parent32b32c2c3566b206988fa30336ec6534759823b5
[PATCH] idmouse cleanup and overflow fix

switched to simple_read_from_buffer(), killed broken use of min().
Incidentally, that use of min() had been fixed once, only to be
reintroduced in commit 4244f72436ab77c3c29a6447af81734ab3925d85:

    [PATCH] USB: upgrade of the idmouse driver

[snip]
-       if (count > IMGSIZE - *ppos)
-               count = IMGSIZE - *ppos;
+       count = min ((loff_t)count, IMGSIZE - (*ppos));

Note the lovely use of cast to shut the warning about misuse of min()
up...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/usb/misc/idmouse.c