]> err.no Git - linux-2.6/commit
[PATCH] USB serial visor: fix race in open/close
authorIan Abbott <abbotti@mev.co.uk>
Mon, 26 Jun 2006 10:44:22 +0000 (11:44 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 12 Jul 2006 23:03:22 +0000 (16:03 -0700)
commit00d6058ac93048b525b86fa48b413dcb87ac2728
tree8d5eab6af613e8832ba182e54ec9d7f634517a26
parent5650b4dd141e823c2b1bc248cb9ad3e9ac88cf19
[PATCH] USB serial visor: fix race in open/close

The anti user-DoS mechanism in the USB serial 'visor' driver can fail in
the following way:

visor_open: priv->outstanding_urbs = 0
visor_write: ++priv->outstanding_urbs
visor_close:
visor_open: priv->outstanding_urbs = 0
visor_write_bulk_callback: --priv->outstanding_urbs

So priv->outstanding_urbs ends up as (unsigned long)(-1).  Not good!

I haven't seen this happen with the visor driver as I don't have the
hardware, but I have seen it while testing a patch to implement the same
functionality in the ftdi_sio driver (patch not yet submitted).

The fix is pretty simple: don't reinitialize outstanding_urbs in
visor_open.  (Again, I haven't tested the fix in visor, but I have
tested it in ftdi_sio.)

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/visor.c