]> err.no Git - linux-2.6/commit
[TG3]: Convert to non-LLTX
authorMichael Chan <mchan@broadcom.com>
Sun, 18 Jun 2006 04:58:45 +0000 (21:58 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Jun 2006 04:58:45 +0000 (21:58 -0700)
commit00b7050426da8e7e58c889c5c80a19920d2d41b3
tree55a07464fdf81b23fced966feca2b041af77c6f6
parentc71302d61f844f766a44e1b04258086cc41f624e
[TG3]: Convert to non-LLTX

Herbert Xu pointed out that it is unsafe to call netif_tx_disable()
from LLTX drivers because it uses dev->xmit_lock to synchronize
whereas LLTX drivers use private locks.

Convert tg3 to non-LLTX to fix this issue. tg3 is a lockless driver
where hard_start_xmit and tx completion handling can run concurrently
under normal conditions. A tx_lock is only needed to prevent
netif_stop_queue and netif_wake_queue race condtions when the queue
is full.

So whether we use LLTX or non-LLTX, it makes practically no
difference.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tg3.c
drivers/net/tg3.h