X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=net%2Fipv4%2Ficmp.c;h=02a899bec1969fcb6511722d41fe20009b6f2dbc;hb=c21723edd5f6c288ab613ed658b7140e07fc7209;hp=d38cbba92a4dddf62a7d53da29671ce0fa1896d7;hpb=27a884dc3cb63b93c2b3b643f5b31eed5f8a4d26;p=linux-2.6

diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index d38cbba92a..02a899bec1 100644
--- a/net/ipv4/icmp.c
+++ b/net/ipv4/icmp.c
@@ -514,9 +514,15 @@ void icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info)
 
 	saddr = iph->daddr;
 	if (!(rt->rt_flags & RTCF_LOCAL)) {
-		if (sysctl_icmp_errors_use_inbound_ifaddr)
-			saddr = inet_select_addr(skb_in->dev, 0, RT_SCOPE_LINK);
-		else
+		struct net_device *dev = NULL;
+
+		if (rt->fl.iif && sysctl_icmp_errors_use_inbound_ifaddr)
+			dev = dev_get_by_index(rt->fl.iif);
+
+		if (dev) {
+			saddr = inet_select_addr(dev, 0, RT_SCOPE_LINK);
+			dev_put(dev);
+		} else
 			saddr = 0;
 	}