X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=drivers%2Facpi%2Ftoshiba_acpi.c;h=9e8c20c6a0b7243e708876a4dfffa30dd8f47506;hb=26145f7e7ebc8a5f1b29425d6da62e872031be4a;hp=1cfbecb0ac10463fa5dfe0afb8741cfc384d2cae;hpb=fcf75356e9cf0460ef47a5b756bc3b0951ecab59;p=linux-2.6 diff --git a/drivers/acpi/toshiba_acpi.c b/drivers/acpi/toshiba_acpi.c index 1cfbecb0ac..9e8c20c6a0 100644 --- a/drivers/acpi/toshiba_acpi.c +++ b/drivers/acpi/toshiba_acpi.c @@ -362,7 +362,7 @@ static unsigned long write_video(const char *buffer, unsigned long count) int crt_out = -1; int tv_out = -1; u32 hci_result; - int video_out; + u32 video_out; /* scan expression. Multiple expressions may be delimited with ; * @@ -524,7 +524,7 @@ static acpi_status __init add_device(void) return AE_OK; } -static acpi_status __exit remove_device(void) +static acpi_status remove_device(void) { ProcItem *item; @@ -591,9 +591,12 @@ static int __init toshiba_acpi_init(void) NULL, &toshiba_backlight_data); if (IS_ERR(toshiba_backlight_device)) { + int ret = PTR_ERR(toshiba_backlight_device); + printk(KERN_ERR "Could not register toshiba backlight device\n"); toshiba_backlight_device = NULL; toshiba_acpi_exit(); + return ret; } toshiba_backlight_device->props.max_brightness = HCI_LCD_BRIGHTNESS_LEVELS - 1;