X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=blobdiff_plain;ds=sidebyside;f=sound%2Fpci%2Fad1889.c;h=39ec55b57b1e808ffef72e96cbea23bc9095cabd;hb=b17b3d479c4c43c3a980ee553c3be3ca456523de;hp=cbf8331c3d336aab210b3acf886e44c5f8e2f4ea;hpb=6d03a68e6d5528630955452ec4b768dbde0dc00c;p=linux-2.6 diff --git a/sound/pci/ad1889.c b/sound/pci/ad1889.c index cbf8331c3d..39ec55b57b 100644 --- a/sound/pci/ad1889.c +++ b/sound/pci/ad1889.c @@ -40,7 +40,6 @@ #include #include -#include #include #include #include @@ -265,10 +264,10 @@ snd_ad1889_ac97_ready(struct snd_ad1889 *chip) mdelay(1); if (!retry) { snd_printk(KERN_ERR PFX "[%s] Link is not ready.\n", - __FUNCTION__); + __func__); return -EIO; } - ad1889_debug("[%s] ready after %d ms\n", __FUNCTION__, 400 - retry); + ad1889_debug("[%s] ready after %d ms\n", __func__, 400 - retry); return 0; } @@ -855,10 +854,8 @@ snd_ad1889_free(struct snd_ad1889 *chip) spin_unlock_irq(&chip->lock); - synchronize_irq(chip->irq); - if (chip->irq >= 0) - free_irq(chip->irq, (void*)chip); + free_irq(chip->irq, chip); skip_hw: if (chip->iobase) @@ -945,7 +942,7 @@ snd_ad1889_create(struct snd_card *card, spin_lock_init(&chip->lock); /* only now can we call ad1889_free */ if (request_irq(pci->irq, snd_ad1889_interrupt, - IRQF_DISABLED|IRQF_SHARED, card->driver, (void*)chip)) { + IRQF_SHARED, card->driver, chip)) { printk(KERN_ERR PFX "cannot obtain IRQ %d\n", pci->irq); snd_ad1889_free(chip); return -EBUSY; @@ -1055,7 +1052,7 @@ static struct pci_device_id snd_ad1889_ids[] = { }; MODULE_DEVICE_TABLE(pci, snd_ad1889_ids); -static struct pci_driver ad1889_pci = { +static struct pci_driver ad1889_pci_driver = { .name = "AD1889 Audio", .id_table = snd_ad1889_ids, .probe = snd_ad1889_probe, @@ -1065,13 +1062,13 @@ static struct pci_driver ad1889_pci = { static int __init alsa_ad1889_init(void) { - return pci_register_driver(&ad1889_pci); + return pci_register_driver(&ad1889_pci_driver); } static void __exit alsa_ad1889_fini(void) { - pci_unregister_driver(&ad1889_pci); + pci_unregister_driver(&ad1889_pci_driver); } module_init(alsa_ad1889_init);