futex: fix init order

[linux-2.6] / fs / ocfs2 / dir.c

diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
index e1535133841771ee9481adf2720b0f860a4eddef..e280833ceb9aa76bd8404ded84b6047948b0ca9d 100644 (file)
--- a/fs/ocfs2/dir.c
+++ b/fs/ocfs2/dir.c
@@ -208,9 +208,9 @@ out:
        return NULL;
 }
 
-struct buffer_head *ocfs2_find_entry_el(const char *name, int namelen,
-                                       struct inode *dir,
-                                       struct ocfs2_dir_entry **res_dir)
+static struct buffer_head *ocfs2_find_entry_el(const char *name, int namelen,
+                                              struct inode *dir,
+                                              struct ocfs2_dir_entry **res_dir)
 {
        struct super_block *sb;
        struct buffer_head *bh_use[NAMEI_RA_SIZE];
@@ -586,9 +586,9 @@ bail:
 }
 
 static int ocfs2_dir_foreach_blk_id(struct inode *inode,
-                                   unsigned long *f_version,
+                                   u64 *f_version,
                                    loff_t *f_pos, void *priv,
-                                   filldir_t filldir)
+                                   filldir_t filldir, int *filldir_err)
 {
        int ret, i, filldir_ret;
        unsigned long offset = *f_pos;
@@ -648,7 +648,7 @@ revalidate:
                         * not the directory has been modified
                         * during the copy operation.
                         */
-                       unsigned long version = *f_version;
+                       u64 version = *f_version;
                        unsigned char d_type = DT_UNKNOWN;
 
                        if (de->file_type < OCFS2_FT_MAX)
@@ -659,8 +659,11 @@ revalidate:
                                              *f_pos,
                                              le64_to_cpu(de->inode),
                                              d_type);
-                       if (filldir_ret)
+                       if (filldir_ret) {
+                               if (filldir_err)
+                                       *filldir_err = filldir_ret;
                                break;
+                       }
                        if (version != *f_version)
                                goto revalidate;
                }
@@ -674,9 +677,9 @@ out:
 }
 
 static int ocfs2_dir_foreach_blk_el(struct inode *inode,
-                                   unsigned long *f_version,
+                                   u64 *f_version,
                                    loff_t *f_pos, void *priv,
-                                   filldir_t filldir)
+                                   filldir_t filldir, int *filldir_err)
 {
        int error = 0;
        unsigned long offset, blk, last_ra_blk = 0;
@@ -775,8 +778,11 @@ revalidate:
                                                *f_pos,
                                                le64_to_cpu(de->inode),
                                                d_type);
-                               if (error)
+                               if (error) {
+                                       if (filldir_err)
+                                               *filldir_err = error;
                                        break;
+                               }
                                if (version != *f_version)
                                        goto revalidate;
                                stored ++;
@@ -792,14 +798,16 @@ out:
        return stored;
 }
 
-static int ocfs2_dir_foreach_blk(struct inode *inode, unsigned long *f_version,
-                                loff_t *f_pos, void *priv, filldir_t filldir)
+static int ocfs2_dir_foreach_blk(struct inode *inode, u64 *f_version,
+                                loff_t *f_pos, void *priv, filldir_t filldir,
+                                int *filldir_err)
 {
        if (OCFS2_I(inode)->ip_dyn_features & OCFS2_INLINE_DATA_FL)
                return ocfs2_dir_foreach_blk_id(inode, f_version, f_pos, priv,
-                                               filldir);
+                                               filldir, filldir_err);
 
-       return ocfs2_dir_foreach_blk_el(inode, f_version, f_pos, priv, filldir);
+       return ocfs2_dir_foreach_blk_el(inode, f_version, f_pos, priv, filldir,
+                                       filldir_err);
 }
 
 /*
@@ -809,16 +817,19 @@ static int ocfs2_dir_foreach_blk(struct inode *inode, unsigned long *f_version,
 int ocfs2_dir_foreach(struct inode *inode, loff_t *f_pos, void *priv,
                      filldir_t filldir)
 {
-       int ret = 0;
-       unsigned long version = inode->i_version;
+       int ret = 0, filldir_err = 0;
+       u64 version = inode->i_version;
 
        while (*f_pos < i_size_read(inode)) {
                ret = ocfs2_dir_foreach_blk(inode, &version, f_pos, priv,
-                                           filldir);
-               if (ret)
+                                           filldir, &filldir_err);
+               if (ret || filldir_err)
                        break;
        }
 
+       if (ret > 0)
+               ret = -EIO;
+
        return 0;
 }
 
@@ -835,14 +846,14 @@ int ocfs2_readdir(struct file * filp, void * dirent, filldir_t filldir)
        mlog_entry("dirino=%llu\n",
                   (unsigned long long)OCFS2_I(inode)->ip_blkno);
 
-       error = ocfs2_meta_lock_atime(inode, filp->f_vfsmnt, &lock_level);
+       error = ocfs2_inode_lock_atime(inode, filp->f_vfsmnt, &lock_level);
        if (lock_level && error >= 0) {
                /* We release EX lock which used to update atime
                 * and get PR lock again to reduce contention
                 * on commonly accessed directories. */
-               ocfs2_meta_unlock(inode, 1);
+               ocfs2_inode_unlock(inode, 1);
                lock_level = 0;
-               error = ocfs2_meta_lock(inode, NULL, 0);
+               error = ocfs2_inode_lock(inode, NULL, 0);
        }
        if (error < 0) {
                if (error != -ENOENT)
@@ -852,9 +863,9 @@ int ocfs2_readdir(struct file * filp, void * dirent, filldir_t filldir)
        }
 
        error = ocfs2_dir_foreach_blk(inode, &filp->f_version, &filp->f_pos,
-                                     dirent, filldir);
+                                     dirent, filldir, NULL);
 
-       ocfs2_meta_unlock(inode, lock_level);
+       ocfs2_inode_unlock(inode, lock_level);
 
 bail_nolock:
        mlog_exit(error);
@@ -1204,7 +1215,7 @@ static int ocfs2_expand_inline_dir(struct inode *dir, struct buffer_head *di_bh,
        down_write(&oi->ip_alloc_sem);
 
        /*
-        * Prepare for worst case allocation scenario of two seperate
+        * Prepare for worst case allocation scenario of two separate
         * extents.
         */
        if (alloc == 2)