]> err.no Git - linux-2.6/blobdiff - fs/jffs2/summary.c
[JFFS2] Correct handling of JFFS2_FEATURE_RWCOMPAT_COPY nodes.
[linux-2.6] / fs / jffs2 / summary.c
index cb5dd8f11e733009990a31fc1563bd93f8f135bd..53a84b468cfe223a38f669a1e4168d600ecc43ed 100644 (file)
@@ -5,10 +5,11 @@
  *                     Zoltan Sogor <weth@inf.u-szeged.hu>,
  *                     Patrik Kluba <pajko@halom.u-szeged.hu>,
  *                     University of Szeged, Hungary
+ *               2005  KaiGai Kohei <kaigai@ak.jp.nec.com>
  *
  * For licensing information, see the file 'LICENCE' in this directory.
  *
- * $Id: summary.c,v 1.1 2005/09/07 08:34:54 havasi Exp $
+ * $Id: summary.c,v 1.4 2005/09/26 11:37:21 havasi Exp $
  *
  */
 
@@ -38,17 +39,18 @@ int jffs2_sum_init(struct jffs2_sb_info *c)
 
        if (!c->summary->sum_buf) {
                JFFS2_WARNING("Can't allocate buffer for writing out summary information!\n");
+               kfree(c->summary);
                return -ENOMEM;
        }
 
-       JFFS2_DBG_SUMMARY("returned succesfully\n");
+       dbg_summary("returned succesfully\n");
 
        return 0;
 }
 
 void jffs2_sum_exit(struct jffs2_sb_info *c)
 {
-       JFFS2_DBG_SUMMARY("called\n");
+       dbg_summary("called\n");
 
        jffs2_sum_disable_collecting(c->summary);
 
@@ -71,17 +73,30 @@ static int jffs2_sum_add_mem(struct jffs2_summary *s, union jffs2_sum_mem *item)
                case JFFS2_NODETYPE_INODE:
                        s->sum_size += JFFS2_SUMMARY_INODE_SIZE;
                        s->sum_num++;
-                       JFFS2_DBG_SUMMARY("inode (%u) added to summary\n",
+                       dbg_summary("inode (%u) added to summary\n",
                                                je32_to_cpu(item->i.inode));
                        break;
                case JFFS2_NODETYPE_DIRENT:
                        s->sum_size += JFFS2_SUMMARY_DIRENT_SIZE(item->d.nsize);
                        s->sum_num++;
-                       JFFS2_DBG_SUMMARY("dirent (%u) added to summary\n",
+                       dbg_summary("dirent (%u) added to summary\n",
                                                je32_to_cpu(item->d.ino));
                        break;
+#ifdef CONFIG_JFFS2_FS_XATTR
+               case JFFS2_NODETYPE_XATTR:
+                       s->sum_size += JFFS2_SUMMARY_XATTR_SIZE;
+                       s->sum_num++;
+                       dbg_summary("xattr (xid=%u, version=%u) added to summary\n",
+                                   je32_to_cpu(item->x.xid), je32_to_cpu(item->x.version));
+                       break;
+               case JFFS2_NODETYPE_XREF:
+                       s->sum_size += JFFS2_SUMMARY_XREF_SIZE;
+                       s->sum_num++;
+                       dbg_summary("xref added to summary\n");
+                       break;
+#endif
                default:
-                       JFFS2_WARNING("UNKNOWN node type %u\n", 
+                       JFFS2_WARNING("UNKNOWN node type %u\n",
                                            je16_to_cpu(item->u.nodetype));
                        return 1;
        }
@@ -93,7 +108,7 @@ static int jffs2_sum_add_mem(struct jffs2_summary *s, union jffs2_sum_mem *item)
 
 int jffs2_sum_add_padding_mem(struct jffs2_summary *s, uint32_t size)
 {
-       JFFS2_DBG_SUMMARY("called with %u\n", size);
+       dbg_summary("called with %u\n", size);
        s->sum_padded += size;
        return 0;
 }
@@ -140,6 +155,40 @@ int jffs2_sum_add_dirent_mem(struct jffs2_summary *s, struct jffs2_raw_dirent *r
        return jffs2_sum_add_mem(s, (union jffs2_sum_mem *)temp);
 }
 
+#ifdef CONFIG_JFFS2_FS_XATTR
+int jffs2_sum_add_xattr_mem(struct jffs2_summary *s, struct jffs2_raw_xattr *rx, uint32_t ofs)
+{
+       struct jffs2_sum_xattr_mem *temp;
+
+       temp = kmalloc(sizeof(struct jffs2_sum_xattr_mem), GFP_KERNEL);
+       if (!temp)
+               return -ENOMEM;
+
+       temp->nodetype = rx->nodetype;
+       temp->xid = rx->xid;
+       temp->version = rx->version;
+       temp->offset = cpu_to_je32(ofs);
+       temp->totlen = rx->totlen;
+       temp->next = NULL;
+
+       return jffs2_sum_add_mem(s, (union jffs2_sum_mem *)temp);
+}
+
+int jffs2_sum_add_xref_mem(struct jffs2_summary *s, struct jffs2_raw_xref *rr, uint32_t ofs)
+{
+       struct jffs2_sum_xref_mem *temp;
+
+       temp = kmalloc(sizeof(struct jffs2_sum_xref_mem), GFP_KERNEL);
+       if (!temp)
+               return -ENOMEM;
+
+       temp->nodetype = rr->nodetype;
+       temp->offset = cpu_to_je32(ofs);
+       temp->next = NULL;
+
+       return jffs2_sum_add_mem(s, (union jffs2_sum_mem *)temp);
+}
+#endif
 /* Cleanup every collected summary information */
 
 static void jffs2_sum_clean_collected(struct jffs2_summary *s)
@@ -147,7 +196,7 @@ static void jffs2_sum_clean_collected(struct jffs2_summary *s)
        union jffs2_sum_mem *temp;
 
        if (!s->sum_list_head) {
-               JFFS2_DBG_SUMMARY("already empty\n");
+               dbg_summary("already empty\n");
        }
        while (s->sum_list_head) {
                temp = s->sum_list_head;
@@ -161,19 +210,19 @@ static void jffs2_sum_clean_collected(struct jffs2_summary *s)
 
 void jffs2_sum_reset_collected(struct jffs2_summary *s)
 {
-       JFFS2_DBG_SUMMARY("called\n");
+       dbg_summary("called\n");
        jffs2_sum_clean_collected(s);
        s->sum_size = 0;
 }
 
 void jffs2_sum_disable_collecting(struct jffs2_summary *s)
 {
-       JFFS2_DBG_SUMMARY("called\n");
+       dbg_summary("called\n");
        jffs2_sum_clean_collected(s);
        s->sum_size = JFFS2_SUMMARY_NOSUM_SIZE;
 }
 
-int jffs2_sum_is_disabled(struct jffs2_summary *s) 
+int jffs2_sum_is_disabled(struct jffs2_summary *s)
 {
        return (s->sum_size == JFFS2_SUMMARY_NOSUM_SIZE);
 }
@@ -182,7 +231,7 @@ int jffs2_sum_is_disabled(struct jffs2_summary *s)
 
 void jffs2_sum_move_collected(struct jffs2_sb_info *c, struct jffs2_summary *s)
 {
-       JFFS2_DBG_SUMMARY("oldsize=0x%x oldnum=%u => newsize=0x%x newnum=%u\n",
+       dbg_summary("oldsize=0x%x oldnum=%u => newsize=0x%x newnum=%u\n",
                                c->summary->sum_size, c->summary->sum_num,
                                s->sum_size, s->sum_num);
 
@@ -258,18 +307,51 @@ int jffs2_sum_add_kvec(struct jffs2_sb_info *c, const struct kvec *invecs,
 
                        return jffs2_sum_add_mem(c->summary, (union jffs2_sum_mem *)temp);
                }
+#ifdef CONFIG_JFFS2_FS_XATTR
+               case JFFS2_NODETYPE_XATTR: {
+                       struct jffs2_sum_xattr_mem *temp;
+                       if (je32_to_cpu(node->x.version) == 0xffffffff)
+                               return 0;
+                       temp = kmalloc(sizeof(struct jffs2_sum_xattr_mem), GFP_KERNEL);
+                       if (!temp)
+                               goto no_mem;
 
+                       temp->nodetype = node->x.nodetype;
+                       temp->xid = node->x.xid;
+                       temp->version = node->x.version;
+                       temp->totlen = node->x.totlen;
+                       temp->offset = cpu_to_je32(ofs);
+                       temp->next = NULL;
+
+                       return jffs2_sum_add_mem(c->summary, (union jffs2_sum_mem *)temp);
+               }
+               case JFFS2_NODETYPE_XREF: {
+                       struct jffs2_sum_xref_mem *temp;
+
+                       if (je32_to_cpu(node->r.ino) == 0xffffffff
+                           && je32_to_cpu(node->r.xid) == 0xffffffff)
+                               return 0;
+                       temp = kmalloc(sizeof(struct jffs2_sum_xref_mem), GFP_KERNEL);
+                       if (!temp)
+                               goto no_mem;
+                       temp->nodetype = node->r.nodetype;
+                       temp->offset = cpu_to_je32(ofs);
+                       temp->next = NULL;
+
+                       return jffs2_sum_add_mem(c->summary, (union jffs2_sum_mem *)temp);
+               }
+#endif
                case JFFS2_NODETYPE_PADDING:
-                       JFFS2_DBG_SUMMARY("node PADDING\n");
+                       dbg_summary("node PADDING\n");
                        c->summary->sum_padded += je32_to_cpu(node->u.totlen);
                        break;
 
                case JFFS2_NODETYPE_CLEANMARKER:
-                       JFFS2_DBG_SUMMARY("node CLEANMARKER\n");
+                       dbg_summary("node CLEANMARKER\n");
                        break;
 
                case JFFS2_NODETYPE_SUMMARY:
-                       JFFS2_DBG_SUMMARY("node SUMMARY\n");
+                       dbg_summary("node SUMMARY\n");
                        break;
 
                default:
@@ -291,7 +373,7 @@ no_mem:
 /* Process the stored summary information - helper function for jffs2_sum_scan_sumnode() */
 
 static int jffs2_sum_process_sum_data(struct jffs2_sb_info *c, struct jffs2_eraseblock *jeb,
-                               struct jffs2_summary_node *summary, uint32_t *pseudo_random)
+                               struct jffs2_raw_summary *summary, uint32_t *pseudo_random)
 {
        struct jffs2_raw_node_ref *raw;
        struct jffs2_inode_cache *ic;
@@ -302,7 +384,7 @@ static int jffs2_sum_process_sum_data(struct jffs2_sb_info *c, struct jffs2_eras
        sp = summary->sum;
 
        for (i=0; i<je32_to_cpu(summary->sum_num); i++) {
-               JFFS2_DBG_SUMMARY("processing summary index %d\n", i);
+               dbg_summary("processing summary index %d\n", i);
 
                switch (je16_to_cpu(((struct jffs2_sum_unknown_flash *)sp)->nodetype)) {
                        case JFFS2_NODETYPE_INODE: {
@@ -311,13 +393,12 @@ static int jffs2_sum_process_sum_data(struct jffs2_sb_info *c, struct jffs2_eras
 
                                ino = je32_to_cpu(spi->inode);
 
-                               JFFS2_DBG_SUMMARY("Inode at 0x%08x\n",
+                               dbg_summary("Inode at 0x%08x\n",
                                                        jeb->offset + je32_to_cpu(spi->offset));
 
                                raw = jffs2_alloc_raw_node_ref();
                                if (!raw) {
                                        JFFS2_NOTICE("allocation of node reference failed\n");
-                                       kfree(summary);
                                        return -ENOMEM;
                                }
 
@@ -325,24 +406,17 @@ static int jffs2_sum_process_sum_data(struct jffs2_sb_info *c, struct jffs2_eras
                                if (!ic) {
                                        JFFS2_NOTICE("scan_make_ino_cache failed\n");
                                        jffs2_free_raw_node_ref(raw);
-                                       kfree(summary);
                                        return -ENOMEM;
                                }
 
                                raw->flash_offset = (jeb->offset + je32_to_cpu(spi->offset)) | REF_UNCHECKED;
-                               raw->__totlen = PAD(je32_to_cpu(spi->totlen));
-                               raw->next_phys = NULL;
-                               raw->next_in_ino = ic->nodes;
 
+                               raw->next_in_ino = ic->nodes;
                                ic->nodes = raw;
-                               if (!jeb->first_node)
-                                       jeb->first_node = raw;
-                               if (jeb->last_node)
-                                       jeb->last_node->next_phys = raw;
-                               jeb->last_node = raw;
-                               *pseudo_random += je32_to_cpu(spi->version);
 
-                               UNCHECKED_SPACE(PAD(je32_to_cpu(spi->totlen)));
+                               jffs2_link_node_ref(c, jeb, raw, PAD(je32_to_cpu(spi->totlen)));
+
+                               *pseudo_random += je32_to_cpu(spi->version);
 
                                sp += JFFS2_SUMMARY_INODE_SIZE;
 
@@ -353,14 +427,12 @@ static int jffs2_sum_process_sum_data(struct jffs2_sb_info *c, struct jffs2_eras
                                struct jffs2_sum_dirent_flash *spd;
                                spd = sp;
 
-                               JFFS2_DBG_SUMMARY("Dirent at 0x%08x\n",
+                               dbg_summary("Dirent at 0x%08x\n",
                                                        jeb->offset + je32_to_cpu(spd->offset));
 
                                fd = jffs2_alloc_full_dirent(spd->nsize+1);
-                               if (!fd) {
-                                       kfree(summary);
+                               if (!fd)
                                        return -ENOMEM;
-                               }
 
                                memcpy(&fd->name, spd->name, spd->nsize);
                                fd->name[spd->nsize] = 0;
@@ -369,7 +441,6 @@ static int jffs2_sum_process_sum_data(struct jffs2_sb_info *c, struct jffs2_eras
                                if (!raw) {
                                        jffs2_free_full_dirent(fd);
                                        JFFS2_NOTICE("allocation of node reference failed\n");
-                                       kfree(summary);
                                        return -ENOMEM;
                                }
 
@@ -377,20 +448,14 @@ static int jffs2_sum_process_sum_data(struct jffs2_sb_info *c, struct jffs2_eras
                                if (!ic) {
                                        jffs2_free_full_dirent(fd);
                                        jffs2_free_raw_node_ref(raw);
-                                       kfree(summary);
                                        return -ENOMEM;
                                }
 
-                               raw->__totlen = PAD(je32_to_cpu(spd->totlen));
                                raw->flash_offset = (jeb->offset + je32_to_cpu(spd->offset)) | REF_PRISTINE;
-                               raw->next_phys = NULL;
                                raw->next_in_ino = ic->nodes;
                                ic->nodes = raw;
-                               if (!jeb->first_node)
-                                       jeb->first_node = raw;
-                               if (jeb->last_node)
-                                       jeb->last_node->next_phys = raw;
-                               jeb->last_node = raw;
+
+                               jffs2_link_node_ref(c, jeb, raw, PAD(je32_to_cpu(spd->totlen)));
 
                                fd->raw = raw;
                                fd->next = NULL;
@@ -398,7 +463,7 @@ static int jffs2_sum_process_sum_data(struct jffs2_sb_info *c, struct jffs2_eras
                                fd->ino = je32_to_cpu(spd->ino);
                                fd->nhash = full_name_hash(fd->name, spd->nsize);
                                fd->type = spd->type;
-                               USED_SPACE(PAD(je32_to_cpu(spd->totlen)));
+
                                jffs2_add_fd_to_list(c, fd, &ic->scan_dents);
 
                                *pseudo_random += je32_to_cpu(spd->version);
@@ -407,48 +472,112 @@ static int jffs2_sum_process_sum_data(struct jffs2_sb_info *c, struct jffs2_eras
 
                                break;
                        }
+#ifdef CONFIG_JFFS2_FS_XATTR
+                       case JFFS2_NODETYPE_XATTR: {
+                               struct jffs2_xattr_datum *xd;
+                               struct jffs2_sum_xattr_flash *spx;
+                               uint32_t ofs;
+
+                               spx = (struct jffs2_sum_xattr_flash *)sp;
+                               ofs = jeb->offset + je32_to_cpu(spx->offset);
+                               dbg_summary("xattr at %#08x (xid=%u, version=%u)\n", ofs,
+                                           je32_to_cpu(spx->xid), je32_to_cpu(spx->version));
+                               raw = jffs2_alloc_raw_node_ref();
+                               if (!raw) {
+                                       JFFS2_NOTICE("allocation of node reference failed\n");
+                                       kfree(summary);
+                                       return -ENOMEM;
+                               }
+                               xd = jffs2_setup_xattr_datum(c, je32_to_cpu(spx->xid),
+                                                               je32_to_cpu(spx->version));
+                               if (IS_ERR(xd)) {
+                                       jffs2_free_raw_node_ref(raw);
+                                       if (PTR_ERR(xd) == -EEXIST) {
+                                               /* a newer version of xd exists */
+                                               DIRTY_SPACE(je32_to_cpu(spx->totlen));
+                                               sp += JFFS2_SUMMARY_XATTR_SIZE;
+                                               break;
+                                       }
+                                       JFFS2_NOTICE("allocation of xattr_datum failed\n");
+                                       kfree(summary);
+                                       return PTR_ERR(xd);
+                               }
+                               xd->node = raw;
+
+                               raw->flash_offset = ofs | REF_UNCHECKED;
+                               raw->next_in_ino = (void *)xd;
+
+                               jffs2_link_node_ref(c, jeb, raw, PAD(je32_to_cpu(spx->totlen)));
+
+                               *pseudo_random += je32_to_cpu(spx->xid);
+                               sp += JFFS2_SUMMARY_XATTR_SIZE;
+
+                               break;
+                       }
+                       case JFFS2_NODETYPE_XREF: {
+                               struct jffs2_xattr_ref *ref;
+                               struct jffs2_sum_xref_flash *spr;
+                               uint32_t ofs;
+
+                               spr = (struct jffs2_sum_xref_flash *)sp;
+                               ofs = jeb->offset + je32_to_cpu(spr->offset);
+                               dbg_summary("xref at %#08x (xid=%u, ino=%u)\n", ofs,
+                                           je32_to_cpu(spr->xid), je32_to_cpu(spr->ino));
+                               raw = jffs2_alloc_raw_node_ref();
+                               if (!raw) {
+                                       JFFS2_NOTICE("allocation of node reference failed\n");
+                                       kfree(summary);
+                                       return -ENOMEM;
+                               }
+                               ref = jffs2_alloc_xattr_ref();
+                               if (!ref) {
+                                       JFFS2_NOTICE("allocation of xattr_datum failed\n");
+                                       jffs2_free_raw_node_ref(raw);
+                                       kfree(summary);
+                                       return -ENOMEM;
+                               }
+                               ref->ino = 0xfffffffe;
+                               ref->xid = 0xfffffffd;
+                               ref->node = raw;
+                               ref->next = c->xref_temp;
+                               c->xref_temp = ref;
+
+                               raw->flash_offset = ofs | REF_UNCHECKED;
+                               raw->next_in_ino = (void *)ref;
 
+                               jffs2_link_node_ref(c, jeb, raw, PAD(sizeof(struct jffs2_raw_xref)));
+
+                               *pseudo_random += ofs;
+                               sp += JFFS2_SUMMARY_XREF_SIZE;
+
+                               break;
+                       }
+#endif
                        default : {
+printk("nodetype = %#04x\n",je16_to_cpu(((struct jffs2_sum_unknown_flash *)sp)->nodetype));
                                JFFS2_WARNING("Unsupported node type found in summary! Exiting...");
-                               kfree(summary);
                                return -EIO;
                        }
                }
        }
 
-       kfree(summary);
        return 0;
 }
 
 /* Process the summary node - called from jffs2_scan_eraseblock() */
-
 int jffs2_sum_scan_sumnode(struct jffs2_sb_info *c, struct jffs2_eraseblock *jeb,
-                               uint32_t ofs, uint32_t *pseudo_random)
+                          struct jffs2_raw_summary *summary, uint32_t sumsize,
+                          uint32_t *pseudo_random)
 {
        struct jffs2_unknown_node crcnode;
        struct jffs2_raw_node_ref *cache_ref;
-       struct jffs2_summary_node *summary;
-       int ret, sumsize;
+       int ret, ofs;
        uint32_t crc;
 
-       sumsize = c->sector_size - ofs;
-       ofs += jeb->offset;
-
-       JFFS2_DBG_SUMMARY("summary found for 0x%08x at 0x%08x (0x%x bytes)\n",
-                               jeb->offset, ofs, sumsize);
-
-       summary = kmalloc(sumsize, GFP_KERNEL);
+       ofs = jeb->offset + c->sector_size - sumsize;
 
-       if (!summary) {
-               return -ENOMEM;
-       }
-
-       ret = jffs2_fill_scan_buf(c, (unsigned char *)summary, ofs, sumsize);
-
-       if (ret) {
-               kfree(summary);
-               return ret;
-       }
+       dbg_summary("summary found for 0x%08x at 0x%08x (0x%x bytes)\n",
+                   jeb->offset, ofs, sumsize);
 
        /* OK, now check for node validity and CRC */
        crcnode.magic = cpu_to_je16(JFFS2_MAGIC_BITMASK);
@@ -457,58 +586,54 @@ int jffs2_sum_scan_sumnode(struct jffs2_sb_info *c, struct jffs2_eraseblock *jeb
        crc = crc32(0, &crcnode, sizeof(crcnode)-4);
 
        if (je32_to_cpu(summary->hdr_crc) != crc) {
-               JFFS2_DBG_SUMMARY("Summary node header is corrupt (bad CRC or "
+               dbg_summary("Summary node header is corrupt (bad CRC or "
                                "no summary at all)\n");
                goto crc_err;
        }
 
        if (je32_to_cpu(summary->totlen) != sumsize) {
-               JFFS2_DBG_SUMMARY("Summary node is corrupt (wrong erasesize?)\n");
+               dbg_summary("Summary node is corrupt (wrong erasesize?)\n");
                goto crc_err;
        }
 
-       crc = crc32(0, summary, sizeof(struct jffs2_summary_node)-8);
+       crc = crc32(0, summary, sizeof(struct jffs2_raw_summary)-8);
 
        if (je32_to_cpu(summary->node_crc) != crc) {
-               JFFS2_DBG_SUMMARY("Summary node is corrupt (bad CRC)\n");
+               dbg_summary("Summary node is corrupt (bad CRC)\n");
                goto crc_err;
        }
 
-       crc = crc32(0, summary->sum, sumsize - sizeof(struct jffs2_summary_node));
+       crc = crc32(0, summary->sum, sumsize - sizeof(struct jffs2_raw_summary));
 
        if (je32_to_cpu(summary->sum_crc) != crc) {
-               JFFS2_DBG_SUMMARY("Summary node data is corrupt (bad CRC)\n");
+               dbg_summary("Summary node data is corrupt (bad CRC)\n");
                goto crc_err;
        }
 
        if ( je32_to_cpu(summary->cln_mkr) ) {
 
-               JFFS2_DBG_SUMMARY("Summary : CLEANMARKER node \n");
+               dbg_summary("Summary : CLEANMARKER node \n");
 
                if (je32_to_cpu(summary->cln_mkr) != c->cleanmarker_size) {
-                       JFFS2_DBG_SUMMARY("CLEANMARKER node has totlen 0x%x != normal 0x%x\n",
+                       dbg_summary("CLEANMARKER node has totlen 0x%x != normal 0x%x\n",
                                je32_to_cpu(summary->cln_mkr), c->cleanmarker_size);
-                       UNCHECKED_SPACE(PAD(je32_to_cpu(summary->cln_mkr)));
+                       DIRTY_SPACE(PAD(je32_to_cpu(summary->cln_mkr)));
                } else if (jeb->first_node) {
-                       JFFS2_DBG_SUMMARY("CLEANMARKER node not first node in block "
+                       dbg_summary("CLEANMARKER node not first node in block "
                                        "(0x%08x)\n", jeb->offset);
-                       UNCHECKED_SPACE(PAD(je32_to_cpu(summary->cln_mkr)));
+                       DIRTY_SPACE(PAD(je32_to_cpu(summary->cln_mkr)));
                } else {
                        struct jffs2_raw_node_ref *marker_ref = jffs2_alloc_raw_node_ref();
 
                        if (!marker_ref) {
                                JFFS2_NOTICE("Failed to allocate node ref for clean marker\n");
-                               kfree(summary);
                                return -ENOMEM;
                        }
 
-                       marker_ref->next_in_ino = NULL;
-                       marker_ref->next_phys = NULL;
                        marker_ref->flash_offset = jeb->offset | REF_NORMAL;
-                       marker_ref->__totlen = je32_to_cpu(summary->cln_mkr);
-                       jeb->first_node = jeb->last_node = marker_ref;
+                       marker_ref->next_in_ino = NULL;
 
-                       USED_SPACE( PAD(je32_to_cpu(summary->cln_mkr)) );
+                       jffs2_link_node_ref(c, jeb, marker_ref, je32_to_cpu(summary->cln_mkr));
                }
        }
 
@@ -531,15 +656,8 @@ int jffs2_sum_scan_sumnode(struct jffs2_sb_info *c, struct jffs2_eraseblock *jeb
        cache_ref->next_in_ino = NULL;
        cache_ref->next_phys = NULL;
        cache_ref->flash_offset = ofs | REF_NORMAL;
-       cache_ref->__totlen = sumsize;
-
-       if (!jeb->first_node)
-               jeb->first_node = cache_ref;
-       if (jeb->last_node)
-               jeb->last_node->next_phys = cache_ref;
-       jeb->last_node = cache_ref;
 
-       USED_SPACE(sumsize);
+       jffs2_link_node_ref(c, jeb, cache_ref, sumsize);
 
        jeb->wasted_size += jeb->free_size;
        c->wasted_size += jeb->free_size;
@@ -559,7 +677,7 @@ crc_err:
 static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock *jeb,
                                        uint32_t infosize, uint32_t datasize, int padsize)
 {
-       struct jffs2_summary_node isum;
+       struct jffs2_raw_summary isum;
        union jffs2_sum_mem *temp;
        struct jffs2_sum_marker *sm;
        struct kvec vecs[2];
@@ -580,16 +698,17 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
        wpage = c->summary->sum_buf;
 
        while (c->summary->sum_num) {
+               temp = c->summary->sum_list_head;
 
-               switch (je16_to_cpu(c->summary->sum_list_head->u.nodetype)) {
+               switch (je16_to_cpu(temp->u.nodetype)) {
                        case JFFS2_NODETYPE_INODE: {
                                struct jffs2_sum_inode_flash *sino_ptr = wpage;
 
-                               sino_ptr->nodetype = c->summary->sum_list_head->i.nodetype;
-                               sino_ptr->inode = c->summary->sum_list_head->i.inode;
-                               sino_ptr->version = c->summary->sum_list_head->i.version;
-                               sino_ptr->offset = c->summary->sum_list_head->i.offset;
-                               sino_ptr->totlen = c->summary->sum_list_head->i.totlen;
+                               sino_ptr->nodetype = temp->i.nodetype;
+                               sino_ptr->inode = temp->i.inode;
+                               sino_ptr->version = temp->i.version;
+                               sino_ptr->offset = temp->i.offset;
+                               sino_ptr->totlen = temp->i.totlen;
 
                                wpage += JFFS2_SUMMARY_INODE_SIZE;
 
@@ -599,30 +718,60 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
                        case JFFS2_NODETYPE_DIRENT: {
                                struct jffs2_sum_dirent_flash *sdrnt_ptr = wpage;
 
-                               sdrnt_ptr->nodetype = c->summary->sum_list_head->d.nodetype;
-                               sdrnt_ptr->totlen = c->summary->sum_list_head->d.totlen;
-                               sdrnt_ptr->offset = c->summary->sum_list_head->d.offset;
-                               sdrnt_ptr->pino = c->summary->sum_list_head->d.pino;
-                               sdrnt_ptr->version = c->summary->sum_list_head->d.version;
-                               sdrnt_ptr->ino = c->summary->sum_list_head->d.ino;
-                               sdrnt_ptr->nsize = c->summary->sum_list_head->d.nsize;
-                               sdrnt_ptr->type = c->summary->sum_list_head->d.type;
+                               sdrnt_ptr->nodetype = temp->d.nodetype;
+                               sdrnt_ptr->totlen = temp->d.totlen;
+                               sdrnt_ptr->offset = temp->d.offset;
+                               sdrnt_ptr->pino = temp->d.pino;
+                               sdrnt_ptr->version = temp->d.version;
+                               sdrnt_ptr->ino = temp->d.ino;
+                               sdrnt_ptr->nsize = temp->d.nsize;
+                               sdrnt_ptr->type = temp->d.type;
 
-                               memcpy(sdrnt_ptr->name, c->summary->sum_list_head->d.name, 
-                                                       c->summary->sum_list_head->d.nsize);
+                               memcpy(sdrnt_ptr->name, temp->d.name,
+                                                       temp->d.nsize);
 
-                               wpage += JFFS2_SUMMARY_DIRENT_SIZE(c->summary->sum_list_head->d.nsize);
+                               wpage += JFFS2_SUMMARY_DIRENT_SIZE(temp->d.nsize);
 
                                break;
                        }
+#ifdef CONFIG_JFFS2_FS_XATTR
+                       case JFFS2_NODETYPE_XATTR: {
+                               struct jffs2_sum_xattr_flash *sxattr_ptr = wpage;
+
+                               temp = c->summary->sum_list_head;
+                               sxattr_ptr->nodetype = temp->x.nodetype;
+                               sxattr_ptr->xid = temp->x.xid;
+                               sxattr_ptr->version = temp->x.version;
+                               sxattr_ptr->offset = temp->x.offset;
+                               sxattr_ptr->totlen = temp->x.totlen;
+
+                               wpage += JFFS2_SUMMARY_XATTR_SIZE;
+                               break;
+                       }
+                       case JFFS2_NODETYPE_XREF: {
+                               struct jffs2_sum_xref_flash *sxref_ptr = wpage;
 
+                               temp = c->summary->sum_list_head;
+                               sxref_ptr->nodetype = temp->r.nodetype;
+                               sxref_ptr->offset = temp->r.offset;
+
+                               wpage += JFFS2_SUMMARY_XREF_SIZE;
+                               break;
+                       }
+#endif
                        default : {
-                               BUG();  /* unknown node in summary information */
+                               if ((je16_to_cpu(temp->u.nodetype) & JFFS2_COMPAT_MASK)
+                                   == JFFS2_FEATURE_RWCOMPAT_COPY) {
+                                       dbg_summary("Writing unknown RWCOMPAT_COPY node type %x\n",
+                                                   je16_to_cpu(temp->u.nodetype));
+                                       jffs2_sum_disable_collecting(c->summary);
+                               } else {
+                                       BUG();  /* unknown node in summary information */
+                               }
                        }
                }
 
-               temp = c->summary->sum_list_head;
-               c->summary->sum_list_head = c->summary->sum_list_head->u.next;
+               c->summary->sum_list_head = temp->u.next;
                kfree(temp);
 
                c->summary->sum_num--;
@@ -644,7 +793,7 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
        vecs[1].iov_base = c->summary->sum_buf;
        vecs[1].iov_len = datasize;
 
-       JFFS2_DBG_SUMMARY("JFFS2: writing out data to flash to pos : 0x%08x\n",
+       dbg_summary("JFFS2: writing out data to flash to pos : 0x%08x\n",
                        jeb->offset + c->sector_size - jeb->free_size);
 
        spin_unlock(&c->erase_completion_lock);
@@ -654,11 +803,11 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
 
 
        if (ret || (retlen != infosize)) {
-               JFFS2_WARNING("Write of %zd bytes at 0x%08x failed. returned %d, retlen %zd\n",
+               JFFS2_WARNING("Write of %u bytes at 0x%08x failed. returned %d, retlen %zd\n",
                        infosize, jeb->offset + c->sector_size - jeb->free_size, ret, retlen);
 
                c->summary->sum_size = JFFS2_SUMMARY_NOSUM_SIZE;
-               WASTED_SPACE(infosize);
+               DIRTY_SPACE(infosize);
 
                return 1;
        }
@@ -674,7 +823,7 @@ int jffs2_sum_write_sumnode(struct jffs2_sb_info *c)
        int datasize, infosize, padsize, ret;
        struct jffs2_eraseblock *jeb;
 
-       JFFS2_DBG_SUMMARY("called\n");
+       dbg_summary("called\n");
 
        jeb = c->nextblock;
 
@@ -684,9 +833,9 @@ int jffs2_sum_write_sumnode(struct jffs2_sb_info *c)
        }
 
        datasize = c->summary->sum_size + sizeof(struct jffs2_sum_marker);
-       infosize = sizeof(struct jffs2_summary_node) + datasize;
+       infosize = sizeof(struct jffs2_raw_summary) + datasize;
        padsize = jeb->free_size - infosize;
-       infosize += padsize; 
+       infosize += padsize;
        datasize += padsize;
 
        /* Is there enough space for summary? */
@@ -713,17 +862,9 @@ int jffs2_sum_write_sumnode(struct jffs2_sb_info *c)
        }
 
        summary_ref->next_in_ino = NULL;
-       summary_ref->next_phys = NULL;
        summary_ref->flash_offset = (jeb->offset + c->sector_size - jeb->free_size) | REF_NORMAL;
-       summary_ref->__totlen = infosize;
-
-       if (!jeb->first_node)
-               jeb->first_node = summary_ref;
-       if (jeb->last_node)
-               jeb->last_node->next_phys = summary_ref;
-       jeb->last_node = summary_ref;
 
-       USED_SPACE(infosize);
+       jffs2_link_node_ref(c, jeb, summary_ref, infosize);
 
        return 0;
 }