[GFS2] panic after can't parse mount arguments

[linux-2.6] / fs / block_dev.c

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 75c47a21b2f0507968cbcf0921fc918906fe3e68..2980eabe577981c0852a9286eea9be4474143687 100644 (file)
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -517,7 +517,7 @@ void __init bdev_cache_init(void)
        bdev_cachep = kmem_cache_create("bdev_cache", sizeof(struct bdev_inode),
                        0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
                                SLAB_MEM_SPREAD|SLAB_PANIC),
-                       init_once, NULL);
+                       init_once);
        err = register_filesystem(&bd_type);
        if (err)
                panic("Cannot register bdev pseudo-fs");
@@ -963,20 +963,20 @@ static int bd_claim_by_kobject(struct block_device *bdev, void *holder,
 
        err = bd_claim(bdev, holder);
        if (err)
-               goto out;
+               goto fail;
 
        found = find_bd_holder(bdev, bo);
        if (found)
-               goto out;
+               goto fail;
 
        err = add_bd_holder(bdev, bo);
        if (err)
                bd_release(bdev);
-
-out:
-       if (err || found)
-               free_bd_holder(bo);
+       else
+               bo = NULL;
+fail:
        mutex_unlock(&bdev->bd_mutex);
+       free_bd_holder(bo);
        return err;
 }
 
@@ -991,15 +991,12 @@ out:
 static void bd_release_from_kobject(struct block_device *bdev,
                                        struct kobject *kobj)
 {
-       struct bd_holder *bo;
-
        if (!kobj)
                return;
 
        mutex_lock(&bdev->bd_mutex);
        bd_release(bdev);
-       if ((bo = del_bd_holder(bdev, kobj)))
-               free_bd_holder(bo);
+       free_bd_holder(del_bd_holder(bdev, kobj));
        mutex_unlock(&bdev->bd_mutex);
 }