]> err.no Git - linux-2.6/blobdiff - drivers/usb/serial/ti_usb_3410_5052.c
Merge branch 'release' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux-2.6
[linux-2.6] / drivers / usb / serial / ti_usb_3410_5052.c
index b517f93352ec414d8ee52258b5965868ea2fb5f2..e39c779e416099ea0a94a28d622851abaf71f13a 100644 (file)
@@ -16,7 +16,7 @@
  * For questions or problems with this driver, contact Texas Instruments
  * technical support, or Al Borchers <alborchers@steinerpoint.com>, or
  * Peter Berger <pberger@brimson.com>.
- * 
+ *
  * This driver needs this hotplug script in /etc/hotplug/usb/ti_usb_3410_5052
  * or in /etc/hotplug.d/usb/ti_usb_3410_5052.hotplug to set the device
  * configuration.
@@ -70,6 +70,7 @@
 
 #include <linux/kernel.h>
 #include <linux/errno.h>
+#include <linux/firmware.h>
 #include <linux/init.h>
 #include <linux/slab.h>
 #include <linux/tty.h>
 #include <linux/serial.h>
 #include <linux/circ_buf.h>
 #include <linux/mutex.h>
-#include <asm/uaccess.h>
-#include <asm/semaphore.h>
+#include <linux/uaccess.h>
 #include <linux/usb.h>
 #include <linux/usb/serial.h>
+#include <linux/firmware.h>
 
 #include "ti_usb_3410_5052.h"
-#include "ti_fw_3410.h"                /* firmware image for 3410 */
-#include "ti_fw_5052.h"                /* firmware image for 5052 */
-
 
 /* Defines */
 
@@ -152,21 +150,24 @@ struct ti_device {
 
 static int ti_startup(struct usb_serial *serial);
 static void ti_shutdown(struct usb_serial *serial);
-static int ti_open(struct usb_serial_port *port, struct file *file);
-static void ti_close(struct usb_serial_port *port, struct file *file);
-static int ti_write(struct usb_serial_port *port, const unsigned char *data,
-       int count);
-static int ti_write_room(struct usb_serial_port *port);
-static int ti_chars_in_buffer(struct usb_serial_port *port);
-static void ti_throttle(struct usb_serial_port *port);
-static void ti_unthrottle(struct usb_serial_port *port);
-static int ti_ioctl(struct usb_serial_port *port, struct file *file, unsigned int cmd, unsigned long arg);
-static void ti_set_termios(struct usb_serial_port *port,
-       struct ktermios *old_termios);
-static int ti_tiocmget(struct usb_serial_port *port, struct file *file);
-static int ti_tiocmset(struct usb_serial_port *port, struct file *file,
-       unsigned int set, unsigned int clear);
-static void ti_break(struct usb_serial_port *port, int break_state);
+static int ti_open(struct tty_struct *tty, struct usb_serial_port *port,
+               struct file *file);
+static void ti_close(struct tty_struct *tty, struct usb_serial_port *port,
+               struct file *file);
+static int ti_write(struct tty_struct *tty, struct usb_serial_port *port,
+               const unsigned char *data, int count);
+static int ti_write_room(struct tty_struct *tty);
+static int ti_chars_in_buffer(struct tty_struct *tty);
+static void ti_throttle(struct tty_struct *tty);
+static void ti_unthrottle(struct tty_struct *tty);
+static int ti_ioctl(struct tty_struct *tty, struct file *file,
+               unsigned int cmd, unsigned long arg);
+static void ti_set_termios(struct tty_struct *tty,
+               struct usb_serial_port *port, struct ktermios *old_termios);
+static int ti_tiocmget(struct tty_struct *tty, struct file *file);
+static int ti_tiocmset(struct tty_struct *tty, struct file *file,
+               unsigned int set, unsigned int clear);
+static void ti_break(struct tty_struct *tty, int break_state);
 static void ti_interrupt_callback(struct urb *urb);
 static void ti_bulk_in_callback(struct urb *urb);
 static void ti_bulk_out_callback(struct urb *urb);
@@ -195,8 +196,7 @@ static int ti_command_in_sync(struct ti_device *tdev, __u8 command,
 static int ti_write_byte(struct ti_device *tdev, unsigned long addr,
        __u8 mask, __u8 byte);
 
-static int ti_download_firmware(struct ti_device *tdev,
-       unsigned char *firmware, unsigned int firmware_size);
+static int ti_download_firmware(struct ti_device *tdev, int type);
 
 /* circular buffer */
 static struct circ_buf *ti_buf_alloc(void);
@@ -265,9 +265,6 @@ static struct usb_serial_driver ti_1port_device = {
        .description            = "TI USB 3410 1 port adapter",
        .usb_driver             = &ti_usb_driver,
        .id_table               = ti_id_table_3410,
-       .num_interrupt_in       = 1,
-       .num_bulk_in            = 1,
-       .num_bulk_out           = 1,
        .num_ports              = 1,
        .attach                 = ti_startup,
        .shutdown               = ti_shutdown,
@@ -296,9 +293,6 @@ static struct usb_serial_driver ti_2port_device = {
        .description            = "TI USB 5052 2 port adapter",
        .usb_driver             = &ti_usb_driver,
        .id_table               = ti_id_table_5052,
-       .num_interrupt_in       = 1,
-       .num_bulk_in            = 2,
-       .num_bulk_out           = 2,
        .num_ports              = 2,
        .attach                 = ti_startup,
        .shutdown               = ti_shutdown,
@@ -327,23 +321,32 @@ MODULE_DESCRIPTION(TI_DRIVER_DESC);
 MODULE_VERSION(TI_DRIVER_VERSION);
 MODULE_LICENSE("GPL");
 
+MODULE_FIRMWARE("ti_3410.fw");
+MODULE_FIRMWARE("ti_5052.fw");
+
 module_param(debug, bool, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(debug, "Enable debugging, 0=no, 1=yes");
 
 module_param(low_latency, bool, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(low_latency, "TTY low_latency flag, 0=off, 1=on, default is off");
+MODULE_PARM_DESC(low_latency,
+               "TTY low_latency flag, 0=off, 1=on, default is off");
 
 module_param(closing_wait, int, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(closing_wait, "Maximum wait for data to drain in close, in .01 secs, default is 4000");
+MODULE_PARM_DESC(closing_wait,
+    "Maximum wait for data to drain in close, in .01 secs, default is 4000");
 
 module_param_array(vendor_3410, ushort, &vendor_3410_count, S_IRUGO);
-MODULE_PARM_DESC(vendor_3410, "Vendor ids for 3410 based devices, 1-5 short integers");
+MODULE_PARM_DESC(vendor_3410,
+               "Vendor ids for 3410 based devices, 1-5 short integers");
 module_param_array(product_3410, ushort, &product_3410_count, S_IRUGO);
-MODULE_PARM_DESC(product_3410, "Product ids for 3410 based devices, 1-5 short integers");
+MODULE_PARM_DESC(product_3410,
+               "Product ids for 3410 based devices, 1-5 short integers");
 module_param_array(vendor_5052, ushort, &vendor_5052_count, S_IRUGO);
-MODULE_PARM_DESC(vendor_5052, "Vendor ids for 5052 based devices, 1-5 short integers");
+MODULE_PARM_DESC(vendor_5052,
+               "Vendor ids for 5052 based devices, 1-5 short integers");
 module_param_array(product_5052, ushort, &product_5052_count, S_IRUGO);
-MODULE_PARM_DESC(product_5052, "Product ids for 5052 based devices, 1-5 short integers");
+MODULE_PARM_DESC(product_5052,
+               "Product ids for 5052 based devices, 1-5 short integers");
 
 MODULE_DEVICE_TABLE(usb, ti_id_table_combined);
 
@@ -352,18 +355,18 @@ MODULE_DEVICE_TABLE(usb, ti_id_table_combined);
 
 static int __init ti_init(void)
 {
-       int i,j;
+       int i, j;
        int ret;
 
        /* insert extra vendor and product ids */
        j = ARRAY_SIZE(ti_id_table_3410) - TI_EXTRA_VID_PID_COUNT - 1;
-       for (i=0; i<min(vendor_3410_count,product_3410_count); i++,j++) {
+       for (i = 0; i < min(vendor_3410_count, product_3410_count); i++, j++) {
                ti_id_table_3410[j].idVendor = vendor_3410[i];
                ti_id_table_3410[j].idProduct = product_3410[i];
                ti_id_table_3410[j].match_flags = USB_DEVICE_ID_MATCH_DEVICE;
        }
        j = ARRAY_SIZE(ti_id_table_5052) - TI_EXTRA_VID_PID_COUNT - 1;
-       for (i=0; i<min(vendor_5052_count,product_5052_count); i++,j++) {
+       for (i = 0; i < min(vendor_5052_count, product_5052_count); i++, j++) {
                ti_id_table_5052[j].idVendor = vendor_5052[i];
                ti_id_table_5052[j].idProduct = product_5052[i];
                ti_id_table_5052[j].match_flags = USB_DEVICE_ID_MATCH_DEVICE;
@@ -415,14 +418,14 @@ static int ti_startup(struct usb_serial *serial)
 
 
        dbg("%s - product 0x%4X, num configurations %d, configuration value %d",
-           __FUNCTION__, le16_to_cpu(dev->descriptor.idProduct),
+           __func__, le16_to_cpu(dev->descriptor.idProduct),
            dev->descriptor.bNumConfigurations,
            dev->actconfig->desc.bConfigurationValue);
 
        /* create device structure */
        tdev = kzalloc(sizeof(struct ti_device), GFP_KERNEL);
        if (tdev == NULL) {
-               dev_err(&dev->dev, "%s - out of memory\n", __FUNCTION__);
+               dev_err(&dev->dev, "%s - out of memory\n", __func__);
                return -ENOMEM;
        }
        mutex_init(&tdev->td_open_close_lock);
@@ -432,17 +435,15 @@ static int ti_startup(struct usb_serial *serial)
        /* determine device type */
        if (usb_match_id(serial->interface, ti_id_table_3410))
                tdev->td_is_3410 = 1;
-       dbg("%s - device type is %s", __FUNCTION__, tdev->td_is_3410 ? "3410" : "5052");
+       dbg("%s - device type is %s", __func__,
+                               tdev->td_is_3410 ? "3410" : "5052");
 
        /* if we have only 1 configuration, download firmware */
        if (dev->descriptor.bNumConfigurations == 1) {
-
                if (tdev->td_is_3410)
-                       status = ti_download_firmware(tdev, ti_fw_3410,
-                               sizeof(ti_fw_3410));
+                       status = ti_download_firmware(tdev, 3410);
                else
-                       status = ti_download_firmware(tdev, ti_fw_5052,
-                               sizeof(ti_fw_5052));
+                       status = ti_download_firmware(tdev, 5052);
                if (status)
                        goto free_tdev;
 
@@ -454,7 +455,7 @@ static int ti_startup(struct usb_serial *serial)
 
                status = -ENODEV;
                goto free_tdev;
-       } 
+       }
 
        /* the second configuration must be set (in sysfs by hotplug script) */
        if (dev->actconfig->desc.bConfigurationValue == TI_BOOT_CONFIG) {
@@ -466,19 +467,20 @@ static int ti_startup(struct usb_serial *serial)
        for (i = 0; i < serial->num_ports; ++i) {
                tport = kzalloc(sizeof(struct ti_port), GFP_KERNEL);
                if (tport == NULL) {
-                       dev_err(&dev->dev, "%s - out of memory\n", __FUNCTION__);
+                       dev_err(&dev->dev, "%s - out of memory\n", __func__);
                        status = -ENOMEM;
                        goto free_tports;
                }
                spin_lock_init(&tport->tp_lock);
-               tport->tp_uart_base_addr = (i == 0 ? TI_UART1_BASE_ADDR : TI_UART2_BASE_ADDR);
+               tport->tp_uart_base_addr = (i == 0 ?
+                               TI_UART1_BASE_ADDR : TI_UART2_BASE_ADDR);
                tport->tp_flags = low_latency ? ASYNC_LOW_LATENCY : 0;
                tport->tp_closing_wait = closing_wait;
                init_waitqueue_head(&tport->tp_msr_wait);
                init_waitqueue_head(&tport->tp_write_wait);
                tport->tp_write_buf = ti_buf_alloc();
                if (tport->tp_write_buf == NULL) {
-                       dev_err(&dev->dev, "%s - out of memory\n", __FUNCTION__);
+                       dev_err(&dev->dev, "%s - out of memory\n", __func__);
                        kfree(tport);
                        status = -ENOMEM;
                        goto free_tports;
@@ -488,11 +490,11 @@ static int ti_startup(struct usb_serial *serial)
                usb_set_serial_port_data(serial->port[i], tport);
                tport->tp_uart_mode = 0;        /* default is RS232 */
        }
-       
+
        return 0;
 
 free_tports:
-       for (--i; i>=0; --i) {
+       for (--i; i >= 0; --i) {
                tport = usb_get_serial_port_data(serial->port[i]);
                ti_buf_free(tport->tp_write_buf);
                kfree(tport);
@@ -511,9 +513,9 @@ static void ti_shutdown(struct usb_serial *serial)
        struct ti_device *tdev = usb_get_serial_data(serial);
        struct ti_port *tport;
 
-       dbg("%s", __FUNCTION__);
+       dbg("%s", __func__);
 
-       for (i=0; i < serial->num_ports; ++i) {
+       for (i = 0; i < serial->num_ports; ++i) {
                tport = usb_get_serial_port_data(serial->port[i]);
                if (tport) {
                        ti_buf_free(tport->tp_write_buf);
@@ -527,7 +529,8 @@ static void ti_shutdown(struct usb_serial *serial)
 }
 
 
-static int ti_open(struct usb_serial_port *port, struct file *file)
+static int ti_open(struct tty_struct *tty,
+                       struct usb_serial_port *port, struct file *file)
 {
        struct ti_port *tport = usb_get_serial_port_data(port);
        struct ti_device *tdev;
@@ -535,11 +538,11 @@ static int ti_open(struct usb_serial_port *port, struct file *file)
        struct urb *urb;
        int port_number;
        int status;
-       __u16 open_settings = (__u8)(TI_PIPE_MODE_CONTINOUS | 
-                            TI_PIPE_TIMEOUT_ENABLE | 
+       __u16 open_settings = (__u8)(TI_PIPE_MODE_CONTINOUS |
+                            TI_PIPE_TIMEOUT_ENABLE |
                             (TI_TRANSFER_TIMEOUT << 2));
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        if (tport == NULL)
                return -ENODEV;
@@ -551,9 +554,9 @@ static int ti_open(struct usb_serial_port *port, struct file *file)
        if (mutex_lock_interruptible(&tdev->td_open_close_lock))
                return -ERESTARTSYS;
 
-       if (port->tty)
-               port->tty->low_latency = 
-                       (tport->tp_flags & ASYNC_LOW_LATENCY) ? 1 : 0;
+       if (tty)
+               tty->low_latency =
+                               (tport->tp_flags & ASYNC_LOW_LATENCY) ? 1 : 0;
 
        port_number = port->number - port->serial->minor;
 
@@ -564,10 +567,11 @@ static int ti_open(struct usb_serial_port *port, struct file *file)
 
        /* start interrupt urb the first time a port is opened on this device */
        if (tdev->td_open_port_count == 0) {
-               dbg("%s - start interrupt in urb", __FUNCTION__);
+               dbg("%s - start interrupt in urb", __func__);
                urb = tdev->td_serial->port[0]->interrupt_in_urb;
                if (!urb) {
-                       dev_err(&port->dev, "%s - no interrupt urb\n", __FUNCTION__);
+                       dev_err(&port->dev, "%s - no interrupt urb\n",
+                                                               __func__);
                        status = -EINVAL;
                        goto release_lock;
                }
@@ -576,40 +580,47 @@ static int ti_open(struct usb_serial_port *port, struct file *file)
                urb->dev = dev;
                status = usb_submit_urb(urb, GFP_KERNEL);
                if (status) {
-                       dev_err(&port->dev, "%s - submit interrupt urb failed, %d\n", __FUNCTION__, status);
+                       dev_err(&port->dev,
+                               "%s - submit interrupt urb failed, %d\n",
+                                       __func__, status);
                        goto release_lock;
                }
        }
 
-       ti_set_termios(port, port->tty->termios);
+       if (tty)
+               ti_set_termios(tty, port, tty->termios);
 
-       dbg("%s - sending TI_OPEN_PORT", __FUNCTION__);
+       dbg("%s - sending TI_OPEN_PORT", __func__);
        status = ti_command_out_sync(tdev, TI_OPEN_PORT,
                (__u8)(TI_UART1_PORT + port_number), open_settings, NULL, 0);
        if (status) {
-               dev_err(&port->dev, "%s - cannot send open command, %d\n", __FUNCTION__, status);
+               dev_err(&port->dev, "%s - cannot send open command, %d\n",
+                                                       __func__, status);
                goto unlink_int_urb;
        }
 
-       dbg("%s - sending TI_START_PORT", __FUNCTION__);
+       dbg("%s - sending TI_START_PORT", __func__);
        status = ti_command_out_sync(tdev, TI_START_PORT,
                (__u8)(TI_UART1_PORT + port_number), 0, NULL, 0);
        if (status) {
-               dev_err(&port->dev, "%s - cannot send start command, %d\n", __FUNCTION__, status);
+               dev_err(&port->dev, "%s - cannot send start command, %d\n",
+                                                       __func__, status);
                goto unlink_int_urb;
        }
 
-       dbg("%s - sending TI_PURGE_PORT", __FUNCTION__);
+       dbg("%s - sending TI_PURGE_PORT", __func__);
        status = ti_command_out_sync(tdev, TI_PURGE_PORT,
                (__u8)(TI_UART1_PORT + port_number), TI_PURGE_INPUT, NULL, 0);
        if (status) {
-               dev_err(&port->dev, "%s - cannot clear input buffers, %d\n", __FUNCTION__, status);
+               dev_err(&port->dev, "%s - cannot clear input buffers, %d\n",
+                                                       __func__, status);
                goto unlink_int_urb;
        }
        status = ti_command_out_sync(tdev, TI_PURGE_PORT,
                (__u8)(TI_UART1_PORT + port_number), TI_PURGE_OUTPUT, NULL, 0);
        if (status) {
-               dev_err(&port->dev, "%s - cannot clear output buffers, %d\n", __FUNCTION__, status);
+               dev_err(&port->dev, "%s - cannot clear output buffers, %d\n",
+                                                       __func__, status);
                goto unlink_int_urb;
        }
 
@@ -618,29 +629,32 @@ static int ti_open(struct usb_serial_port *port, struct file *file)
        usb_clear_halt(dev, port->write_urb->pipe);
        usb_clear_halt(dev, port->read_urb->pipe);
 
-       ti_set_termios(port, port->tty->termios);
+       if (tty)
+               ti_set_termios(tty, port, tty->termios);
 
-       dbg("%s - sending TI_OPEN_PORT (2)", __FUNCTION__);
+       dbg("%s - sending TI_OPEN_PORT (2)", __func__);
        status = ti_command_out_sync(tdev, TI_OPEN_PORT,
                (__u8)(TI_UART1_PORT + port_number), open_settings, NULL, 0);
        if (status) {
-               dev_err(&port->dev, "%s - cannot send open command (2), %d\n", __FUNCTION__, status);
+               dev_err(&port->dev, "%s - cannot send open command (2), %d\n",
+                                                       __func__, status);
                goto unlink_int_urb;
        }
 
-       dbg("%s - sending TI_START_PORT (2)", __FUNCTION__);
+       dbg("%s - sending TI_START_PORT (2)", __func__);
        status = ti_command_out_sync(tdev, TI_START_PORT,
                (__u8)(TI_UART1_PORT + port_number), 0, NULL, 0);
        if (status) {
-               dev_err(&port->dev, "%s - cannot send start command (2), %d\n", __FUNCTION__, status);
+               dev_err(&port->dev, "%s - cannot send start command (2), %d\n",
+                                                       __func__, status);
                goto unlink_int_urb;
        }
 
        /* start read urb */
-       dbg("%s - start read urb", __FUNCTION__);
+       dbg("%s - start read urb", __func__);
        urb = port->read_urb;
        if (!urb) {
-               dev_err(&port->dev, "%s - no read urb\n", __FUNCTION__);
+               dev_err(&port->dev, "%s - no read urb\n", __func__);
                status = -EINVAL;
                goto unlink_int_urb;
        }
@@ -650,7 +664,8 @@ static int ti_open(struct usb_serial_port *port, struct file *file)
        urb->dev = dev;
        status = usb_submit_urb(urb, GFP_KERNEL);
        if (status) {
-               dev_err(&port->dev, "%s - submit read urb failed, %d\n", __FUNCTION__, status);
+               dev_err(&port->dev, "%s - submit read urb failed, %d\n",
+                                                       __func__, status);
                goto unlink_int_urb;
        }
 
@@ -664,12 +679,13 @@ unlink_int_urb:
                usb_kill_urb(port->serial->port[0]->interrupt_in_urb);
 release_lock:
        mutex_unlock(&tdev->td_open_close_lock);
-       dbg("%s - exit %d", __FUNCTION__, status);
+       dbg("%s - exit %d", __func__, status);
        return status;
 }
 
 
-static void ti_close(struct usb_serial_port *port, struct file *file)
+static void ti_close(struct tty_struct *tty, struct usb_serial_port *port,
+                                                       struct file *file)
 {
        struct ti_device *tdev;
        struct ti_port *tport;
@@ -677,8 +693,8 @@ static void ti_close(struct usb_serial_port *port, struct file *file)
        int status;
        int do_unlock;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
-                        
+       dbg("%s - port %d", __func__, port->number);
+
        tdev = usb_get_serial_data(port->serial);
        tport = usb_get_serial_port_data(port);
        if (tdev == NULL || tport == NULL)
@@ -694,11 +710,13 @@ static void ti_close(struct usb_serial_port *port, struct file *file)
 
        port_number = port->number - port->serial->minor;
 
-       dbg("%s - sending TI_CLOSE_PORT", __FUNCTION__);
+       dbg("%s - sending TI_CLOSE_PORT", __func__);
        status = ti_command_out_sync(tdev, TI_CLOSE_PORT,
                     (__u8)(TI_UART1_PORT + port_number), 0, NULL, 0);
        if (status)
-               dev_err(&port->dev, "%s - cannot send close port command, %d\n" , __FUNCTION__, status);
+               dev_err(&port->dev,
+                       "%s - cannot send close port command, %d\n"
+                                                       , __func__, status);
 
        /* if mutex_lock is interrupted, continue anyway */
        do_unlock = !mutex_lock_interruptible(&tdev->td_open_close_lock);
@@ -711,20 +729,20 @@ static void ti_close(struct usb_serial_port *port, struct file *file)
        if (do_unlock)
                mutex_unlock(&tdev->td_open_close_lock);
 
-       dbg("%s - exit", __FUNCTION__);
+       dbg("%s - exit", __func__);
 }
 
 
-static int ti_write(struct usb_serial_port *port, const unsigned char *data,
-       int count)
+static int ti_write(struct tty_struct *tty, struct usb_serial_port *port,
+                       const unsigned char *data, int count)
 {
        struct ti_port *tport = usb_get_serial_port_data(port);
        unsigned long flags;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        if (count == 0) {
-               dbg("%s - write request of 0 bytes", __FUNCTION__);
+               dbg("%s - write request of 0 bytes", __func__);
                return 0;
        }
 
@@ -741,33 +759,35 @@ static int ti_write(struct usb_serial_port *port, const unsigned char *data,
 }
 
 
-static int ti_write_room(struct usb_serial_port *port)
+static int ti_write_room(struct tty_struct *tty)
 {
+       struct usb_serial_port *port = tty->driver_data;
        struct ti_port *tport = usb_get_serial_port_data(port);
        int room = 0;
        unsigned long flags;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        if (tport == NULL)
                return -ENODEV;
-       
+
        spin_lock_irqsave(&tport->tp_lock, flags);
        room = ti_buf_space_avail(tport->tp_write_buf);
        spin_unlock_irqrestore(&tport->tp_lock, flags);
 
-       dbg("%s - returns %d", __FUNCTION__, room);
+       dbg("%s - returns %d", __func__, room);
        return room;
 }
 
 
-static int ti_chars_in_buffer(struct usb_serial_port *port)
+static int ti_chars_in_buffer(struct tty_struct *tty)
 {
+       struct usb_serial_port *port = tty->driver_data;
        struct ti_port *tport = usb_get_serial_port_data(port);
        int chars = 0;
        unsigned long flags;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        if (tport == NULL)
                return -ENODEV;
@@ -776,139 +796,127 @@ static int ti_chars_in_buffer(struct usb_serial_port *port)
        chars = ti_buf_data_avail(tport->tp_write_buf);
        spin_unlock_irqrestore(&tport->tp_lock, flags);
 
-       dbg("%s - returns %d", __FUNCTION__, chars);
+       dbg("%s - returns %d", __func__, chars);
        return chars;
 }
 
 
-static void ti_throttle(struct usb_serial_port *port)
+static void ti_throttle(struct tty_struct *tty)
 {
+       struct usb_serial_port *port = tty->driver_data;
        struct ti_port *tport = usb_get_serial_port_data(port);
-       struct tty_struct *tty;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        if (tport == NULL)
                return;
 
-       tty = port->tty;
-       if (!tty) {
-               dbg("%s - no tty", __FUNCTION__);
-               return;
-       }
-
        if (I_IXOFF(tty) || C_CRTSCTS(tty))
                ti_stop_read(tport, tty);
 
 }
 
 
-static void ti_unthrottle(struct usb_serial_port *port)
+static void ti_unthrottle(struct tty_struct *tty)
 {
+       struct usb_serial_port *port = tty->driver_data;
        struct ti_port *tport = usb_get_serial_port_data(port);
-       struct tty_struct *tty;
        int status;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        if (tport == NULL)
                return;
 
-       tty = port->tty;
-       if (!tty) {
-               dbg("%s - no tty", __FUNCTION__);
-               return;
-       }
-
        if (I_IXOFF(tty) || C_CRTSCTS(tty)) {
                status = ti_restart_read(tport, tty);
                if (status)
-                       dev_err(&port->dev, "%s - cannot restart read, %d\n", __FUNCTION__, status);
+                       dev_err(&port->dev, "%s - cannot restart read, %d\n",
+                                                       __func__, status);
        }
 }
 
 
-static int ti_ioctl(struct usb_serial_port *port, struct file *file,
+static int ti_ioctl(struct tty_struct *tty, struct file *file,
        unsigned int cmd, unsigned long arg)
 {
+       struct usb_serial_port *port = tty->driver_data;
        struct ti_port *tport = usb_get_serial_port_data(port);
        struct async_icount cnow;
        struct async_icount cprev;
 
-       dbg("%s - port %d, cmd = 0x%04X", __FUNCTION__, port->number, cmd);
+       dbg("%s - port %d, cmd = 0x%04X", __func__, port->number, cmd);
 
        if (tport == NULL)
                return -ENODEV;
 
        switch (cmd) {
-               case TIOCGSERIAL:
-                       dbg("%s - (%d) TIOCGSERIAL", __FUNCTION__, port->number);
-                       return ti_get_serial_info(tport, (struct serial_struct __user *)arg);
-                       break;
-
-               case TIOCSSERIAL:
-                       dbg("%s - (%d) TIOCSSERIAL", __FUNCTION__, port->number);
-                       return ti_set_serial_info(tport, (struct serial_struct __user *)arg);
-                       break;
-
-               case TIOCMIWAIT:
-                       dbg("%s - (%d) TIOCMIWAIT", __FUNCTION__, port->number);
-                       cprev = tport->tp_icount;
-                       while (1) {
-                               interruptible_sleep_on(&tport->tp_msr_wait);
-                               if (signal_pending(current))
-                                       return -ERESTARTSYS;
-                               cnow = tport->tp_icount;
-                               if (cnow.rng == cprev.rng && cnow.dsr == cprev.dsr &&
-                                   cnow.dcd == cprev.dcd && cnow.cts == cprev.cts)
-                                       return -EIO; /* no change => error */
-                               if (((arg & TIOCM_RNG) && (cnow.rng != cprev.rng)) ||
-                                   ((arg & TIOCM_DSR) && (cnow.dsr != cprev.dsr)) ||
-                                   ((arg & TIOCM_CD)  && (cnow.dcd != cprev.dcd)) ||
-                                   ((arg & TIOCM_CTS) && (cnow.cts != cprev.cts)) ) {
-                                       return 0;
-                               }
-                               cprev = cnow;
-                       }
-                       break;
-
-               case TIOCGICOUNT:
-                       dbg("%s - (%d) TIOCGICOUNT RX=%d, TX=%d", __FUNCTION__, port->number, tport->tp_icount.rx, tport->tp_icount.tx);
-                       if (copy_to_user((void __user *)arg, &tport->tp_icount, sizeof(tport->tp_icount)))
-                               return -EFAULT;
-                       return 0;
+       case TIOCGSERIAL:
+               dbg("%s - (%d) TIOCGSERIAL", __func__, port->number);
+               return ti_get_serial_info(tport,
+                               (struct serial_struct __user *)arg);
+       case TIOCSSERIAL:
+               dbg("%s - (%d) TIOCSSERIAL", __func__, port->number);
+               return ti_set_serial_info(tport,
+                                       (struct serial_struct __user *)arg);
+       case TIOCMIWAIT:
+               dbg("%s - (%d) TIOCMIWAIT", __func__, port->number);
+               cprev = tport->tp_icount;
+               while (1) {
+                       interruptible_sleep_on(&tport->tp_msr_wait);
+                       if (signal_pending(current))
+                               return -ERESTARTSYS;
+                       cnow = tport->tp_icount;
+                       if (cnow.rng == cprev.rng && cnow.dsr == cprev.dsr &&
+                           cnow.dcd == cprev.dcd && cnow.cts == cprev.cts)
+                               return -EIO; /* no change => error */
+                       if (((arg & TIOCM_RNG) && (cnow.rng != cprev.rng)) ||
+                           ((arg & TIOCM_DSR) && (cnow.dsr != cprev.dsr)) ||
+                           ((arg & TIOCM_CD)  && (cnow.dcd != cprev.dcd)) ||
+                           ((arg & TIOCM_CTS) && (cnow.cts != cprev.cts)))
+                               return 0;
+                       cprev = cnow;
+               }
+               break;
+       case TIOCGICOUNT:
+               dbg("%s - (%d) TIOCGICOUNT RX=%d, TX=%d",
+                               __func__, port->number,
+                               tport->tp_icount.rx, tport->tp_icount.tx);
+               if (copy_to_user((void __user *)arg, &tport->tp_icount,
+                                       sizeof(tport->tp_icount)))
+                       return -EFAULT;
+               return 0;
        }
-
        return -ENOIOCTLCMD;
 }
 
 
-static void ti_set_termios(struct usb_serial_port *port,
-       struct ktermios *old_termios)
+static void ti_set_termios(struct tty_struct *tty,
+               struct usb_serial_port *port, struct ktermios *old_termios)
 {
        struct ti_port *tport = usb_get_serial_port_data(port);
-       struct tty_struct *tty = port->tty;
        struct ti_uart_config *config;
-       tcflag_t cflag,iflag;
+       tcflag_t cflag, iflag;
        int baud;
        int status;
        int port_number = port->number - port->serial->minor;
        unsigned int mcr;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        cflag = tty->termios->c_cflag;
        iflag = tty->termios->c_iflag;
 
-       dbg("%s - cflag %08x, iflag %08x", __FUNCTION__, cflag, iflag);
-       dbg("%s - old clfag %08x, old iflag %08x", __FUNCTION__, old_termios->c_cflag, old_termios->c_iflag);
+       dbg("%s - cflag %08x, iflag %08x", __func__, cflag, iflag);
+       dbg("%s - old clfag %08x, old iflag %08x", __func__,
+                               old_termios->c_cflag, old_termios->c_iflag);
 
        if (tport == NULL)
                return;
 
        config = kmalloc(sizeof(*config), GFP_KERNEL);
        if (!config) {
-               dev_err(&port->dev, "%s - out of memory\n", __FUNCTION__);
+               dev_err(&port->dev, "%s - out of memory\n", __func__);
                return;
        }
 
@@ -920,19 +928,19 @@ static void ti_set_termios(struct usb_serial_port *port,
        config->bUartMode = (__u8)(tport->tp_uart_mode);
 
        switch (cflag & CSIZE) {
-               case CS5:
-                           config->bDataBits = TI_UART_5_DATA_BITS;
-                           break;
-               case CS6:
-                           config->bDataBits = TI_UART_6_DATA_BITS;
-                           break;
-               case CS7:
-                           config->bDataBits = TI_UART_7_DATA_BITS;
-                           break;
-               default:
-               case CS8:
-                           config->bDataBits = TI_UART_8_DATA_BITS;
-                           break;
+       case CS5:
+                   config->bDataBits = TI_UART_5_DATA_BITS;
+                   break;
+       case CS6:
+                   config->bDataBits = TI_UART_6_DATA_BITS;
+                   break;
+       case CS7:
+                   config->bDataBits = TI_UART_7_DATA_BITS;
+                   break;
+       default:
+       case CS8:
+                   config->bDataBits = TI_UART_8_DATA_BITS;
+                   break;
        }
 
        /* CMSPAR isn't supported by this driver */
@@ -948,7 +956,7 @@ static void ti_set_termios(struct usb_serial_port *port,
                }
        } else {
                config->wFlags &= ~TI_UART_ENABLE_PARITY_CHECKING;
-               config->bParity = TI_UART_NO_PARITY;    
+               config->bParity = TI_UART_NO_PARITY;
        }
 
        if (cflag & CSTOPB)
@@ -992,7 +1000,7 @@ static void ti_set_termios(struct usb_serial_port *port,
                tty_encode_baud_rate(tty, baud, baud);
 
        dbg("%s - BaudRate=%d, wBaudRate=%d, wFlags=0x%04X, bDataBits=%d, bParity=%d, bStopBits=%d, cXon=%d, cXoff=%d, bUartMode=%d",
-       __FUNCTION__, baud, config->wBaudRate, config->wFlags, config->bDataBits, config->bParity, config->bStopBits, config->cXon, config->cXoff, config->bUartMode);
+       __func__, baud, config->wBaudRate, config->wFlags, config->bDataBits, config->bParity, config->bStopBits, config->cXon, config->cXoff, config->bUartMode);
 
        cpu_to_be16s(&config->wBaudRate);
        cpu_to_be16s(&config->wFlags);
@@ -1001,7 +1009,8 @@ static void ti_set_termios(struct usb_serial_port *port,
                (__u8)(TI_UART1_PORT + port_number), 0, (__u8 *)config,
                sizeof(*config));
        if (status)
-               dev_err(&port->dev, "%s - cannot set config on port %d, %d\n", __FUNCTION__, port_number, status);
+               dev_err(&port->dev, "%s - cannot set config on port %d, %d\n",
+                                       __func__, port_number, status);
 
        /* SET_CONFIG asserts RTS and DTR, reset them correctly */
        mcr = tport->tp_shadow_mcr;
@@ -1010,26 +1019,32 @@ static void ti_set_termios(struct usb_serial_port *port,
                mcr &= ~(TI_MCR_DTR | TI_MCR_RTS);
        status = ti_set_mcr(tport, mcr);
        if (status)
-               dev_err(&port->dev, "%s - cannot set modem control on port %d, %d\n", __FUNCTION__, port_number, status);
+               dev_err(&port->dev,
+                       "%s - cannot set modem control on port %d, %d\n",
+                                               __func__, port_number, status);
 
        kfree(config);
 }
 
 
-static int ti_tiocmget(struct usb_serial_port *port, struct file *file)
+static int ti_tiocmget(struct tty_struct *tty, struct file *file)
 {
+       struct usb_serial_port *port = tty->driver_data;
        struct ti_port *tport = usb_get_serial_port_data(port);
        unsigned int result;
        unsigned int msr;
        unsigned int mcr;
+       unsigned long flags;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        if (tport == NULL)
                return -ENODEV;
 
+       spin_lock_irqsave(&tport->tp_lock, flags);
        msr = tport->tp_msr;
        mcr = tport->tp_shadow_mcr;
+       spin_unlock_irqrestore(&tport->tp_lock, flags);
 
        result = ((mcr & TI_MCR_DTR) ? TIOCM_DTR : 0)
                | ((mcr & TI_MCR_RTS) ? TIOCM_RTS : 0)
@@ -1039,23 +1054,26 @@ static int ti_tiocmget(struct usb_serial_port *port, struct file *file)
                | ((msr & TI_MSR_RI) ? TIOCM_RI : 0)
                | ((msr & TI_MSR_DSR) ? TIOCM_DSR : 0);
 
-       dbg("%s - 0x%04X", __FUNCTION__, result);
+       dbg("%s - 0x%04X", __func__, result);
 
        return result;
 }
 
 
-static int ti_tiocmset(struct usb_serial_port *port, struct file *file,
+static int ti_tiocmset(struct tty_struct *tty, struct file *file,
        unsigned int set, unsigned int clear)
 {
+       struct usb_serial_port *port = tty->driver_data;
        struct ti_port *tport = usb_get_serial_port_data(port);
        unsigned int mcr;
+       unsigned long flags;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        if (tport == NULL)
                return -ENODEV;
 
+       spin_lock_irqsave(&tport->tp_lock, flags);
        mcr = tport->tp_shadow_mcr;
 
        if (set & TIOCM_RTS)
@@ -1071,17 +1089,19 @@ static int ti_tiocmset(struct usb_serial_port *port, struct file *file,
                mcr &= ~TI_MCR_DTR;
        if (clear & TIOCM_LOOP)
                mcr &= ~TI_MCR_LOOP;
+       spin_unlock_irqrestore(&tport->tp_lock, flags);
 
        return ti_set_mcr(tport, mcr);
 }
 
 
-static void ti_break(struct usb_serial_port *port, int break_state)
+static void ti_break(struct tty_struct *tty, int break_state)
 {
+       struct usb_serial_port *port = tty->driver_data;
        struct ti_port *tport = usb_get_serial_port_data(port);
        int status;
 
-       dbg("%s - state = %d", __FUNCTION__, break_state);
+       dbg("%s - state = %d", __func__, break_state);
 
        if (tport == NULL)
                return;
@@ -1093,13 +1113,13 @@ static void ti_break(struct usb_serial_port *port, int break_state)
                TI_LCR_BREAK, break_state == -1 ? TI_LCR_BREAK : 0);
 
        if (status)
-               dbg("%s - error setting break, %d", __FUNCTION__, status);
+               dbg("%s - error setting break, %d", __func__, status);
 }
 
 
 static void ti_interrupt_callback(struct urb *urb)
 {
-       struct ti_device *tdev = (struct ti_device *)urb->context;
+       struct ti_device *tdev = urb->context;
        struct usb_serial_port *port;
        struct usb_serial *serial = tdev->td_serial;
        struct ti_port *tport;
@@ -1112,7 +1132,7 @@ static void ti_interrupt_callback(struct urb *urb)
        int retval;
        __u8 msr;
 
-       dbg("%s", __FUNCTION__);
+       dbg("%s", __func__);
 
        switch (status) {
        case 0:
@@ -1120,33 +1140,35 @@ static void ti_interrupt_callback(struct urb *urb)
        case -ECONNRESET:
        case -ENOENT:
        case -ESHUTDOWN:
-               dbg("%s - urb shutting down, %d", __FUNCTION__, status);
+               dbg("%s - urb shutting down, %d", __func__, status);
                tdev->td_urb_error = 1;
                return;
        default:
                dev_err(dev, "%s - nonzero urb status, %d\n",
-                       __FUNCTION__, status);
+                       __func__, status);
                tdev->td_urb_error = 1;
                goto exit;
        }
 
        if (length != 2) {
-               dbg("%s - bad packet size, %d", __FUNCTION__, length);
+               dbg("%s - bad packet size, %d", __func__, length);
                goto exit;
        }
 
        if (data[0] == TI_CODE_HARDWARE_ERROR) {
-               dev_err(dev, "%s - hardware error, %d\n", __FUNCTION__, data[1]);
+               dev_err(dev, "%s - hardware error, %d\n", __func__, data[1]);
                goto exit;
        }
 
        port_number = TI_GET_PORT_FROM_CODE(data[0]);
        function = TI_GET_FUNC_FROM_CODE(data[0]);
 
-       dbg("%s - port_number %d, function %d, data 0x%02X", __FUNCTION__, port_number, function, data[1]);
+       dbg("%s - port_number %d, function %d, data 0x%02X",
+                               __func__, port_number, function, data[1]);
 
        if (port_number >= serial->num_ports) {
-               dev_err(dev, "%s - bad port number, %d\n", __FUNCTION__, port_number);
+               dev_err(dev, "%s - bad port number, %d\n",
+                                               __func__, port_number);
                goto exit;
        }
 
@@ -1158,17 +1180,19 @@ static void ti_interrupt_callback(struct urb *urb)
 
        switch (function) {
        case TI_CODE_DATA_ERROR:
-               dev_err(dev, "%s - DATA ERROR, port %d, data 0x%02X\n", __FUNCTION__, port_number, data[1]);
+               dev_err(dev, "%s - DATA ERROR, port %d, data 0x%02X\n",
+                                       __func__, port_number, data[1]);
                break;
 
        case TI_CODE_MODEM_STATUS:
                msr = data[1];
-               dbg("%s - port %d, msr 0x%02X", __FUNCTION__, port_number, msr);
+               dbg("%s - port %d, msr 0x%02X", __func__, port_number, msr);
                ti_handle_new_msr(tport, msr);
                break;
 
        default:
-               dev_err(dev, "%s - unknown interrupt code, 0x%02X\n", __FUNCTION__, data[1]);
+               dev_err(dev, "%s - unknown interrupt code, 0x%02X\n",
+                                                       __func__, data[1]);
                break;
        }
 
@@ -1176,19 +1200,19 @@ exit:
        retval = usb_submit_urb(urb, GFP_ATOMIC);
        if (retval)
                dev_err(dev, "%s - resubmit interrupt urb failed, %d\n",
-                       __FUNCTION__, retval);
+                       __func__, retval);
 }
 
 
 static void ti_bulk_in_callback(struct urb *urb)
 {
-       struct ti_port *tport = (struct ti_port *)urb->context;
+       struct ti_port *tport = urb->context;
        struct usb_serial_port *port = tport->tp_port;
        struct device *dev = &urb->dev->dev;
        int status = urb->status;
        int retval = 0;
 
-       dbg("%s", __FUNCTION__);
+       dbg("%s", __func__);
 
        switch (status) {
        case 0:
@@ -1196,13 +1220,13 @@ static void ti_bulk_in_callback(struct urb *urb)
        case -ECONNRESET:
        case -ENOENT:
        case -ESHUTDOWN:
-               dbg("%s - urb shutting down, %d", __FUNCTION__, status);
+               dbg("%s - urb shutting down, %d", __func__, status);
                tport->tp_tdev->td_urb_error = 1;
                wake_up_interruptible(&tport->tp_write_wait);
                return;
        default:
                dev_err(dev, "%s - nonzero urb status, %d\n",
-                       __FUNCTION__, status );
+                       __func__, status);
                tport->tp_tdev->td_urb_error = 1;
                wake_up_interruptible(&tport->tp_write_wait);
        }
@@ -1211,19 +1235,20 @@ static void ti_bulk_in_callback(struct urb *urb)
                goto exit;
 
        if (status) {
-               dev_err(dev, "%s - stopping read!\n", __FUNCTION__);
+               dev_err(dev, "%s - stopping read!\n", __func__);
                return;
        }
 
-       if (port->tty && urb->actual_length) {
-               usb_serial_debug_data(debug, dev, __FUNCTION__,
+       if (port->port.tty && urb->actual_length) {
+               usb_serial_debug_data(debug, dev, __func__,
                        urb->actual_length, urb->transfer_buffer);
 
                if (!tport->tp_is_open)
-                       dbg("%s - port closed, dropping data", __FUNCTION__);
+                       dbg("%s - port closed, dropping data", __func__);
                else
-                       ti_recv(&urb->dev->dev, port->tty, urb->transfer_buffer,
-                               urb->actual_length);
+                       ti_recv(&urb->dev->dev, port->port.tty,
+                                               urb->transfer_buffer,
+                                               urb->actual_length);
 
                spin_lock(&tport->tp_lock);
                tport->tp_icount.rx += urb->actual_length;
@@ -1242,18 +1267,18 @@ exit:
        spin_unlock(&tport->tp_lock);
        if (retval)
                dev_err(dev, "%s - resubmit read urb failed, %d\n",
-                       __FUNCTION__, retval);
+                       __func__, retval);
 }
 
 
 static void ti_bulk_out_callback(struct urb *urb)
 {
-       struct ti_port *tport = (struct ti_port *)urb->context;
+       struct ti_port *tport = urb->context;
        struct usb_serial_port *port = tport->tp_port;
        struct device *dev = &urb->dev->dev;
        int status = urb->status;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        tport->tp_write_urb_in_use = 0;
 
@@ -1263,13 +1288,13 @@ static void ti_bulk_out_callback(struct urb *urb)
        case -ECONNRESET:
        case -ENOENT:
        case -ESHUTDOWN:
-               dbg("%s - urb shutting down, %d", __FUNCTION__, status);
+               dbg("%s - urb shutting down, %d", __func__, status);
                tport->tp_tdev->td_urb_error = 1;
                wake_up_interruptible(&tport->tp_write_wait);
                return;
        default:
                dev_err(dev, "%s - nonzero urb status, %d\n",
-                       __FUNCTION__, status);
+                       __func__, status);
                tport->tp_tdev->td_urb_error = 1;
                wake_up_interruptible(&tport->tp_write_wait);
        }
@@ -1287,8 +1312,9 @@ static void ti_recv(struct device *dev, struct tty_struct *tty,
        do {
                cnt = tty_buffer_request_room(tty, length);
                if (cnt < length) {
-                       dev_err(dev, "%s - dropping data, %d bytes lost\n", __FUNCTION__, length - cnt);
-                       if(cnt == 0)
+                       dev_err(dev, "%s - dropping data, %d bytes lost\n",
+                                               __func__, length - cnt);
+                       if (cnt == 0)
                                break;
                }
                tty_insert_flip_string(tty, data, cnt);
@@ -1304,11 +1330,11 @@ static void ti_send(struct ti_port *tport)
 {
        int count, result;
        struct usb_serial_port *port = tport->tp_port;
-       struct tty_struct *tty = port->tty;
+       struct tty_struct *tty = port->port.tty;        /* FIXME */
        unsigned long flags;
 
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        spin_lock_irqsave(&tport->tp_lock, flags);
 
@@ -1330,7 +1356,8 @@ static void ti_send(struct ti_port *tport)
 
        spin_unlock_irqrestore(&tport->tp_lock, flags);
 
-       usb_serial_debug_data(debug, &port->dev, __FUNCTION__, count, port->write_urb->transfer_buffer);
+       usb_serial_debug_data(debug, &port->dev, __func__, count,
+                                       port->write_urb->transfer_buffer);
 
        usb_fill_bulk_urb(port->write_urb, port->serial->dev,
                           usb_sndbulkpipe(port->serial->dev,
@@ -1340,8 +1367,9 @@ static void ti_send(struct ti_port *tport)
 
        result = usb_submit_urb(port->write_urb, GFP_ATOMIC);
        if (result) {
-               dev_err(&port->dev, "%s - submit write urb failed, %d\n", __FUNCTION__, result);
-               tport->tp_write_urb_in_use = 0; 
+               dev_err(&port->dev, "%s - submit write urb failed, %d\n",
+                                                       __func__, result);
+               tport->tp_write_urb_in_use = 0;
                /* TODO: reschedule ti_send */
        } else {
                spin_lock_irqsave(&tport->tp_lock, flags);
@@ -1358,14 +1386,17 @@ static void ti_send(struct ti_port *tport)
 
 static int ti_set_mcr(struct ti_port *tport, unsigned int mcr)
 {
+       unsigned long flags;
        int status;
 
        status = ti_write_byte(tport->tp_tdev,
                tport->tp_uart_base_addr + TI_UART_OFFSET_MCR,
                TI_MCR_RTS | TI_MCR_DTR | TI_MCR_LOOP, mcr);
 
+       spin_lock_irqsave(&tport->tp_lock, flags);
        if (!status)
                tport->tp_shadow_mcr = mcr;
+       spin_unlock_irqrestore(&tport->tp_lock, flags);
 
        return status;
 }
@@ -1373,29 +1404,31 @@ static int ti_set_mcr(struct ti_port *tport, unsigned int mcr)
 
 static int ti_get_lsr(struct ti_port *tport)
 {
-       int size,status;
+       int size, status;
        struct ti_device *tdev = tport->tp_tdev;
        struct usb_serial_port *port = tport->tp_port;
        int port_number = port->number - port->serial->minor;
        struct ti_port_status *data;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        size = sizeof(struct ti_port_status);
        data = kmalloc(size, GFP_KERNEL);
        if (!data) {
-               dev_err(&port->dev, "%s - out of memory\n", __FUNCTION__);
+               dev_err(&port->dev, "%s - out of memory\n", __func__);
                return -ENOMEM;
        }
 
        status = ti_command_in_sync(tdev, TI_GET_PORT_STATUS,
                (__u8)(TI_UART1_PORT+port_number), 0, (__u8 *)data, size);
        if (status) {
-               dev_err(&port->dev, "%s - get port status command failed, %d\n", __FUNCTION__, status);
+               dev_err(&port->dev,
+                       "%s - get port status command failed, %d\n",
+                                                       __func__, status);
                goto free_data;
        }
 
-       dbg("%s - lsr 0x%02X", __FUNCTION__, data->bLSR);
+       dbg("%s - lsr 0x%02X", __func__, data->bLSR);
 
        tport->tp_lsr = data->bLSR;
 
@@ -1441,8 +1474,9 @@ static int ti_set_serial_info(struct ti_port *tport,
                return -EFAULT;
 
        tport->tp_flags = new_serial.flags & TI_SET_SERIAL_FLAGS;
-       if (port->tty)
-               port->tty->low_latency =
+       /* FIXME */
+       if (port->port.tty)
+               port->port.tty->low_latency =
                        (tport->tp_flags & ASYNC_LOW_LATENCY) ? 1 : 0;
        tport->tp_closing_wait = new_serial.closing_wait;
 
@@ -1456,7 +1490,7 @@ static void ti_handle_new_msr(struct ti_port *tport, __u8 msr)
        struct tty_struct *tty;
        unsigned long flags;
 
-       dbg("%s - msr 0x%02X", __FUNCTION__, msr);
+       dbg("%s - msr 0x%02X", __func__, msr);
 
        if (msr & TI_MSR_DELTA_MASK) {
                spin_lock_irqsave(&tport->tp_lock, flags);
@@ -1476,7 +1510,7 @@ static void ti_handle_new_msr(struct ti_port *tport, __u8 msr)
        tport->tp_msr = msr & TI_MSR_MASK;
 
        /* handle CTS flow control */
-       tty = tport->tp_port->tty;
+       tty = tport->tp_port->port.tty;
        if (tty && C_CRTSCTS(tty)) {
                if (msr & TI_MSR_CTS) {
                        tty->hw_stopped = 0;
@@ -1494,7 +1528,7 @@ static void ti_drain(struct ti_port *tport, unsigned long timeout, int flush)
        struct usb_serial_port *port = tport->tp_port;
        wait_queue_t wait;
 
-       dbg("%s - port %d", __FUNCTION__, port->number);
+       dbg("%s - port %d", __func__, port->number);
 
        spin_lock_irq(&tport->tp_lock);
 
@@ -1626,12 +1660,13 @@ static int ti_write_byte(struct ti_device *tdev, unsigned long addr,
        struct ti_write_data_bytes *data;
        struct device *dev = &tdev->td_serial->dev->dev;
 
-       dbg("%s - addr 0x%08lX, mask 0x%02X, byte 0x%02X", __FUNCTION__, addr, mask, byte);
+       dbg("%s - addr 0x%08lX, mask 0x%02X, byte 0x%02X",
+                                       __func__, addr, mask, byte);
 
        size = sizeof(struct ti_write_data_bytes) + 2;
        data = kmalloc(size, GFP_KERNEL);
        if (!data) {
-               dev_err(dev, "%s - out of memory\n", __FUNCTION__);
+               dev_err(dev, "%s - out of memory\n", __func__);
                return -ENOMEM;
        }
 
@@ -1647,63 +1682,79 @@ static int ti_write_byte(struct ti_device *tdev, unsigned long addr,
                (__u8 *)data, size);
 
        if (status < 0)
-               dev_err(dev, "%s - failed, %d\n", __FUNCTION__, status);
+               dev_err(dev, "%s - failed, %d\n", __func__, status);
 
        kfree(data);
 
        return status;
 }
 
-
-static int ti_download_firmware(struct ti_device *tdev,
-       unsigned char *firmware, unsigned int firmware_size)
+static int ti_do_download(struct usb_device *dev, int pipe,
+                                               u8 *buffer, int size)
 {
-       int status = 0;
-       int buffer_size;
        int pos;
-       int len;
+       u8 cs = 0;
        int done;
-       __u8 cs = 0;
-       __u8 *buffer;
-       struct usb_device *dev = tdev->td_serial->dev;
        struct ti_firmware_header *header;
-       unsigned int pipe = usb_sndbulkpipe(dev,
-               tdev->td_serial->port[0]->bulk_out_endpointAddress);
-
-
-       buffer_size = TI_FIRMWARE_BUF_SIZE + sizeof(struct ti_firmware_header);
-       buffer = kmalloc(buffer_size, GFP_KERNEL);
-       if (!buffer) {
-               dev_err(&dev->dev, "%s - out of memory\n", __FUNCTION__);
-               return -ENOMEM;
-       }
-
-       memcpy(buffer, firmware, firmware_size);
-       memset(buffer+firmware_size, 0xff, buffer_size-firmware_size);
+       int status;
+       int len;
 
-       for(pos = sizeof(struct ti_firmware_header); pos < buffer_size; pos++)
+       for (pos = sizeof(struct ti_firmware_header); pos < size; pos++)
                cs = (__u8)(cs + buffer[pos]);
 
        header = (struct ti_firmware_header *)buffer;
-       header->wLength = cpu_to_le16((__u16)(buffer_size - sizeof(struct ti_firmware_header)));
+       header->wLength = cpu_to_le16((__u16)(size
+                                       - sizeof(struct ti_firmware_header)));
        header->bCheckSum = cs;
 
-       dbg("%s - downloading firmware", __FUNCTION__);
-       for (pos = 0; pos < buffer_size; pos += done) {
-               len = min(buffer_size - pos, TI_DOWNLOAD_MAX_PACKET_SIZE);
-               status = usb_bulk_msg(dev, pipe, buffer+pos, len, &done, 1000);
+       dbg("%s - downloading firmware", __func__);
+       for (pos = 0; pos < size; pos += done) {
+               len = min(size - pos, TI_DOWNLOAD_MAX_PACKET_SIZE);
+               status = usb_bulk_msg(dev, pipe, buffer + pos, len,
+                                                               &done, 1000);
                if (status)
                        break;
        }
+       return status;
+}
+
+static int ti_download_firmware(struct ti_device *tdev, int type)
+{
+       int status = -ENOMEM;
+       int buffer_size;
+       __u8 *buffer;
+       struct usb_device *dev = tdev->td_serial->dev;
+       unsigned int pipe = usb_sndbulkpipe(dev,
+               tdev->td_serial->port[0]->bulk_out_endpointAddress);
+       const struct firmware *fw_p;
+       char buf[32];
+       sprintf(buf, "ti_usb-%d.bin", type);
 
-       kfree(buffer);
+       if (request_firmware(&fw_p, buf, &dev->dev)) {
+               dev_err(&dev->dev, "%s - firmware not found\n", __func__);
+               return -ENOENT;
+       }
+       if (fw_p->size > TI_FIRMWARE_BUF_SIZE) {
+               dev_err(&dev->dev, "%s - firmware too large\n", __func__);
+               return -ENOENT;
+       }
 
+       buffer_size = TI_FIRMWARE_BUF_SIZE + sizeof(struct ti_firmware_header);
+       buffer = kmalloc(buffer_size, GFP_KERNEL);
+       if (buffer) {
+               memcpy(buffer, fw_p->data, fw_p->size);
+               memset(buffer + fw_p->size, 0xff, buffer_size - fw_p->size);
+               ti_do_download(dev, pipe, buffer, fw_p->size);
+               kfree(buffer);
+       }
+       release_firmware(fw_p);
        if (status) {
-               dev_err(&dev->dev, "%s - error downloading firmware, %d\n", __FUNCTION__, status);
+               dev_err(&dev->dev, "%s - error downloading firmware, %d\n",
+                                                       __func__, status);
                return status;
        }
 
-       dbg("%s - download successful", __FUNCTION__);
+       dbg("%s - download successful", __func__);
 
        return 0;
 }
@@ -1771,7 +1822,7 @@ static void ti_buf_clear(struct circ_buf *cb)
 
 static int ti_buf_data_avail(struct circ_buf *cb)
 {
-       return CIRC_CNT(cb->head,cb->tail,TI_WRITE_BUF_SIZE);
+       return CIRC_CNT(cb->head, cb->tail, TI_WRITE_BUF_SIZE);
 }
 
 
@@ -1784,7 +1835,7 @@ static int ti_buf_data_avail(struct circ_buf *cb)
 
 static int ti_buf_space_avail(struct circ_buf *cb)
 {
-       return CIRC_SPACE(cb->head,cb->tail,TI_WRITE_BUF_SIZE);
+       return CIRC_SPACE(cb->head, cb->tail, TI_WRITE_BUF_SIZE);
 }