]> err.no Git - linux-2.6/blobdiff - drivers/usb/core/hub.c
USB: remove CONFIG_USB_PERSIST setting
[linux-2.6] / drivers / usb / core / hub.c
index f7c2219c800f71985c1889b223aa0134c28c8453..6dc589955d75da4a8d5edc37e52f7e8aaedfffe8 100644 (file)
@@ -23,7 +23,6 @@
 #include <linux/mutex.h>
 #include <linux/freezer.h>
 
-#include <asm/semaphore.h>
 #include <asm/uaccess.h>
 #include <asm/byteorder.h>
 
 #include "hcd.h"
 #include "hub.h"
 
-#ifdef CONFIG_USB_PERSIST
-#define        USB_PERSIST     1
-#else
-#define        USB_PERSIST     0
-#endif
-
 /* if we are in debug mode, always announce new devices */
 #ifdef DEBUG
 #ifndef CONFIG_USB_ANNOUNCE_NEW_DEVICES
@@ -334,6 +327,27 @@ static int get_port_status(struct usb_device *hdev, int port1,
        return status;
 }
 
+static int hub_port_status(struct usb_hub *hub, int port1,
+               u16 *status, u16 *change)
+{
+       int ret;
+
+       mutex_lock(&hub->status_mutex);
+       ret = get_port_status(hub->hdev, port1, &hub->status->port);
+       if (ret < 4) {
+               dev_err(hub->intfdev,
+                       "%s failed (err = %d)\n", __func__, ret);
+               if (ret >= 0)
+                       ret = -EIO;
+       } else {
+               *status = le16_to_cpu(hub->status->port.wPortStatus);
+               *change = le16_to_cpu(hub->status->port.wPortChange);
+               ret = 0;
+       }
+       mutex_unlock(&hub->status_mutex);
+       return ret;
+}
+
 static void kick_khubd(struct usb_hub *hub)
 {
        unsigned long   flags;
@@ -494,6 +508,7 @@ void usb_hub_tt_clear_buffer (struct usb_device *udev, int pipe)
        schedule_work (&tt->kevent);
        spin_unlock_irqrestore (&tt->lock, flags);
 }
+EXPORT_SYMBOL_GPL(usb_hub_tt_clear_buffer);
 
 static void hub_power_on(struct usb_hub *hub)
 {
@@ -610,9 +625,8 @@ static void hub_port_logical_disconnect(struct usb_hub *hub, int port1)
 }
 
 /* caller has locked the hub device */
-static int hub_pre_reset(struct usb_interface *intf)
+static void hub_stop(struct usb_hub *hub)
 {
-       struct usb_hub *hub = usb_get_intfdata(intf);
        struct usb_device *hdev = hub->hdev;
        int i;
 
@@ -622,6 +636,89 @@ static int hub_pre_reset(struct usb_interface *intf)
                        usb_disconnect(&hdev->children[i]);
        }
        hub_quiesce(hub);
+}
+
+#define HUB_RESET              1
+#define HUB_RESUME             2
+#define HUB_RESET_RESUME       3
+
+#ifdef CONFIG_PM
+
+static void hub_restart(struct usb_hub *hub, int type)
+{
+       struct usb_device *hdev = hub->hdev;
+       int port1;
+
+       /* Check each of the children to see if they require
+        * USB-PERSIST handling or disconnection.  Also check
+        * each unoccupied port to make sure it is still disabled.
+        */
+       for (port1 = 1; port1 <= hdev->maxchild; ++port1) {
+               struct usb_device *udev = hdev->children[port1-1];
+               int status = 0;
+               u16 portstatus, portchange;
+
+               if (!udev || udev->state == USB_STATE_NOTATTACHED) {
+                       if (type != HUB_RESET) {
+                               status = hub_port_status(hub, port1,
+                                               &portstatus, &portchange);
+                               if (status == 0 && (portstatus &
+                                               USB_PORT_STAT_ENABLE))
+                                       clear_port_feature(hdev, port1,
+                                                       USB_PORT_FEAT_ENABLE);
+                       }
+                       continue;
+               }
+
+               /* Was the power session lost while we were suspended? */
+               switch (type) {
+               case HUB_RESET_RESUME:
+                       portstatus = 0;
+                       portchange = USB_PORT_STAT_C_CONNECTION;
+                       break;
+
+               case HUB_RESET:
+               case HUB_RESUME:
+                       status = hub_port_status(hub, port1,
+                                       &portstatus, &portchange);
+                       break;
+               }
+
+               /* For "USB_PERSIST"-enabled children we must
+                * mark the child device for reset-resume and
+                * turn off the various status changes to prevent
+                * khubd from disconnecting it later.
+                */
+               if (udev->persist_enabled && status == 0 &&
+                               !(portstatus & USB_PORT_STAT_ENABLE)) {
+                       if (portchange & USB_PORT_STAT_C_ENABLE)
+                               clear_port_feature(hub->hdev, port1,
+                                               USB_PORT_FEAT_C_ENABLE);
+                       if (portchange & USB_PORT_STAT_C_CONNECTION)
+                               clear_port_feature(hub->hdev, port1,
+                                               USB_PORT_FEAT_C_CONNECTION);
+                       udev->reset_resume = 1;
+               }
+
+               /* Otherwise for a reset_resume we must disconnect the child,
+                * but as we may not lock the child device here
+                * we have to do a "logical" disconnect.
+                */
+               else if (type == HUB_RESET_RESUME)
+                       hub_port_logical_disconnect(hub, port1);
+       }
+
+       hub_activate(hub);
+}
+
+#endif /* CONFIG_PM */
+
+/* caller has locked the hub device */
+static int hub_pre_reset(struct usb_interface *intf)
+{
+       struct usb_hub *hub = usb_get_intfdata(intf);
+
+       hub_stop(hub);
        return 0;
 }
 
@@ -910,7 +1007,7 @@ static void hub_disconnect(struct usb_interface *intf)
 
        /* Disconnect all children and quiesce the hub */
        hub->error = 0;
-       hub_pre_reset(intf);
+       hub_stop(hub);
 
        usb_set_intfdata (intf, NULL);
 
@@ -1034,8 +1131,10 @@ static void recursively_mark_NOTATTACHED(struct usb_device *udev)
                if (udev->children[i])
                        recursively_mark_NOTATTACHED(udev->children[i]);
        }
-       if (udev->state == USB_STATE_SUSPENDED)
+       if (udev->state == USB_STATE_SUSPENDED) {
                udev->discon_suspended = 1;
+               udev->active_duration -= jiffies;
+       }
        udev->state = USB_STATE_NOTATTACHED;
 }
 
@@ -1084,6 +1183,12 @@ void usb_set_device_state(struct usb_device *udev,
                        else
                                device_init_wakeup(&udev->dev, 0);
                }
+               if (udev->state == USB_STATE_SUSPENDED &&
+                       new_state != USB_STATE_SUSPENDED)
+                       udev->active_duration -= jiffies;
+               else if (new_state == USB_STATE_SUSPENDED &&
+                               udev->state != USB_STATE_SUSPENDED)
+                       udev->active_duration += jiffies;
                udev->state = new_state;
        } else
                recursively_mark_NOTATTACHED(udev);
@@ -1502,28 +1607,6 @@ out_authorized:
 }
 
 
-static int hub_port_status(struct usb_hub *hub, int port1,
-                              u16 *status, u16 *change)
-{
-       int ret;
-
-       mutex_lock(&hub->status_mutex);
-       ret = get_port_status(hub->hdev, port1, &hub->status->port);
-       if (ret < 4) {
-               dev_err (hub->intfdev,
-                       "%s failed (err = %d)\n", __FUNCTION__, ret);
-               if (ret >= 0)
-                       ret = -EIO;
-       } else {
-               *status = le16_to_cpu(hub->status->port.wPortStatus);
-               *change = le16_to_cpu(hub->status->port.wPortChange); 
-               ret = 0;
-       }
-       mutex_unlock(&hub->status_mutex);
-       return ret;
-}
-
-
 /* Returns 1 if @hub is a WUSB root hub, 0 otherwise */
 static unsigned hub_is_wusb(struct usb_hub *hub)
 {
@@ -1834,9 +1917,8 @@ static int finish_port_resume(struct usb_device *udev)
  * the host and the device is the same as it was when the device
  * suspended.
  *
- * If CONFIG_USB_PERSIST and @udev->reset_resume are both set then this
- * routine won't check that the port is still enabled.  Furthermore,
- * if @udev->reset_resume is set then finish_port_resume() above will
+ * If @udev->reset_resume is set then this routine won't check that the
+ * port is still enabled.  Furthermore, finish_port_resume() above will
  * reset @udev.  The end result is that a broken power session can be
  * recovered and @udev will appear to persist across a loss of VBUS power.
  *
@@ -1848,8 +1930,8 @@ static int finish_port_resume(struct usb_device *udev)
  * to it will be lost.  Using the USB_PERSIST facility, the device can be
  * made to appear as if it had not disconnected.
  *
- * This facility is inherently dangerous.  Although usb_reset_device()
- * makes every effort to insure that the same device is present after the
+ * This facility can be dangerous.  Although usb_reset_device() makes
+ * every effort to insure that the same device is present after the
  * reset as before, it cannot provide a 100% guarantee.  Furthermore it's
  * quite possible for a device to remain unaltered but its media to be
  * changed.  If the user replaces a flash memory card while the system is
@@ -1894,7 +1976,7 @@ int usb_port_resume(struct usb_device *udev)
                status = hub_port_status(hub, port1, &portstatus, &portchange);
 
  SuspendCleared:
-               if (USB_PERSIST && udev->reset_resume)
+               if (udev->reset_resume)
                        want_flags = USB_PORT_STAT_POWER
                                        | USB_PORT_STAT_CONNECTION;
                else
@@ -2001,49 +2083,20 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
 
 static int hub_resume(struct usb_interface *intf)
 {
-       struct usb_hub          *hub = usb_get_intfdata (intf);
-
-       dev_dbg(&intf->dev, "%s\n", __FUNCTION__);
+       struct usb_hub *hub = usb_get_intfdata(intf);
 
-       /* tell khubd to look for changes on this hub */
-       hub_activate(hub);
+       dev_dbg(&intf->dev, "%s\n", __func__);
+       hub_restart(hub, HUB_RESUME);
        return 0;
 }
 
 static int hub_reset_resume(struct usb_interface *intf)
 {
        struct usb_hub *hub = usb_get_intfdata(intf);
-       struct usb_device *hdev = hub->hdev;
-       int port1;
 
+       dev_dbg(&intf->dev, "%s\n", __func__);
        hub_power_on(hub);
-
-       for (port1 = 1; port1 <= hdev->maxchild; ++port1) {
-               struct usb_device *child = hdev->children[port1-1];
-
-               if (child) {
-
-                       /* For "USB_PERSIST"-enabled children we must
-                        * mark the child device for reset-resume and
-                        * turn off the connect-change status to prevent
-                        * khubd from disconnecting it later.
-                        */
-                       if (USB_PERSIST && child->persist_enabled) {
-                               child->reset_resume = 1;
-                               clear_port_feature(hdev, port1,
-                                               USB_PORT_FEAT_C_CONNECTION);
-
-                       /* Otherwise we must disconnect the child,
-                        * but as we may not lock the child device here
-                        * we have to do a "logical" disconnect.
-                        */
-                       } else {
-                               hub_port_logical_disconnect(hub, port1);
-                       }
-               }
-       }
-
-       hub_activate(hub);
+       hub_restart(hub, HUB_RESET_RESUME);
        return 0;
 }
 
@@ -2053,10 +2106,10 @@ static int hub_reset_resume(struct usb_interface *intf)
  *
  * The USB host controller driver calls this function when its root hub
  * is resumed and Vbus power has been interrupted or the controller
- * has been reset.  The routine marks @rhdev as having lost power.  When
- * the hub driver is resumed it will take notice; if CONFIG_USB_PERSIST
- * is enabled then it will carry out power-session recovery, otherwise
- * it will disconnect all the child devices.
+ * has been reset.  The routine marks @rhdev as having lost power.
+ * When the hub driver is resumed it will take notice and carry out
+ * power-session recovery for all the "USB-PERSIST"-enabled child devices;
+ * the others will be disconnected.
  */
 void usb_root_hub_lost_power(struct usb_device *rhdev)
 {
@@ -2718,7 +2771,7 @@ static void hub_events(void)
                /* If the hub has died, clean up after it */
                if (hdev->state == USB_STATE_NOTATTACHED) {
                        hub->error = -ENODEV;
-                       hub_pre_reset(intf);
+                       hub_stop(hub);
                        goto loop;
                }
 
@@ -2882,7 +2935,13 @@ loop:
 
 static int hub_thread(void *__unused)
 {
+       /* khubd needs to be freezable to avoid intefering with USB-PERSIST
+        * port handover.  Otherwise it might see that a full-speed device
+        * was gone before the EHCI controller had handed its port over to
+        * the companion full-speed controller.
+        */
        set_freezable();
+
        do {
                hub_events();
                wait_event_freezable(khubd_wait,
@@ -3108,7 +3167,7 @@ re_enumerate:
        hub_port_logical_disconnect(parent_hub, port1);
        return -ENODEV;
 }
-EXPORT_SYMBOL(usb_reset_device);
+EXPORT_SYMBOL_GPL(usb_reset_device);
 
 /**
  * usb_reset_composite_device - warn interface drivers and perform a USB port reset
@@ -3125,16 +3184,12 @@ EXPORT_SYMBOL(usb_reset_device);
  * this from a driver probe() routine after downloading new firmware.
  * For calls that might not occur during probe(), drivers should lock
  * the device using usb_lock_device_for_reset().
- *
- * The interface locks are acquired during the pre_reset stage and released
- * during the post_reset stage.  However if iface is not NULL and is
- * currently being probed, we assume that the caller already owns its
- * lock.
  */
 int usb_reset_composite_device(struct usb_device *udev,
                struct usb_interface *iface)
 {
        int ret;
+       int i;
        struct usb_host_config *config = udev->actconfig;
 
        if (udev->state == USB_STATE_NOTATTACHED ||
@@ -3151,16 +3206,11 @@ int usb_reset_composite_device(struct usb_device *udev,
                iface = NULL;
 
        if (config) {
-               int i;
-               struct usb_interface *cintf;
-               struct usb_driver *drv;
-
                for (i = 0; i < config->desc.bNumInterfaces; ++i) {
-                       cintf = config->interface[i];
-                       if (cintf != iface)
-                               down(&cintf->dev.sem);
-                       if (device_is_registered(&cintf->dev) &&
-                                       cintf->dev.driver) {
+                       struct usb_interface *cintf = config->interface[i];
+                       struct usb_driver *drv;
+
+                       if (cintf->dev.driver) {
                                drv = to_usb_driver(cintf->dev.driver);
                                if (drv->pre_reset)
                                        (drv->pre_reset)(cintf);
@@ -3172,25 +3222,20 @@ int usb_reset_composite_device(struct usb_device *udev,
        ret = usb_reset_device(udev);
 
        if (config) {
-               int i;
-               struct usb_interface *cintf;
-               struct usb_driver *drv;
-
                for (i = config->desc.bNumInterfaces - 1; i >= 0; --i) {
-                       cintf = config->interface[i];
-                       if (device_is_registered(&cintf->dev) &&
-                                       cintf->dev.driver) {
+                       struct usb_interface *cintf = config->interface[i];
+                       struct usb_driver *drv;
+
+                       if (cintf->dev.driver) {
                                drv = to_usb_driver(cintf->dev.driver);
                                if (drv->post_reset)
                                        (drv->post_reset)(cintf);
        /* FIXME: Unbind if post_reset returns an error or isn't defined */
                        }
-                       if (cintf != iface)
-                               up(&cintf->dev.sem);
                }
        }
 
        usb_autosuspend_device(udev);
        return ret;
 }
-EXPORT_SYMBOL(usb_reset_composite_device);
+EXPORT_SYMBOL_GPL(usb_reset_composite_device);