]> err.no Git - linux-2.6/blobdiff - drivers/s390/cio/chsc.c
[S390] cio: Introduce separate files for channel-path related code.
[linux-2.6] / drivers / s390 / cio / chsc.c
index 15b0e6329cf3f913dd1689724fa27ab9a9f10162..d99f525eac08534183b77791a199215fb3ae1dac 100644 (file)
 #include "cio.h"
 #include "cio_debug.h"
 #include "ioasm.h"
+#include "chpid.h"
+#include "chp.h"
 #include "chsc.h"
 
 static void *sei_page;
 
-static int new_channel_path(int chpid);
-
-static inline void
-set_chp_logically_online(int chp, int onoff)
-{
-       css[0]->chps[chp]->state = onoff;
-}
-
-static int
-get_chp_status(int chp)
-{
-       return (css[0]->chps[chp] ? css[0]->chps[chp]->state : -ENODEV);
-}
-
-void
-chsc_validate_chpids(struct subchannel *sch)
-{
-       int mask, chp;
-
-       for (chp = 0; chp <= 7; chp++) {
-               mask = 0x80 >> chp;
-               if (!get_chp_status(sch->schib.pmcw.chpid[chp]))
-                       /* disable using this path */
-                       sch->opm &= ~mask;
-       }
-}
-
-void
-chpid_is_actually_online(int chp)
-{
-       int state;
-
-       state = get_chp_status(chp);
-       if (state < 0) {
-               need_rescan = 1;
-               queue_work(slow_path_wq, &slow_path_work);
-       } else
-               WARN_ON(!state);
-}
-
 /* FIXME: this is _always_ called for every subchannel. shouldn't we
  *       process more than one at a time? */
 static int
@@ -93,7 +55,7 @@ chsc_get_sch_desc_irq(struct subchannel *sch, void *page)
                u16 sch;          /* subchannel */
                u8 chpid[8];      /* chpids 0-7 */
                u16 fla[8];       /* full link addresses 0-7 */
-       } *ssd_area;
+       } __attribute__ ((packed)) *ssd_area;
 
        ssd_area = page;
 
@@ -200,14 +162,17 @@ css_get_ssd_info(struct subchannel *sch)
        spin_unlock_irq(sch->lock);
        free_page((unsigned long)page);
        if (!ret) {
-               int j, chpid, mask;
+               int j, mask;
+               struct chp_id chpid;
+
+               chp_id_init(&chpid);
                /* Allocate channel path structures, if needed. */
                for (j = 0; j < 8; j++) {
                        mask = 0x80 >> j;
-                       chpid = sch->ssd_info.chpid[j];
+                       chpid.id = sch->ssd_info.chpid[j];
                        if ((sch->schib.pmcw.pim & mask) &&
-                           (get_chp_status(chpid) < 0))
-                           new_channel_path(chpid);
+                           !chp_is_registered(chpid))
+                               chp_new(chpid);
                }
        }
        return ret;
@@ -219,7 +184,7 @@ s390_subchannel_remove_chpid(struct device *dev, void *data)
        int j;
        int mask;
        struct subchannel *sch;
-       struct channel_path *chpid;
+       struct chp_id *chpid;
        struct schib schib;
 
        sch = to_subchannel(dev);
@@ -277,52 +242,48 @@ out_unreg:
        return 0;
 }
 
-static inline void
-s390_set_chpid_offline( __u8 chpid)
+void chsc_chp_offline(struct chp_id chpid)
 {
        char dbf_txt[15];
-       struct device *dev;
 
-       sprintf(dbf_txt, "chpr%x", chpid);
+       sprintf(dbf_txt, "chpr%x.%02x", chpid.cssid, chpid.id);
        CIO_TRACE_EVENT(2, dbf_txt);
 
-       if (get_chp_status(chpid) <= 0)
+       if (chp_get_status(chpid) <= 0)
                return;
-       dev = get_device(&css[0]->chps[chpid]->dev);
-       bus_for_each_dev(&css_bus_type, NULL, to_channelpath(dev),
+       bus_for_each_dev(&css_bus_type, NULL, &chpid,
                         s390_subchannel_remove_chpid);
 
        if (need_rescan || css_slow_subchannels_exist())
                queue_work(slow_path_wq, &slow_path_work);
-       put_device(dev);
 }
 
 struct res_acc_data {
-       struct channel_path *chp;
+       struct chp_id chpid;
        u32 fla_mask;
        u16 fla;
 };
 
-static int
-s390_process_res_acc_sch(struct res_acc_data *res_data, struct subchannel *sch)
+static int s390_process_res_acc_sch(struct res_acc_data *res_data,
+                                   struct subchannel *sch)
 {
        int found;
        int chp;
        int ccode;
-       
+
        found = 0;
        for (chp = 0; chp <= 7; chp++)
                /*
                 * check if chpid is in information updated by ssd
                 */
                if (sch->ssd_info.valid &&
-                   sch->ssd_info.chpid[chp] == res_data->chp->id &&
+                   sch->ssd_info.chpid[chp] == res_data->chpid.id &&
                    (sch->ssd_info.fla[chp] & res_data->fla_mask)
                    == res_data->fla) {
                        found = 1;
                        break;
                }
-       
+
        if (found == 0)
                return 0;
 
@@ -338,7 +299,7 @@ s390_process_res_acc_sch(struct res_acc_data *res_data, struct subchannel *sch)
        return 0x80 >> chp;
 }
 
-static inline int
+static int
 s390_process_res_acc_new_sch(struct subchannel_id schid)
 {
        struct schib schib;
@@ -409,7 +370,8 @@ s390_process_res_acc (struct res_acc_data *res_data)
        int rc;
        char dbf_txt[15];
 
-       sprintf(dbf_txt, "accpr%x", res_data->chp->id);
+       sprintf(dbf_txt, "accpr%x.%02x", res_data->chpid.cssid,
+               res_data->chpid.id);
        CIO_TRACE_EVENT( 2, dbf_txt);
        if (res_data->fla != 0) {
                sprintf(dbf_txt, "fla%x", res_data->fla);
@@ -444,7 +406,7 @@ __get_chpid_from_lir(void *data)
                u32 andesc[28];
                /* incident-specific information */
                u32 isinfo[28];
-       } *lir;
+       } __attribute__ ((packed)) *lir;
 
        lir = data;
        if (!(lir->iq&0x80))
@@ -461,154 +423,150 @@ __get_chpid_from_lir(void *data)
        return (u16) (lir->indesc[0]&0x000000ff);
 }
 
-int
-chsc_process_crw(void)
+struct chsc_sei_area {
+       struct chsc_header request;
+       u32 reserved1;
+       u32 reserved2;
+       u32 reserved3;
+       struct chsc_header response;
+       u32 reserved4;
+       u8  flags;
+       u8  vf;         /* validity flags */
+       u8  rs;         /* reporting source */
+       u8  cc;         /* content code */
+       u16 fla;        /* full link address */
+       u16 rsid;       /* reporting source id */
+       u32 reserved5;
+       u32 reserved6;
+       u8 ccdf[4096 - 16 - 24];        /* content-code dependent field */
+       /* ccdf has to be big enough for a link-incident record */
+} __attribute__ ((packed));
+
+static int chsc_process_sei_link_incident(struct chsc_sei_area *sei_area)
+{
+       struct chp_id chpid;
+       int id;
+
+       CIO_CRW_EVENT(4, "chsc: link incident (rs=%02x, rs_id=%04x)\n",
+                     sei_area->rs, sei_area->rsid);
+       if (sei_area->rs != 4)
+               return 0;
+       id = __get_chpid_from_lir(sei_area->ccdf);
+       if (id < 0)
+               CIO_CRW_EVENT(4, "chsc: link incident - invalid LIR\n");
+       else {
+               chp_id_init(&chpid);
+               chpid.id = id;
+               chsc_chp_offline(chpid);
+       }
+
+       return 0;
+}
+
+static int chsc_process_sei_res_acc(struct chsc_sei_area *sei_area)
 {
-       int chpid, ret;
        struct res_acc_data res_data;
-       struct {
-               struct chsc_header request;
-               u32 reserved1;
-               u32 reserved2;
-               u32 reserved3;
-               struct chsc_header response;
-               u32 reserved4;
-               u8  flags;
-               u8  vf;         /* validity flags */
-               u8  rs;         /* reporting source */
-               u8  cc;         /* content code */
-               u16 fla;        /* full link address */
-               u16 rsid;       /* reporting source id */
-               u32 reserved5;
-               u32 reserved6;
-               u32 ccdf[96];   /* content-code dependent field */
-               /* ccdf has to be big enough for a link-incident record */
-       } *sei_area;
+       struct chp_id chpid;
+       int status;
+       int rc;
+
+       CIO_CRW_EVENT(4, "chsc: resource accessibility event (rs=%02x, "
+                     "rs_id=%04x)\n", sei_area->rs, sei_area->rsid);
+       if (sei_area->rs != 4)
+               return 0;
+       chp_id_init(&chpid);
+       chpid.id = sei_area->rsid;
+       /* allocate a new channel path structure, if needed */
+       status = chp_get_status(chpid);
+       if (status < 0)
+               chp_new(chpid);
+       else if (!status)
+               return 0;
+       memset(&res_data, 0, sizeof(struct res_acc_data));
+       res_data.chpid = chpid;
+       if ((sei_area->vf & 0xc0) != 0) {
+               res_data.fla = sei_area->fla;
+               if ((sei_area->vf & 0xc0) == 0xc0)
+                       /* full link address */
+                       res_data.fla_mask = 0xffff;
+               else
+                       /* link address */
+                       res_data.fla_mask = 0xff00;
+       }
+       rc = s390_process_res_acc(&res_data);
+
+       return rc;
+}
+
+static int chsc_process_sei(struct chsc_sei_area *sei_area)
+{
+       int rc;
+
+       /* Check if we might have lost some information. */
+       if (sei_area->flags & 0x40)
+               CIO_CRW_EVENT(2, "chsc: event overflow\n");
+       /* which kind of information was stored? */
+       rc = 0;
+       switch (sei_area->cc) {
+       case 1: /* link incident*/
+               rc = chsc_process_sei_link_incident(sei_area);
+               break;
+       case 2: /* i/o resource accessibiliy */
+               rc = chsc_process_sei_res_acc(sei_area);
+               break;
+       default: /* other stuff */
+               CIO_CRW_EVENT(4, "chsc: unhandled sei content code %d\n",
+                             sei_area->cc);
+               break;
+       }
+
+       return rc;
+}
+
+int chsc_process_crw(void)
+{
+       struct chsc_sei_area *sei_area;
+       int ret;
+       int rc;
 
        if (!sei_page)
                return 0;
-       /*
-        * build the chsc request block for store event information
-        * and do the call
-        * This function is only called by the machine check handler thread,
-        * so we don't need locking for the sei_page.
-        */
+       /* Access to sei_page is serialized through machine check handler
+        * thread, so no need for locking. */
        sei_area = sei_page;
 
        CIO_TRACE_EVENT( 2, "prcss");
        ret = 0;
        do {
-               int ccode, status;
-               struct device *dev;
                memset(sei_area, 0, sizeof(*sei_area));
-               memset(&res_data, 0, sizeof(struct res_acc_data));
                sei_area->request.length = 0x0010;
                sei_area->request.code = 0x000e;
+               if (chsc(sei_area))
+                       break;
 
-               ccode = chsc(sei_area);
-               if (ccode > 0)
-                       return 0;
-
-               switch (sei_area->response.code) {
-                       /* for debug purposes, check for problems */
-               case 0x0001:
-                       CIO_CRW_EVENT(4, "chsc_process_crw: event information "
-                                       "successfully stored\n");
-                       break; /* everything ok */
-               case 0x0002:
-                       CIO_CRW_EVENT(2,
-                                     "chsc_process_crw: invalid command!\n");
-                       return 0;
-               case 0x0003:
-                       CIO_CRW_EVENT(2, "chsc_process_crw: error in chsc "
-                                     "request block!\n");
-                       return 0;
-               case 0x0005:
-                       CIO_CRW_EVENT(2, "chsc_process_crw: no event "
-                                     "information stored\n");
-                       return 0;
-               default:
-                       CIO_CRW_EVENT(2, "chsc_process_crw: chsc response %d\n",
+               if (sei_area->response.code == 0x0001) {
+                       CIO_CRW_EVENT(4, "chsc: sei successful\n");
+                       rc = chsc_process_sei(sei_area);
+                       if (rc)
+                               ret = rc;
+               } else {
+                       CIO_CRW_EVENT(2, "chsc: sei failed (rc=%04x)\n",
                                      sei_area->response.code);
-                       return 0;
-               }
-
-               /* Check if we might have lost some information. */
-               if (sei_area->flags & 0x40)
-                       CIO_CRW_EVENT(2, "chsc_process_crw: Event information "
-                                      "has been lost due to overflow!\n");
-
-               if (sei_area->rs != 4) {
-                       CIO_CRW_EVENT(2, "chsc_process_crw: reporting source "
-                                     "(%04X) isn't a chpid!\n",
-                                     sei_area->rsid);
-                       continue;
-               }
-
-               /* which kind of information was stored? */
-               switch (sei_area->cc) {
-               case 1: /* link incident*/
-                       CIO_CRW_EVENT(4, "chsc_process_crw: "
-                                     "channel subsystem reports link incident,"
-                                     " reporting source is chpid %x\n",
-                                     sei_area->rsid);
-                       chpid = __get_chpid_from_lir(sei_area->ccdf);
-                       if (chpid < 0)
-                               CIO_CRW_EVENT(4, "%s: Invalid LIR, skipping\n",
-                                             __FUNCTION__);
-                       else
-                               s390_set_chpid_offline(chpid);
-                       break;
-                       
-               case 2: /* i/o resource accessibiliy */
-                       CIO_CRW_EVENT(4, "chsc_process_crw: "
-                                     "channel subsystem reports some I/O "
-                                     "devices may have become accessible\n");
-                       pr_debug("Data received after sei: \n");
-                       pr_debug("Validity flags: %x\n", sei_area->vf);
-                       
-                       /* allocate a new channel path structure, if needed */
-                       status = get_chp_status(sei_area->rsid);
-                       if (status < 0)
-                               new_channel_path(sei_area->rsid);
-                       else if (!status)
-                               break;
-                       dev = get_device(&css[0]->chps[sei_area->rsid]->dev);
-                       res_data.chp = to_channelpath(dev);
-                       pr_debug("chpid: %x", sei_area->rsid);
-                       if ((sei_area->vf & 0xc0) != 0) {
-                               res_data.fla = sei_area->fla;
-                               if ((sei_area->vf & 0xc0) == 0xc0) {
-                                       pr_debug(" full link addr: %x",
-                                                sei_area->fla);
-                                       res_data.fla_mask = 0xffff;
-                               } else {
-                                       pr_debug(" link addr: %x",
-                                                sei_area->fla);
-                                       res_data.fla_mask = 0xff00;
-                               }
-                       }
-                       ret = s390_process_res_acc(&res_data);
-                       pr_debug("\n\n");
-                       put_device(dev);
-                       break;
-                       
-               default: /* other stuff */
-                       CIO_CRW_EVENT(4, "chsc_process_crw: event %d\n",
-                                     sei_area->cc);
+                       ret = 0;
                        break;
                }
        } while (sei_area->flags & 0x80);
+
        return ret;
 }
 
-static inline int
+static int
 __chp_add_new_sch(struct subchannel_id schid)
 {
        struct schib schib;
        int ret;
 
-       if (stsch(schid, &schib))
+       if (stsch_err(schid, &schib))
                /* We're through */
                return need_rescan ? -EAGAIN : -ENXIO;
 
@@ -627,10 +585,10 @@ static int
 __chp_add(struct subchannel_id schid, void *data)
 {
        int i, mask;
-       struct channel_path *chp;
+       struct chp_id *chpid;
        struct subchannel *sch;
 
-       chp = data;
+       chpid = data;
        sch = get_subchannel_by_schid(schid);
        if (!sch)
                /* Check if the subchannel is now available. */
@@ -639,7 +597,7 @@ __chp_add(struct subchannel_id schid, void *data)
        for (i=0; i<8; i++) {
                mask = 0x80 >> i;
                if ((sch->schib.pmcw.pim & mask) &&
-                   (sch->schib.pmcw.chpid[i] == chp->id)) {
+                   (sch->schib.pmcw.chpid[i] == chpid->id)) {
                        if (stsch(sch->schid, &sch->schib) != 0) {
                                /* Endgame. */
                                spin_unlock_irq(sch->lock);
@@ -665,51 +623,25 @@ __chp_add(struct subchannel_id schid, void *data)
        return 0;
 }
 
-static int
-chp_add(int chpid)
+int chsc_chp_online(struct chp_id chpid)
 {
        int rc;
        char dbf_txt[15];
-       struct device *dev;
 
-       if (!get_chp_status(chpid))
-               return 0; /* no need to do the rest */
-       
-       sprintf(dbf_txt, "cadd%x", chpid);
+       sprintf(dbf_txt, "cadd%x.%02x", chpid.cssid, chpid.id);
        CIO_TRACE_EVENT(2, dbf_txt);
 
-       dev = get_device(&css[0]->chps[chpid]->dev);
-       rc = for_each_subchannel(__chp_add, to_channelpath(dev));
+       if (chp_get_status(chpid) == 0)
+               return 0;
+       rc = for_each_subchannel(__chp_add, &chpid);
        if (css_slow_subchannels_exist())
                rc = -EAGAIN;
        if (rc != -EAGAIN)
                rc = 0;
-       put_device(dev);
        return rc;
 }
 
-/* 
- * Handling of crw machine checks with channel path source.
- */
-int
-chp_process_crw(int chpid, int on)
-{
-       if (on == 0) {
-               /* Path has gone. We use the link incident routine.*/
-               s390_set_chpid_offline(chpid);
-               return 0; /* De-register is async anyway. */
-       }
-       /*
-        * Path has come. Allocate a new channel path structure,
-        * if needed.
-        */
-       if (get_chp_status(chpid) < 0)
-               new_channel_path(chpid);
-       /* Avoid the extra overhead in process_rec_acc. */
-       return chp_add(chpid);
-}
-
-static inline int check_for_io_on_path(struct subchannel *sch, int index)
+static int check_for_io_on_path(struct subchannel *sch, int index)
 {
        int cc;
 
@@ -741,8 +673,8 @@ static void terminate_internal_io(struct subchannel *sch)
                sch->driver->termination(&sch->dev);
 }
 
-static inline void
-__s390_subchannel_vary_chpid(struct subchannel *sch, __u8 chpid, int on)
+static void __s390_subchannel_vary_chpid(struct subchannel *sch,
+                                        struct chp_id chpid, int on)
 {
        int chp, old_lpm;
        unsigned long flags;
@@ -753,7 +685,7 @@ __s390_subchannel_vary_chpid(struct subchannel *sch, __u8 chpid, int on)
        spin_lock_irqsave(sch->lock, flags);
        old_lpm = sch->lpm;
        for (chp = 0; chp < 8; chp++) {
-               if (sch->ssd_info.chpid[chp] != chpid)
+               if (sch->ssd_info.chpid[chp] != chpid.id)
                        continue;
 
                if (on) {
@@ -788,11 +720,10 @@ __s390_subchannel_vary_chpid(struct subchannel *sch, __u8 chpid, int on)
        spin_unlock_irqrestore(sch->lock, flags);
 }
 
-static int
-s390_subchannel_vary_chpid_off(struct device *dev, void *data)
+static int s390_subchannel_vary_chpid_off(struct device *dev, void *data)
 {
        struct subchannel *sch;
-       __u8 *chpid;
+       struct chp_id *chpid;
 
        sch = to_subchannel(dev);
        chpid = data;
@@ -801,11 +732,10 @@ s390_subchannel_vary_chpid_off(struct device *dev, void *data)
        return 0;
 }
 
-static int
-s390_subchannel_vary_chpid_on(struct device *dev, void *data)
+static int s390_subchannel_vary_chpid_on(struct device *dev, void *data)
 {
        struct subchannel *sch;
-       __u8 *chpid;
+       struct chp_id *chpid;
 
        sch = to_subchannel(dev);
        chpid = data;
@@ -837,32 +767,13 @@ __s390_vary_chpid_on(struct subchannel_id schid, void *data)
        return 0;
 }
 
-/*
- * Function: s390_vary_chpid
- * Varies the specified chpid online or offline
+/**
+ * chsc_chp_vary - propagate channel-path vary operation to subchannels
+ * @chpid: channl-path ID
+ * @on: non-zero for vary online, zero for vary offline
  */
-static int
-s390_vary_chpid( __u8 chpid, int on)
+int chsc_chp_vary(struct chp_id chpid, int on)
 {
-       char dbf_text[15];
-       int status;
-
-       sprintf(dbf_text, on?"varyon%x":"varyoff%x", chpid);
-       CIO_TRACE_EVENT( 2, dbf_text);
-
-       status = get_chp_status(chpid);
-       if (status < 0) {
-               printk(KERN_ERR "Can't vary unknown chpid %02X\n", chpid);
-               return -EINVAL;
-       }
-
-       if (!on && !status) {
-               printk(KERN_ERR "chpid %x is already offline\n", chpid);
-               return -EINVAL;
-       }
-
-       set_chp_logically_online(chpid, on);
-
        /*
         * Redo PathVerification on the devices the chpid connects to
         */
@@ -878,113 +789,6 @@ s390_vary_chpid( __u8 chpid, int on)
        return 0;
 }
 
-/*
- * Channel measurement related functions
- */
-static ssize_t
-chp_measurement_chars_read(struct kobject *kobj, char *buf, loff_t off,
-                          size_t count)
-{
-       struct channel_path *chp;
-       unsigned int size;
-
-       chp = to_channelpath(container_of(kobj, struct device, kobj));
-       if (!chp->cmg_chars)
-               return 0;
-
-       size = sizeof(struct cmg_chars);
-
-       if (off > size)
-               return 0;
-       if (off + count > size)
-               count = size - off;
-       memcpy(buf, chp->cmg_chars + off, count);
-       return count;
-}
-
-static struct bin_attribute chp_measurement_chars_attr = {
-       .attr = {
-               .name = "measurement_chars",
-               .mode = S_IRUSR,
-               .owner = THIS_MODULE,
-       },
-       .size = sizeof(struct cmg_chars),
-       .read = chp_measurement_chars_read,
-};
-
-static void
-chp_measurement_copy_block(struct cmg_entry *buf,
-                          struct channel_subsystem *css, int chpid)
-{
-       void *area;
-       struct cmg_entry *entry, reference_buf;
-       int idx;
-
-       if (chpid < 128) {
-               area = css->cub_addr1;
-               idx = chpid;
-       } else {
-               area = css->cub_addr2;
-               idx = chpid - 128;
-       }
-       entry = area + (idx * sizeof(struct cmg_entry));
-       do {
-               memcpy(buf, entry, sizeof(*entry));
-               memcpy(&reference_buf, entry, sizeof(*entry));
-       } while (reference_buf.values[0] != buf->values[0]);
-}
-
-static ssize_t
-chp_measurement_read(struct kobject *kobj, char *buf, loff_t off, size_t count)
-{
-       struct channel_path *chp;
-       struct channel_subsystem *css;
-       unsigned int size;
-
-       chp = to_channelpath(container_of(kobj, struct device, kobj));
-       css = to_css(chp->dev.parent);
-
-       size = sizeof(struct cmg_entry);
-
-       /* Only allow single reads. */
-       if (off || count < size)
-               return 0;
-       chp_measurement_copy_block((struct cmg_entry *)buf, css, chp->id);
-       count = size;
-       return count;
-}
-
-static struct bin_attribute chp_measurement_attr = {
-       .attr = {
-               .name = "measurement",
-               .mode = S_IRUSR,
-               .owner = THIS_MODULE,
-       },
-       .size = sizeof(struct cmg_entry),
-       .read = chp_measurement_read,
-};
-
-static void
-chsc_remove_chp_cmg_attr(struct channel_path *chp)
-{
-       device_remove_bin_file(&chp->dev, &chp_measurement_chars_attr);
-       device_remove_bin_file(&chp->dev, &chp_measurement_attr);
-}
-
-static int
-chsc_add_chp_cmg_attr(struct channel_path *chp)
-{
-       int ret;
-
-       ret = device_create_bin_file(&chp->dev, &chp_measurement_chars_attr);
-       if (ret)
-               return ret;
-       ret = device_create_bin_file(&chp->dev, &chp_measurement_attr);
-       if (ret)
-               device_remove_bin_file(&chp->dev, &chp_measurement_chars_attr);
-       return ret;
-}
-
 static void
 chsc_remove_cmg_attr(struct channel_subsystem *css)
 {
@@ -993,7 +797,7 @@ chsc_remove_cmg_attr(struct channel_subsystem *css)
        for (i = 0; i <= __MAX_CHPID; i++) {
                if (!css->chps[i])
                        continue;
-               chsc_remove_chp_cmg_attr(css->chps[i]);
+               chp_remove_cmg_attr(css->chps[i]);
        }
 }
 
@@ -1006,7 +810,7 @@ chsc_add_cmg_attr(struct channel_subsystem *css)
        for (i = 0; i <= __MAX_CHPID; i++) {
                if (!css->chps[i])
                        continue;
-               ret = chsc_add_chp_cmg_attr(css->chps[i]);
+               ret = chp_add_cmg_attr(css->chps[i]);
                if (ret)
                        goto cleanup;
        }
@@ -1015,12 +819,11 @@ cleanup:
        for (--i; i >= 0; i--) {
                if (!css->chps[i])
                        continue;
-               chsc_remove_chp_cmg_attr(css->chps[i]);
+               chp_remove_cmg_attr(css->chps[i]);
        }
        return ret;
 }
 
-
 static int
 __chsc_do_secm(struct channel_subsystem *css, int enable, void *page)
 {
@@ -1040,7 +843,7 @@ __chsc_do_secm(struct channel_subsystem *css, int enable, void *page)
                u32 : 4;
                u32 fmt : 4;
                u32 : 16;
-       } *secm_area;
+       } __attribute__ ((packed)) *secm_area;
        int ret, ccode;
 
        secm_area = page;
@@ -1135,109 +938,8 @@ chsc_secm(struct channel_subsystem *css, int enable)
        return ret;
 }
 
-/*
- * Files for the channel path entries.
- */
-static ssize_t
-chp_status_show(struct device *dev, struct device_attribute *attr, char *buf)
-{
-       struct channel_path *chp = container_of(dev, struct channel_path, dev);
-
-       if (!chp)
-               return 0;
-       return (get_chp_status(chp->id) ? sprintf(buf, "online\n") :
-               sprintf(buf, "offline\n"));
-}
-
-static ssize_t
-chp_status_write(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)
-{
-       struct channel_path *cp = container_of(dev, struct channel_path, dev);
-       char cmd[10];
-       int num_args;
-       int error;
-
-       num_args = sscanf(buf, "%5s", cmd);
-       if (!num_args)
-               return count;
-
-       if (!strnicmp(cmd, "on", 2))
-               error = s390_vary_chpid(cp->id, 1);
-       else if (!strnicmp(cmd, "off", 3))
-               error = s390_vary_chpid(cp->id, 0);
-       else
-               error = -EINVAL;
-
-       return error < 0 ? error : count;
-
-}
-
-static DEVICE_ATTR(status, 0644, chp_status_show, chp_status_write);
-
-static ssize_t
-chp_type_show(struct device *dev, struct device_attribute *attr, char *buf)
-{
-       struct channel_path *chp = container_of(dev, struct channel_path, dev);
-
-       if (!chp)
-               return 0;
-       return sprintf(buf, "%x\n", chp->desc.desc);
-}
-
-static DEVICE_ATTR(type, 0444, chp_type_show, NULL);
-
-static ssize_t
-chp_cmg_show(struct device *dev, struct device_attribute *attr, char *buf)
-{
-       struct channel_path *chp = to_channelpath(dev);
-
-       if (!chp)
-               return 0;
-       if (chp->cmg == -1) /* channel measurements not available */
-               return sprintf(buf, "unknown\n");
-       return sprintf(buf, "%x\n", chp->cmg);
-}
-
-static DEVICE_ATTR(cmg, 0444, chp_cmg_show, NULL);
-
-static ssize_t
-chp_shared_show(struct device *dev, struct device_attribute *attr, char *buf)
-{
-       struct channel_path *chp = to_channelpath(dev);
-
-       if (!chp)
-               return 0;
-       if (chp->shared == -1) /* channel measurements not available */
-               return sprintf(buf, "unknown\n");
-       return sprintf(buf, "%x\n", chp->shared);
-}
-
-static DEVICE_ATTR(shared, 0444, chp_shared_show, NULL);
-
-static struct attribute * chp_attrs[] = {
-       &dev_attr_status.attr,
-       &dev_attr_type.attr,
-       &dev_attr_cmg.attr,
-       &dev_attr_shared.attr,
-       NULL,
-};
-
-static struct attribute_group chp_attr_group = {
-       .attrs = chp_attrs,
-};
-
-static void
-chp_release(struct device *dev)
-{
-       struct channel_path *cp;
-       
-       cp = container_of(dev, struct channel_path, dev);
-       kfree(cp);
-}
-
-static int
-chsc_determine_channel_path_description(int chpid,
-                                       struct channel_path_desc *desc)
+int chsc_determine_channel_path_description(struct chp_id chpid,
+                                           struct channel_path_desc *desc)
 {
        int ccode, ret;
 
@@ -1251,7 +953,7 @@ chsc_determine_channel_path_description(int chpid,
                struct chsc_header response;
                u32 zeroes2;
                struct channel_path_desc desc;
-       } *scpd_area;
+       } __attribute__ ((packed)) *scpd_area;
 
        scpd_area = (void *)get_zeroed_page(GFP_KERNEL | GFP_DMA);
        if (!scpd_area)
@@ -1260,8 +962,8 @@ chsc_determine_channel_path_description(int chpid,
        scpd_area->request.length = 0x0010;
        scpd_area->request.code = 0x0002;
 
-       scpd_area->first_chpid = chpid;
-       scpd_area->last_chpid = chpid;
+       scpd_area->first_chpid = chpid.id;
+       scpd_area->last_chpid = chpid.id;
 
        ccode = chsc(scpd_area);
        if (ccode > 0) {
@@ -1324,8 +1026,7 @@ chsc_initialize_cmg_chars(struct channel_path *chp, u8 cmcv,
        }
 }
 
-static int
-chsc_get_channel_measurement_chars(struct channel_path *chp)
+int chsc_get_channel_measurement_chars(struct channel_path *chp)
 {
        int ccode, ret;
 
@@ -1348,7 +1049,7 @@ chsc_get_channel_measurement_chars(struct channel_path *chp)
                u32 cmg : 8;
                u32 zeroes3;
                u32 data[NR_MEASUREMENT_CHARS];
-       } *scmc_area;
+       } __attribute__ ((packed)) *scmc_area;
 
        scmc_area = (void *)get_zeroed_page(GFP_KERNEL | GFP_DMA);
        if (!scmc_area)
@@ -1357,8 +1058,8 @@ chsc_get_channel_measurement_chars(struct channel_path *chp)
        scmc_area->request.length = 0x0010;
        scmc_area->request.code = 0x0022;
 
-       scmc_area->first_chpid = chp->id;
-       scmc_area->last_chpid = chp->id;
+       scmc_area->first_chpid = chp->chpid.id;
+       scmc_area->last_chpid = chp->chpid.id;
 
        ccode = chsc(scmc_area);
        if (ccode > 0) {
@@ -1400,94 +1101,6 @@ out:
        return ret;
 }
 
-/*
- * Entries for chpids on the system bus.
- * This replaces /proc/chpids.
- */
-static int
-new_channel_path(int chpid)
-{
-       struct channel_path *chp;
-       int ret;
-
-       chp = kzalloc(sizeof(struct channel_path), GFP_KERNEL);
-       if (!chp)
-               return -ENOMEM;
-
-       /* fill in status, etc. */
-       chp->id = chpid;
-       chp->state = 1;
-       chp->dev.parent = &css[0]->device;
-       chp->dev.release = chp_release;
-       snprintf(chp->dev.bus_id, BUS_ID_SIZE, "chp0.%x", chpid);
-
-       /* Obtain channel path description and fill it in. */
-       ret = chsc_determine_channel_path_description(chpid, &chp->desc);
-       if (ret)
-               goto out_free;
-       /* Get channel-measurement characteristics. */
-       if (css_characteristics_avail && css_chsc_characteristics.scmc
-           && css_chsc_characteristics.secm) {
-               ret = chsc_get_channel_measurement_chars(chp);
-               if (ret)
-                       goto out_free;
-       } else {
-               static int msg_done;
-
-               if (!msg_done) {
-                       printk(KERN_WARNING "cio: Channel measurements not "
-                              "available, continuing.\n");
-                       msg_done = 1;
-               }
-               chp->cmg = -1;
-       }
-
-       /* make it known to the system */
-       ret = device_register(&chp->dev);
-       if (ret) {
-               printk(KERN_WARNING "%s: could not register %02x\n",
-                      __func__, chpid);
-               goto out_free;
-       }
-       ret = sysfs_create_group(&chp->dev.kobj, &chp_attr_group);
-       if (ret) {
-               device_unregister(&chp->dev);
-               goto out_free;
-       }
-       mutex_lock(&css[0]->mutex);
-       if (css[0]->cm_enabled) {
-               ret = chsc_add_chp_cmg_attr(chp);
-               if (ret) {
-                       sysfs_remove_group(&chp->dev.kobj, &chp_attr_group);
-                       device_unregister(&chp->dev);
-                       mutex_unlock(&css[0]->mutex);
-                       goto out_free;
-               }
-       }
-       css[0]->chps[chpid] = chp;
-       mutex_unlock(&css[0]->mutex);
-       return ret;
-out_free:
-       kfree(chp);
-       return ret;
-}
-
-void *
-chsc_get_chp_desc(struct subchannel *sch, int chp_no)
-{
-       struct channel_path *chp;
-       struct channel_path_desc *desc;
-
-       chp = css[0]->chps[sch->schib.pmcw.chpid[chp_no]];
-       if (!chp)
-               return NULL;
-       desc = kmalloc(sizeof(struct channel_path_desc), GFP_KERNEL);
-       if (!desc)
-               return NULL;
-       memcpy(desc, &chp->desc, sizeof(struct channel_path_desc));
-       return desc;
-}
-
 static int __init
 chsc_alloc_sei_area(void)
 {
@@ -1515,7 +1128,7 @@ chsc_enable_facility(int operation_code)
                u32 reserved5:4;
                u32 format2:4;
                u32 reserved6:24;
-       } *sda_area;
+       } __attribute__ ((packed)) *sda_area;
 
        sda_area = (void *)get_zeroed_page(GFP_KERNEL|GFP_DMA);
        if (!sda_area)
@@ -1567,7 +1180,7 @@ chsc_determine_css_characteristics(void)
                u32 reserved4;
                u32 general_char[510];
                u32 chsc_char[518];
-       } *scsc_area;
+       } __attribute__ ((packed)) *scsc_area;
 
        scsc_area = (void *)get_zeroed_page(GFP_KERNEL | GFP_DMA);
        if (!scsc_area) {