]> err.no Git - linux-2.6/blobdiff - drivers/pnp/manager.c
PNP: remove redundant pnp_can_configure() check
[linux-2.6] / drivers / pnp / manager.c
index bea0914ff947a337dcf45d2a58bf7b6fc0f38644..7ea9e1e28003f110bc6e86145be9e7a6de9bf2bf 100644 (file)
@@ -19,82 +19,64 @@ DEFINE_MUTEX(pnp_res_mutex);
 
 static int pnp_assign_port(struct pnp_dev *dev, struct pnp_port *rule, int idx)
 {
-       struct pnp_resource *pnp_res;
-       struct resource *res;
-
-       pnp_res = pnp_get_pnp_resource(dev, IORESOURCE_IO, idx);
-       if (!pnp_res) {
-               dev_err(&dev->dev, "too many I/O port resources\n");
-               /* pretend we were successful so at least the manager won't try again */
-               return 1;
-       }
-
-       res = &pnp_res->res;
+       struct resource *res, local_res;
 
-       /* check if this resource has been manually set, if so skip */
-       if (!(res->flags & IORESOURCE_AUTO)) {
+       res = pnp_get_resource(dev, IORESOURCE_IO, idx);
+       if (res) {
                dev_dbg(&dev->dev, "  io %d already set to %#llx-%#llx "
                        "flags %#lx\n", idx, (unsigned long long) res->start,
                        (unsigned long long) res->end, res->flags);
-               return 1;
+               return 0;
        }
 
-       /* set the initial values */
-       pnp_res->index = idx;
-       res->flags |= rule->flags | IORESOURCE_IO;
-       res->flags &= ~IORESOURCE_UNSET;
+       res = &local_res;
+       res->flags = rule->flags | IORESOURCE_AUTO;
+       res->start = 0;
+       res->end = 0;
 
        if (!rule->size) {
                res->flags |= IORESOURCE_DISABLED;
                dev_dbg(&dev->dev, "  io %d disabled\n", idx);
-               return 1;       /* skip disabled resource requests */
+               goto __add;
        }
 
        res->start = rule->min;
        res->end = res->start + rule->size - 1;
 
-       /* run through until pnp_check_port is happy */
        while (!pnp_check_port(dev, res)) {
                res->start += rule->align;
                res->end = res->start + rule->size - 1;
                if (res->start > rule->max || !rule->align) {
-                       dev_dbg(&dev->dev, "  couldn't assign io %d\n", idx);
-                       return 0;
+                       dev_dbg(&dev->dev, "  couldn't assign io %d "
+                               "(min %#llx max %#llx)\n", idx,
+                               (unsigned long long) rule->min,
+                               (unsigned long long) rule->max);
+                       return -EBUSY;
                }
        }
-       dev_dbg(&dev->dev, "  assign io  %d %#llx-%#llx\n", idx,
-               (unsigned long long) res->start, (unsigned long long) res->end);
-       return 1;
+
+__add:
+       pnp_add_io_resource(dev, res->start, res->end, res->flags);
+       return 0;
 }
 
 static int pnp_assign_mem(struct pnp_dev *dev, struct pnp_mem *rule, int idx)
 {
-       struct pnp_resource *pnp_res;
-       struct resource *res;
-
-       pnp_res = pnp_get_pnp_resource(dev, IORESOURCE_MEM, idx);
-       if (!pnp_res) {
-               dev_err(&dev->dev, "too many memory resources\n");
-               /* pretend we were successful so at least the manager won't try again */
-               return 1;
-       }
-
-       res = &pnp_res->res;
+       struct resource *res, local_res;
 
-       /* check if this resource has been manually set, if so skip */
-       if (!(res->flags & IORESOURCE_AUTO)) {
+       res = pnp_get_resource(dev, IORESOURCE_MEM, idx);
+       if (res) {
                dev_dbg(&dev->dev, "  mem %d already set to %#llx-%#llx "
                        "flags %#lx\n", idx, (unsigned long long) res->start,
                        (unsigned long long) res->end, res->flags);
-               return 1;
+               return 0;
        }
 
-       /* set the initial values */
-       pnp_res->index = idx;
-       res->flags |= rule->flags | IORESOURCE_MEM;
-       res->flags &= ~IORESOURCE_UNSET;
+       res = &local_res;
+       res->flags = rule->flags | IORESOURCE_AUTO;
+       res->start = 0;
+       res->end = 0;
 
-       /* convert pnp flags to standard Linux flags */
        if (!(rule->flags & IORESOURCE_MEM_WRITEABLE))
                res->flags |= IORESOURCE_READONLY;
        if (rule->flags & IORESOURCE_MEM_CACHEABLE)
@@ -107,30 +89,32 @@ static int pnp_assign_mem(struct pnp_dev *dev, struct pnp_mem *rule, int idx)
        if (!rule->size) {
                res->flags |= IORESOURCE_DISABLED;
                dev_dbg(&dev->dev, "  mem %d disabled\n", idx);
-               return 1;       /* skip disabled resource requests */
+               goto __add;
        }
 
        res->start = rule->min;
        res->end = res->start + rule->size - 1;
 
-       /* run through until pnp_check_mem is happy */
        while (!pnp_check_mem(dev, res)) {
                res->start += rule->align;
                res->end = res->start + rule->size - 1;
                if (res->start > rule->max || !rule->align) {
-                       dev_dbg(&dev->dev, "  couldn't assign mem %d\n", idx);
-                       return 0;
+                       dev_dbg(&dev->dev, "  couldn't assign mem %d "
+                               "(min %#llx max %#llx)\n", idx,
+                               (unsigned long long) rule->min,
+                               (unsigned long long) rule->max);
+                       return -EBUSY;
                }
        }
-       dev_dbg(&dev->dev, "  assign mem %d %#llx-%#llx\n", idx,
-               (unsigned long long) res->start, (unsigned long long) res->end);
-       return 1;
+
+__add:
+       pnp_add_mem_resource(dev, res->start, res->end, res->flags);
+       return 0;
 }
 
 static int pnp_assign_irq(struct pnp_dev *dev, struct pnp_irq *rule, int idx)
 {
-       struct pnp_resource *pnp_res;
-       struct resource *res;
+       struct resource *res, local_res;
        int i;
 
        /* IRQ priority: this table is good for i386 */
@@ -138,59 +122,48 @@ static int pnp_assign_irq(struct pnp_dev *dev, struct pnp_irq *rule, int idx)
                5, 10, 11, 12, 9, 14, 15, 7, 3, 4, 13, 0, 1, 6, 8, 2
        };
 
-       pnp_res = pnp_get_pnp_resource(dev, IORESOURCE_IRQ, idx);
-       if (!pnp_res) {
-               dev_err(&dev->dev, "too many IRQ resources\n");
-               /* pretend we were successful so at least the manager won't try again */
-               return 1;
-       }
-
-       res = &pnp_res->res;
-
-       /* check if this resource has been manually set, if so skip */
-       if (!(res->flags & IORESOURCE_AUTO)) {
+       res = pnp_get_resource(dev, IORESOURCE_IRQ, idx);
+       if (res) {
                dev_dbg(&dev->dev, "  irq %d already set to %d flags %#lx\n",
                        idx, (int) res->start, res->flags);
-               return 1;
+               return 0;
        }
 
-       /* set the initial values */
-       pnp_res->index = idx;
-       res->flags |= rule->flags | IORESOURCE_IRQ;
-       res->flags &= ~IORESOURCE_UNSET;
+       res = &local_res;
+       res->flags = rule->flags | IORESOURCE_AUTO;
+       res->start = -1;
+       res->end = -1;
 
-       if (bitmap_empty(rule->map, PNP_IRQ_NR)) {
+       if (bitmap_empty(rule->map.bits, PNP_IRQ_NR)) {
                res->flags |= IORESOURCE_DISABLED;
                dev_dbg(&dev->dev, "  irq %d disabled\n", idx);
-               return 1;       /* skip disabled resource requests */
+               goto __add;
        }
 
        /* TBD: need check for >16 IRQ */
-       res->start = find_next_bit(rule->map, PNP_IRQ_NR, 16);
+       res->start = find_next_bit(rule->map.bits, PNP_IRQ_NR, 16);
        if (res->start < PNP_IRQ_NR) {
                res->end = res->start;
-               dev_dbg(&dev->dev, "  assign irq %d %d\n", idx,
-                       (int) res->start);
-               return 1;
+               goto __add;
        }
        for (i = 0; i < 16; i++) {
-               if (test_bit(xtab[i], rule->map)) {
+               if (test_bit(xtab[i], rule->map.bits)) {
                        res->start = res->end = xtab[i];
-                       if (pnp_check_irq(dev, res)) {
-                               dev_dbg(&dev->dev, "  assign irq %d %d\n", idx,
-                                       (int) res->start);
-                               return 1;
-                       }
+                       if (pnp_check_irq(dev, res))
+                               goto __add;
                }
        }
        dev_dbg(&dev->dev, "  couldn't assign irq %d\n", idx);
+       return -EBUSY;
+
+__add:
+       pnp_add_irq_resource(dev, res->start, res->flags);
        return 0;
 }
 
-static void pnp_assign_dma(struct pnp_dev *dev, struct pnp_dma *rule, int idx)
+static int pnp_assign_dma(struct pnp_dev *dev, struct pnp_dma *rule, int idx)
 {
-       struct pnp_resource *pnp_res;
-       struct resource *res;
+       struct resource *res, local_res;
        int i;
 
        /* DMA priority: this table is good for i386 */
@@ -198,128 +171,48 @@ static void pnp_assign_dma(struct pnp_dev *dev, struct pnp_dma *rule, int idx)
                1, 3, 5, 6, 7, 0, 2, 4
        };
 
-       pnp_res = pnp_get_pnp_resource(dev, IORESOURCE_DMA, idx);
-       if (!pnp_res) {
-               dev_err(&dev->dev, "too many DMA resources\n");
-               return;
-       }
-
-       res = &pnp_res->res;
-
-       /* check if this resource has been manually set, if so skip */
-       if (!(res->flags & IORESOURCE_AUTO)) {
+       res = pnp_get_resource(dev, IORESOURCE_DMA, idx);
+       if (res) {
                dev_dbg(&dev->dev, "  dma %d already set to %d flags %#lx\n",
                        idx, (int) res->start, res->flags);
-               return;
+               return 0;
        }
 
-       /* set the initial values */
-       pnp_res->index = idx;
-       res->flags |= rule->flags | IORESOURCE_DMA;
-       res->flags &= ~IORESOURCE_UNSET;
+       res = &local_res;
+       res->flags = rule->flags | IORESOURCE_AUTO;
+       res->start = -1;
+       res->end = -1;
 
        for (i = 0; i < 8; i++) {
                if (rule->map & (1 << xtab[i])) {
                        res->start = res->end = xtab[i];
-                       if (pnp_check_dma(dev, res)) {
-                               dev_dbg(&dev->dev, "  assign dma %d %d\n", idx,
-                                       (int) res->start);
-                               return;
-                       }
+                       if (pnp_check_dma(dev, res))
+                               goto __add;
                }
        }
 #ifdef MAX_DMA_CHANNELS
        res->start = res->end = MAX_DMA_CHANNELS;
 #endif
-       res->flags |= IORESOURCE_UNSET | IORESOURCE_DISABLED;
+       res->flags |= IORESOURCE_DISABLED;
        dev_dbg(&dev->dev, "  disable dma %d\n", idx);
-}
-
-void pnp_init_resource(struct resource *res)
-{
-       unsigned long type;
-
-       type = res->flags & (IORESOURCE_IO  | IORESOURCE_MEM |
-                            IORESOURCE_IRQ | IORESOURCE_DMA);
 
-       res->name = NULL;
-       res->flags = type | IORESOURCE_AUTO | IORESOURCE_UNSET;
-       if (type == IORESOURCE_IRQ || type == IORESOURCE_DMA) {
-               res->start = -1;
-               res->end = -1;
-       } else {
-               res->start = 0;
-               res->end = 0;
-       }
+__add:
+       pnp_add_dma_resource(dev, res->start, res->flags);
+       return 0;
 }
 
-/**
- * pnp_init_resources - Resets a resource table to default values.
- * @table: pointer to the desired resource table
- */
 void pnp_init_resources(struct pnp_dev *dev)
 {
-       struct resource *res;
-       int idx;
-
-       for (idx = 0; idx < PNP_MAX_IRQ; idx++) {
-               res = &dev->res->irq[idx].res;
-               res->flags = IORESOURCE_IRQ;
-               pnp_init_resource(res);
-       }
-       for (idx = 0; idx < PNP_MAX_DMA; idx++) {
-               res = &dev->res->dma[idx].res;
-               res->flags = IORESOURCE_DMA;
-               pnp_init_resource(res);
-       }
-       for (idx = 0; idx < PNP_MAX_PORT; idx++) {
-               res = &dev->res->port[idx].res;
-               res->flags = IORESOURCE_IO;
-               pnp_init_resource(res);
-       }
-       for (idx = 0; idx < PNP_MAX_MEM; idx++) {
-               res = &dev->res->mem[idx].res;
-               res->flags = IORESOURCE_MEM;
-               pnp_init_resource(res);
-       }
+       pnp_free_resources(dev);
 }
 
-/**
- * pnp_clean_resources - clears resources that were not manually set
- * @res: the resources to clean
- */
 static void pnp_clean_resource_table(struct pnp_dev *dev)
 {
-       struct resource *res;
-       int idx;
-
-       for (idx = 0; idx < PNP_MAX_IRQ; idx++) {
-               res = &dev->res->irq[idx].res;
-               if (res->flags & IORESOURCE_AUTO) {
-                       res->flags = IORESOURCE_IRQ;
-                       pnp_init_resource(res);
-               }
-       }
-       for (idx = 0; idx < PNP_MAX_DMA; idx++) {
-               res = &dev->res->dma[idx].res;
-               if (res->flags & IORESOURCE_AUTO) {
-                       res->flags = IORESOURCE_DMA;
-                       pnp_init_resource(res);
-               }
-       }
-       for (idx = 0; idx < PNP_MAX_PORT; idx++) {
-               res = &dev->res->port[idx].res;
-               if (res->flags & IORESOURCE_AUTO) {
-                       res->flags = IORESOURCE_IO;
-                       pnp_init_resource(res);
-               }
-       }
-       for (idx = 0; idx < PNP_MAX_MEM; idx++) {
-               res = &dev->res->mem[idx].res;
-               if (res->flags & IORESOURCE_AUTO) {
-                       res->flags = IORESOURCE_MEM;
-                       pnp_init_resource(res);
-               }
+       struct pnp_resource *pnp_res, *tmp;
+
+       list_for_each_entry_safe(pnp_res, tmp, &dev->resources, list) {
+               if (pnp_res->res.flags & IORESOURCE_AUTO)
+                       pnp_free_resource(pnp_res);
        }
 }
 
@@ -338,9 +231,6 @@ static int pnp_assign_resources(struct pnp_dev *dev, int depnum)
        struct pnp_dma *dma;
        int nport = 0, nmem = 0, nirq = 0, ndma = 0;
 
-       if (!pnp_can_configure(dev))
-               return -ENODEV;
-
        dbg_pnp_show_resources(dev, "before pnp_assign_resources");
        mutex_lock(&pnp_res_mutex);
        pnp_clean_resource_table(dev);
@@ -351,25 +241,26 @@ static int pnp_assign_resources(struct pnp_dev *dev, int depnum)
                irq = dev->independent->irq;
                dma = dev->independent->dma;
                while (port) {
-                       if (!pnp_assign_port(dev, port, nport))
+                       if (pnp_assign_port(dev, port, nport) < 0)
                                goto fail;
                        nport++;
                        port = port->next;
                }
                while (mem) {
-                       if (!pnp_assign_mem(dev, mem, nmem))
+                       if (pnp_assign_mem(dev, mem, nmem) < 0)
                                goto fail;
                        nmem++;
                        mem = mem->next;
                }
                while (irq) {
-                       if (!pnp_assign_irq(dev, irq, nirq))
+                       if (pnp_assign_irq(dev, irq, nirq) < 0)
                                goto fail;
                        nirq++;
                        irq = irq->next;
                }
                while (dma) {
-                       pnp_assign_dma(dev, dma, ndma);
+                       if (pnp_assign_dma(dev, dma, ndma) < 0)
+                               goto fail;
                        ndma++;
                        dma = dma->next;
                }
@@ -389,25 +280,26 @@ static int pnp_assign_resources(struct pnp_dev *dev, int depnum)
                irq = dep->irq;
                dma = dep->dma;
                while (port) {
-                       if (!pnp_assign_port(dev, port, nport))
+                       if (pnp_assign_port(dev, port, nport) < 0)
                                goto fail;
                        nport++;
                        port = port->next;
                }
                while (mem) {
-                       if (!pnp_assign_mem(dev, mem, nmem))
+                       if (pnp_assign_mem(dev, mem, nmem) < 0)
                                goto fail;
                        nmem++;
                        mem = mem->next;
                }
                while (irq) {
-                       if (!pnp_assign_irq(dev, irq, nirq))
+                       if (pnp_assign_irq(dev, irq, nirq) < 0)
                                goto fail;
                        nirq++;
                        irq = irq->next;
                }
                while (dma) {
-                       pnp_assign_dma(dev, dma, ndma);
+                       if (pnp_assign_dma(dev, dma, ndma) < 0)
+                               goto fail;
                        ndma++;
                        dma = dma->next;
                }