]> err.no Git - linux-2.6/blobdiff - drivers/net/mv643xx_eth.c
V4L/DVB (7849): cx88: fix Kconfig depencencies for FW_LOADER
[linux-2.6] / drivers / net / mv643xx_eth.c
index b31844cb1ab49f776e8dcef6a780b202947b6e58..b7915cdcc6a504efc2ee422f3e29a77d37d72532 100644 (file)
@@ -3,7 +3,8 @@
  * Copyright (C) 2002 Matthew Dharm <mdharm@momenco.com>
  *
  * Based on the 64360 driver from:
- * Copyright (C) 2002 rabeeh@galileo.co.il
+ * Copyright (C) 2002 Rabeeh Khoury <rabeeh@galileo.co.il>
+ *                   Rabeeh Khoury <rabeeh@marvell.com>
  *
  * Copyright (C) 2003 PMC-Sierra, Inc.,
  *     written by Manish Lachwani
@@ -16,6 +17,9 @@
  * Copyright (C) 2004 Steven J. Hill <sjhill1@rockwellcollins.com>
  *                                  <sjhill@realitydiluted.com>
  *
+ * Copyright (C) 2007-2008 Marvell Semiconductor
+ *                        Lennert Buytenhek <buytenh@marvell.com>
+ *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
  * as published by the Free Software Foundation; either version 2
  */
 #define PHY_ADDR_REG                           0x0000
 #define SMI_REG                                        0x0004
+#define WINDOW_BASE(i)                         (0x0200 + ((i) << 3))
+#define WINDOW_SIZE(i)                         (0x0204 + ((i) << 3))
+#define WINDOW_REMAP_HIGH(i)                   (0x0280 + ((i) << 2))
+#define WINDOW_BAR_ENABLE                      0x0290
+#define WINDOW_PROTECT(i)                      (0x0294 + ((i) << 4))
 
 /*
  * Per-port registers.
@@ -503,9 +512,23 @@ struct mv643xx_mib_counters {
        u32 late_collision;
 };
 
+struct mv643xx_shared_private {
+       void __iomem *eth_base;
+
+       /* used to protect SMI_REG, which is shared across ports */
+       spinlock_t phy_lock;
+
+       u32 win_protect;
+
+       unsigned int t_clk;
+};
+
 struct mv643xx_private {
+       struct mv643xx_shared_private *shared;
        int port_num;                   /* User Ethernet port number    */
 
+       struct mv643xx_shared_private *shared_smi;
+
        u32 rx_sram_addr;               /* Base address of rx sram area */
        u32 rx_sram_size;               /* Size of rx sram area         */
        u32 tx_sram_addr;               /* Base address of tx sram area */
@@ -610,19 +633,14 @@ static const struct ethtool_ops mv643xx_ethtool_ops;
 static char mv643xx_driver_name[] = "mv643xx_eth";
 static char mv643xx_driver_version[] = "1.0";
 
-static void __iomem *mv643xx_eth_base;
-
-/* used to protect SMI_REG, which is shared across ports */
-static DEFINE_SPINLOCK(mv643xx_eth_phy_lock);
-
-static inline u32 mv_read(int offset)
+static inline u32 rdl(struct mv643xx_private *mp, int offset)
 {
-       return readl(mv643xx_eth_base + offset);
+       return readl(mp->shared->eth_base + offset);
 }
 
-static inline void mv_write(int offset, u32 data)
+static inline void wrl(struct mv643xx_private *mp, int offset, u32 data)
 {
-       writel(data, mv643xx_eth_base + offset);
+       writel(data, mp->shared->eth_base + offset);
 }
 
 /*
@@ -746,12 +764,12 @@ static void mv643xx_eth_set_rx_mode(struct net_device *dev)
        struct mv643xx_private *mp = netdev_priv(dev);
        u32 config_reg;
 
-       config_reg = mv_read(PORT_CONFIG_REG(mp->port_num));
+       config_reg = rdl(mp, PORT_CONFIG_REG(mp->port_num));
        if (dev->flags & IFF_PROMISC)
                config_reg |= (u32) UNICAST_PROMISCUOUS_MODE;
        else
                config_reg &= ~(u32) UNICAST_PROMISCUOUS_MODE;
-       mv_write(PORT_CONFIG_REG(mp->port_num), config_reg);
+       wrl(mp, PORT_CONFIG_REG(mp->port_num), config_reg);
 
        eth_port_set_multicast_list(dev);
 }
@@ -987,7 +1005,7 @@ static void mv643xx_eth_update_pscr(struct net_device *dev,
        u32 o_pscr, n_pscr;
        unsigned int queues;
 
-       o_pscr = mv_read(PORT_SERIAL_CONTROL_REG(port_num));
+       o_pscr = rdl(mp, PORT_SERIAL_CONTROL_REG(port_num));
        n_pscr = o_pscr;
 
        /* clear speed, duplex and rx buffer size fields */
@@ -1010,14 +1028,14 @@ static void mv643xx_eth_update_pscr(struct net_device *dev,
 
        if (n_pscr != o_pscr) {
                if ((o_pscr & SERIAL_PORT_ENABLE) == 0)
-                       mv_write(PORT_SERIAL_CONTROL_REG(port_num), n_pscr);
+                       wrl(mp, PORT_SERIAL_CONTROL_REG(port_num), n_pscr);
                else {
                        queues = mv643xx_eth_port_disable_tx(mp);
 
                        o_pscr &= ~SERIAL_PORT_ENABLE;
-                       mv_write(PORT_SERIAL_CONTROL_REG(port_num), o_pscr);
-                       mv_write(PORT_SERIAL_CONTROL_REG(port_num), n_pscr);
-                       mv_write(PORT_SERIAL_CONTROL_REG(port_num), n_pscr);
+                       wrl(mp, PORT_SERIAL_CONTROL_REG(port_num), o_pscr);
+                       wrl(mp, PORT_SERIAL_CONTROL_REG(port_num), n_pscr);
+                       wrl(mp, PORT_SERIAL_CONTROL_REG(port_num), n_pscr);
                        if (queues)
                                mv643xx_eth_port_enable_tx(mp, queues);
                }
@@ -1043,13 +1061,13 @@ static irqreturn_t mv643xx_eth_int_handler(int irq, void *dev_id)
        unsigned int port_num = mp->port_num;
 
        /* Read interrupt cause registers */
-       eth_int_cause = mv_read(INTERRUPT_CAUSE_REG(port_num)) &
+       eth_int_cause = rdl(mp, INTERRUPT_CAUSE_REG(port_num)) &
                                                ETH_INT_UNMASK_ALL;
        if (eth_int_cause & ETH_INT_CAUSE_EXT) {
-               eth_int_cause_ext = mv_read(
+               eth_int_cause_ext = rdl(mp,
                        INTERRUPT_CAUSE_EXTEND_REG(port_num)) &
                                                ETH_INT_UNMASK_ALL_EXT;
-               mv_write(INTERRUPT_CAUSE_EXTEND_REG(port_num),
+               wrl(mp, INTERRUPT_CAUSE_EXTEND_REG(port_num),
                                                        ~eth_int_cause_ext);
        }
 
@@ -1076,10 +1094,10 @@ static irqreturn_t mv643xx_eth_int_handler(int irq, void *dev_id)
 #ifdef MV643XX_NAPI
        if (eth_int_cause & ETH_INT_CAUSE_RX) {
                /* schedule the NAPI poll routine to maintain port */
-               mv_write(INTERRUPT_MASK_REG(port_num), ETH_INT_MASK_ALL);
+               wrl(mp, INTERRUPT_MASK_REG(port_num), ETH_INT_MASK_ALL);
 
                /* wait for previous write to complete */
-               mv_read(INTERRUPT_MASK_REG(port_num));
+               rdl(mp, INTERRUPT_MASK_REG(port_num));
 
                netif_rx_schedule(dev, &mp->napi);
        }
@@ -1115,7 +1133,6 @@ static irqreturn_t mv643xx_eth_int_handler(int irq, void *dev_id)
  *
  * INPUT:
  *     struct mv643xx_private *mp      Ethernet port
- *     unsigned int t_clk              t_clk of the MV-643xx chip in HZ units
  *     unsigned int delay              Delay in usec
  *
  * OUTPUT:
@@ -1126,15 +1143,15 @@ static irqreturn_t mv643xx_eth_int_handler(int irq, void *dev_id)
  *
  */
 static unsigned int eth_port_set_rx_coal(struct mv643xx_private *mp,
-                                       unsigned int t_clk, unsigned int delay)
+                                       unsigned int delay)
 {
        unsigned int port_num = mp->port_num;
-       unsigned int coal = ((t_clk / 1000000) * delay) / 64;
+       unsigned int coal = ((mp->shared->t_clk / 1000000) * delay) / 64;
 
        /* Set RX Coalescing mechanism */
-       mv_write(SDMA_CONFIG_REG(port_num),
+       wrl(mp, SDMA_CONFIG_REG(port_num),
                ((coal & 0x3fff) << 8) |
-               (mv_read(SDMA_CONFIG_REG(port_num))
+               (rdl(mp, SDMA_CONFIG_REG(port_num))
                        & 0xffc000ff));
 
        return coal;
@@ -1154,7 +1171,6 @@ static unsigned int eth_port_set_rx_coal(struct mv643xx_private *mp,
  *
  * INPUT:
  *     struct mv643xx_private *mp      Ethernet port
- *     unsigned int t_clk              t_clk of the MV-643xx chip in HZ units
  *     unsigned int delay              Delay in uSeconds
  *
  * OUTPUT:
@@ -1165,12 +1181,12 @@ static unsigned int eth_port_set_rx_coal(struct mv643xx_private *mp,
  *
  */
 static unsigned int eth_port_set_tx_coal(struct mv643xx_private *mp,
-                                       unsigned int t_clk, unsigned int delay)
+                                       unsigned int delay)
 {
-       unsigned int coal = ((t_clk / 1000000) * delay) / 64;
+       unsigned int coal = ((mp->shared->t_clk / 1000000) * delay) / 64;
 
        /* Set TX Coalescing mechanism */
-       mv_write(TX_FIFO_URGENT_THRESHOLD_REG(mp->port_num), coal << 4);
+       wrl(mp, TX_FIFO_URGENT_THRESHOLD_REG(mp->port_num), coal << 4);
 
        return coal;
 }
@@ -1307,16 +1323,15 @@ static int mv643xx_eth_open(struct net_device *dev)
        int err;
 
        /* Clear any pending ethernet port interrupts */
-       mv_write(INTERRUPT_CAUSE_REG(port_num), 0);
-       mv_write(INTERRUPT_CAUSE_EXTEND_REG(port_num), 0);
+       wrl(mp, INTERRUPT_CAUSE_REG(port_num), 0);
+       wrl(mp, INTERRUPT_CAUSE_EXTEND_REG(port_num), 0);
        /* wait for previous write to complete */
-       mv_read (INTERRUPT_CAUSE_EXTEND_REG(port_num));
+       rdl(mp, INTERRUPT_CAUSE_EXTEND_REG(port_num));
 
        err = request_irq(dev->irq, mv643xx_eth_int_handler,
                        IRQF_SHARED | IRQF_SAMPLE_RANDOM, dev->name, dev);
        if (err) {
-               printk(KERN_ERR "Can not assign IRQ number to MV643XX_eth%d\n",
-                                                               port_num);
+               printk(KERN_ERR "%s: Can not assign IRQ\n", dev->name);
                return -EAGAIN;
        }
 
@@ -1410,17 +1425,17 @@ static int mv643xx_eth_open(struct net_device *dev)
 
 #ifdef MV643XX_COAL
        mp->rx_int_coal =
-               eth_port_set_rx_coal(mp, 133000000, MV643XX_RX_COAL);
+               eth_port_set_rx_coal(mp, MV643XX_RX_COAL);
 #endif
 
        mp->tx_int_coal =
-               eth_port_set_tx_coal(mp, 133000000, MV643XX_TX_COAL);
+               eth_port_set_tx_coal(mp, MV643XX_TX_COAL);
 
        /* Unmask phy and link status changes interrupts */
-       mv_write(INTERRUPT_EXTEND_MASK_REG(port_num), ETH_INT_UNMASK_ALL_EXT);
+       wrl(mp, INTERRUPT_EXTEND_MASK_REG(port_num), ETH_INT_UNMASK_ALL_EXT);
 
        /* Unmask RX buffer and TX end interrupt */
-       mv_write(INTERRUPT_MASK_REG(port_num), ETH_INT_UNMASK_ALL);
+       wrl(mp, INTERRUPT_MASK_REG(port_num), ETH_INT_UNMASK_ALL);
 
        return 0;
 
@@ -1499,9 +1514,9 @@ static int mv643xx_eth_stop(struct net_device *dev)
        unsigned int port_num = mp->port_num;
 
        /* Mask all interrupts on ethernet port */
-       mv_write(INTERRUPT_MASK_REG(port_num), ETH_INT_MASK_ALL);
+       wrl(mp, INTERRUPT_MASK_REG(port_num), ETH_INT_MASK_ALL);
        /* wait for previous write to complete */
-       mv_read(INTERRUPT_MASK_REG(port_num));
+       rdl(mp, INTERRUPT_MASK_REG(port_num));
 
 #ifdef MV643XX_NAPI
        napi_disable(&mp->napi);
@@ -1540,15 +1555,15 @@ static int mv643xx_poll(struct napi_struct *napi, int budget)
 #endif
 
        work_done = 0;
-       if ((mv_read(RX_CURRENT_QUEUE_DESC_PTR_0(port_num)))
+       if ((rdl(mp, RX_CURRENT_QUEUE_DESC_PTR_0(port_num)))
            != (u32) mp->rx_used_desc_q)
                work_done = mv643xx_eth_receive_queue(dev, budget);
 
        if (work_done < budget) {
                netif_rx_complete(dev, napi);
-               mv_write(INTERRUPT_CAUSE_REG(port_num), 0);
-               mv_write(INTERRUPT_CAUSE_EXTEND_REG(port_num), 0);
-               mv_write(INTERRUPT_MASK_REG(port_num), ETH_INT_UNMASK_ALL);
+               wrl(mp, INTERRUPT_CAUSE_REG(port_num), 0);
+               wrl(mp, INTERRUPT_CAUSE_EXTEND_REG(port_num), 0);
+               wrl(mp, INTERRUPT_MASK_REG(port_num), ETH_INT_UNMASK_ALL);
        }
 
        return work_done;
@@ -1754,13 +1769,13 @@ static void mv643xx_netpoll(struct net_device *netdev)
        struct mv643xx_private *mp = netdev_priv(netdev);
        int port_num = mp->port_num;
 
-       mv_write(INTERRUPT_MASK_REG(port_num), ETH_INT_MASK_ALL);
+       wrl(mp, INTERRUPT_MASK_REG(port_num), ETH_INT_MASK_ALL);
        /* wait for previous write to complete */
-       mv_read(INTERRUPT_MASK_REG(port_num));
+       rdl(mp, INTERRUPT_MASK_REG(port_num));
 
        mv643xx_eth_int_handler(netdev->irq, netdev);
 
-       mv_write(INTERRUPT_MASK_REG(port_num), ETH_INT_UNMASK_ALL);
+       wrl(mp, INTERRUPT_MASK_REG(port_num), ETH_INT_UNMASK_ALL);
 }
 #endif
 
@@ -1824,6 +1839,11 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
                return -ENODEV;
        }
 
+       if (pd->shared == NULL) {
+               printk(KERN_ERR "No mv643xx_eth_platform_data->shared\n");
+               return -ENODEV;
+       }
+
        dev = alloc_etherdev(sizeof(struct mv643xx_private));
        if (!dev)
                return -ENOMEM;
@@ -1874,8 +1894,16 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
 
        spin_lock_init(&mp->lock);
 
+       mp->shared = platform_get_drvdata(pd->shared);
        port_num = mp->port_num = pd->port_number;
 
+       if (mp->shared->win_protect)
+               wrl(mp, WINDOW_PROTECT(port_num), mp->shared->win_protect);
+
+       mp->shared_smi = mp->shared;
+       if (pd->shared_smi != NULL)
+               mp->shared_smi = platform_get_drvdata(pd->shared_smi);
+
        /* set default config values */
        eth_port_uc_addr_get(mp, dev->dev_addr);
        mp->rx_ring_size = PORT_DEFAULT_RECEIVE_QUEUE_SIZE;
@@ -1916,9 +1944,8 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
 
        err = ethernet_phy_detect(mp);
        if (err) {
-               pr_debug("MV643xx ethernet port %d: "
-                                       "No PHY detected at addr %d\n",
-                                       port_num, ethernet_phy_get(mp));
+               pr_debug("%s: No PHY detected at addr %d\n",
+                               dev->name, ethernet_phy_get(mp));
                goto out;
        }
 
@@ -1981,28 +2008,91 @@ static int mv643xx_eth_remove(struct platform_device *pdev)
        return 0;
 }
 
+static void mv643xx_eth_conf_mbus_windows(struct mv643xx_shared_private *msp,
+                                         struct mbus_dram_target_info *dram)
+{
+       void __iomem *base = msp->eth_base;
+       u32 win_enable;
+       u32 win_protect;
+       int i;
+
+       for (i = 0; i < 6; i++) {
+               writel(0, base + WINDOW_BASE(i));
+               writel(0, base + WINDOW_SIZE(i));
+               if (i < 4)
+                       writel(0, base + WINDOW_REMAP_HIGH(i));
+       }
+
+       win_enable = 0x3f;
+       win_protect = 0;
+
+       for (i = 0; i < dram->num_cs; i++) {
+               struct mbus_dram_window *cs = dram->cs + i;
+
+               writel((cs->base & 0xffff0000) |
+                       (cs->mbus_attr << 8) |
+                       dram->mbus_dram_target_id, base + WINDOW_BASE(i));
+               writel((cs->size - 1) & 0xffff0000, base + WINDOW_SIZE(i));
+
+               win_enable &= ~(1 << i);
+               win_protect |= 3 << (2 * i);
+       }
+
+       writel(win_enable, base + WINDOW_BAR_ENABLE);
+       msp->win_protect = win_protect;
+}
+
 static int mv643xx_eth_shared_probe(struct platform_device *pdev)
 {
+       static int mv643xx_version_printed = 0;
+       struct mv643xx_eth_shared_platform_data *pd = pdev->dev.platform_data;
+       struct mv643xx_shared_private *msp;
        struct resource *res;
+       int ret;
 
-       printk(KERN_NOTICE "MV-643xx 10/100/1000 Ethernet Driver\n");
+       if (!mv643xx_version_printed++)
+               printk(KERN_NOTICE "MV-643xx 10/100/1000 Ethernet Driver\n");
 
+       ret = -EINVAL;
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (res == NULL)
-               return -ENODEV;
+               goto out;
 
-       mv643xx_eth_base = ioremap(res->start, res->end - res->start + 1);
-       if (mv643xx_eth_base == NULL)
-               return -ENOMEM;
+       ret = -ENOMEM;
+       msp = kmalloc(sizeof(*msp), GFP_KERNEL);
+       if (msp == NULL)
+               goto out;
+       memset(msp, 0, sizeof(*msp));
+
+       msp->eth_base = ioremap(res->start, res->end - res->start + 1);
+       if (msp->eth_base == NULL)
+               goto out_free;
+
+       spin_lock_init(&msp->phy_lock);
+       msp->t_clk = (pd != NULL && pd->t_clk != 0) ? pd->t_clk : 133000000;
+
+       platform_set_drvdata(pdev, msp);
+
+       /*
+        * (Re-)program MBUS remapping windows if we are asked to.
+        */
+       if (pd != NULL && pd->dram != NULL)
+               mv643xx_eth_conf_mbus_windows(msp, pd->dram);
 
        return 0;
 
+out_free:
+       kfree(msp);
+out:
+       return ret;
 }
 
 static int mv643xx_eth_shared_remove(struct platform_device *pdev)
 {
-       iounmap(mv643xx_eth_base);
-       mv643xx_eth_base = NULL;
+       struct mv643xx_shared_private *msp = platform_get_drvdata(pdev);
+
+       iounmap(msp->eth_base);
+       kfree(msp);
 
        return 0;
 }
@@ -2014,8 +2104,8 @@ static void mv643xx_eth_shutdown(struct platform_device *pdev)
        unsigned int port_num = mp->port_num;
 
        /* Mask all interrupts on ethernet port */
-       mv_write(INTERRUPT_MASK_REG(port_num), 0);
-       mv_read (INTERRUPT_MASK_REG(port_num));
+       wrl(mp, INTERRUPT_MASK_REG(port_num), 0);
+       rdl(mp, INTERRUPT_MASK_REG(port_num));
 
        eth_port_reset(mp);
 }
@@ -2026,6 +2116,7 @@ static struct platform_driver mv643xx_eth_driver = {
        .shutdown = mv643xx_eth_shutdown,
        .driver = {
                .name = MV643XX_ETH_NAME,
+               .owner  = THIS_MODULE,
        },
 };
 
@@ -2034,6 +2125,7 @@ static struct platform_driver mv643xx_eth_shared_driver = {
        .remove = mv643xx_eth_shared_remove,
        .driver = {
                .name = MV643XX_ETH_SHARED_NAME,
+               .owner  = THIS_MODULE,
        },
 };
 
@@ -2081,7 +2173,8 @@ MODULE_LICENSE("GPL");
 MODULE_AUTHOR( "Rabeeh Khoury, Assaf Hoffman, Matthew Dharm, Manish Lachwani"
                " and Dale Farnsworth");
 MODULE_DESCRIPTION("Ethernet driver for Marvell MV643XX");
-MODULE_ALIAS("platform:mv643xx_eth");
+MODULE_ALIAS("platform:" MV643XX_ETH_NAME);
+MODULE_ALIAS("platform:" MV643XX_ETH_SHARED_NAME);
 
 /*
  * The second part is the low level driver of the gigE ethernet ports.
@@ -2280,28 +2373,28 @@ static void eth_port_start(struct net_device *dev)
 
        /* Assignment of Tx CTRP of given queue */
        tx_curr_desc = mp->tx_curr_desc_q;
-       mv_write(TX_CURRENT_QUEUE_DESC_PTR_0(port_num),
+       wrl(mp, TX_CURRENT_QUEUE_DESC_PTR_0(port_num),
                (u32)((struct eth_tx_desc *)mp->tx_desc_dma + tx_curr_desc));
 
        /* Assignment of Rx CRDP of given queue */
        rx_curr_desc = mp->rx_curr_desc_q;
-       mv_write(RX_CURRENT_QUEUE_DESC_PTR_0(port_num),
+       wrl(mp, RX_CURRENT_QUEUE_DESC_PTR_0(port_num),
                (u32)((struct eth_rx_desc *)mp->rx_desc_dma + rx_curr_desc));
 
        /* Add the assigned Ethernet address to the port's address table */
        eth_port_uc_addr_set(mp, dev->dev_addr);
 
        /* Assign port configuration and command. */
-       mv_write(PORT_CONFIG_REG(port_num),
+       wrl(mp, PORT_CONFIG_REG(port_num),
                          PORT_CONFIG_DEFAULT_VALUE);
 
-       mv_write(PORT_CONFIG_EXTEND_REG(port_num),
+       wrl(mp, PORT_CONFIG_EXTEND_REG(port_num),
                          PORT_CONFIG_EXTEND_DEFAULT_VALUE);
 
-       pscr = mv_read(PORT_SERIAL_CONTROL_REG(port_num));
+       pscr = rdl(mp, PORT_SERIAL_CONTROL_REG(port_num));
 
        pscr &= ~(SERIAL_PORT_ENABLE | FORCE_LINK_PASS);
-       mv_write(PORT_SERIAL_CONTROL_REG(port_num), pscr);
+       wrl(mp, PORT_SERIAL_CONTROL_REG(port_num), pscr);
 
        pscr |= DISABLE_AUTO_NEG_FOR_FLOW_CTRL |
                DISABLE_AUTO_NEG_SPEED_GMII    |
@@ -2309,20 +2402,20 @@ static void eth_port_start(struct net_device *dev)
                DO_NOT_FORCE_LINK_FAIL     |
                SERIAL_PORT_CONTROL_RESERVED;
 
-       mv_write(PORT_SERIAL_CONTROL_REG(port_num), pscr);
+       wrl(mp, PORT_SERIAL_CONTROL_REG(port_num), pscr);
 
        pscr |= SERIAL_PORT_ENABLE;
-       mv_write(PORT_SERIAL_CONTROL_REG(port_num), pscr);
+       wrl(mp, PORT_SERIAL_CONTROL_REG(port_num), pscr);
 
        /* Assign port SDMA configuration */
-       mv_write(SDMA_CONFIG_REG(port_num),
+       wrl(mp, SDMA_CONFIG_REG(port_num),
                          PORT_SDMA_CONFIG_DEFAULT_VALUE);
 
        /* Enable port Rx. */
        mv643xx_eth_port_enable_rx(mp, ETH_RX_QUEUES_ENABLED);
 
        /* Disable port bandwidth limits by clearing MTU register */
-       mv_write(MAXIMUM_TRANSMIT_UNIT(port_num), 0);
+       wrl(mp, MAXIMUM_TRANSMIT_UNIT(port_num), 0);
 
        /* save phy settings across reset */
        mv643xx_get_settings(dev, &ethtool_cmd);
@@ -2345,8 +2438,8 @@ static void eth_port_uc_addr_set(struct mv643xx_private *mp,
        mac_h = (p_addr[0] << 24) | (p_addr[1] << 16) | (p_addr[2] << 8) |
                                                        (p_addr[3] << 0);
 
-       mv_write(MAC_ADDR_LOW(port_num), mac_l);
-       mv_write(MAC_ADDR_HIGH(port_num), mac_h);
+       wrl(mp, MAC_ADDR_LOW(port_num), mac_l);
+       wrl(mp, MAC_ADDR_HIGH(port_num), mac_h);
 
        /* Accept frames with this address */
        table = DA_FILTER_UNICAST_TABLE_BASE(port_num);
@@ -2363,8 +2456,8 @@ static void eth_port_uc_addr_get(struct mv643xx_private *mp,
        unsigned int mac_h;
        unsigned int mac_l;
 
-       mac_h = mv_read(MAC_ADDR_HIGH(port_num));
-       mac_l = mv_read(MAC_ADDR_LOW(port_num));
+       mac_h = rdl(mp, MAC_ADDR_HIGH(port_num));
+       mac_l = rdl(mp, MAC_ADDR_LOW(port_num));
 
        p_addr[0] = (mac_h >> 24) & 0xff;
        p_addr[1] = (mac_h >> 16) & 0xff;
@@ -2394,9 +2487,9 @@ static void eth_port_set_filter_table_entry(struct mv643xx_private *mp,
        reg_offset = entry % 4;         /* Entry offset within the register */
 
        /* Set "accepts frame bit" at specified table entry */
-       table_reg = mv_read(table + tbl_offset);
+       table_reg = rdl(mp, table + tbl_offset);
        table_reg |= 0x01 << (8 * reg_offset);
-       mv_write(table + tbl_offset, table_reg);
+       wrl(mp, table + tbl_offset, table_reg);
 }
 
 /*
@@ -2529,7 +2622,7 @@ static void eth_port_set_multicast_list(struct net_device *dev)
                         * 3-1  Queue    ETH_Q0=0
                         * 7-4  Reserved = 0;
                         */
-                       mv_write(DA_FILTER_SPECIAL_MULTICAST_TABLE_BASE(eth_port_num) + table_index, 0x01010101);
+                       wrl(mp, DA_FILTER_SPECIAL_MULTICAST_TABLE_BASE(eth_port_num) + table_index, 0x01010101);
 
                        /* Set all entries in DA filter other multicast
                         * table (Ex_dFOMT)
@@ -2539,7 +2632,7 @@ static void eth_port_set_multicast_list(struct net_device *dev)
                         * 3-1  Queue    ETH_Q0=0
                         * 7-4  Reserved = 0;
                         */
-                       mv_write(DA_FILTER_OTHER_MULTICAST_TABLE_BASE(eth_port_num) + table_index, 0x01010101);
+                       wrl(mp, DA_FILTER_OTHER_MULTICAST_TABLE_BASE(eth_port_num) + table_index, 0x01010101);
                }
                return;
        }
@@ -2549,11 +2642,11 @@ static void eth_port_set_multicast_list(struct net_device *dev)
         */
        for (table_index = 0; table_index <= 0xFC; table_index += 4) {
                /* Clear DA filter special multicast table (Ex_dFSMT) */
-               mv_write(DA_FILTER_SPECIAL_MULTICAST_TABLE_BASE
+               wrl(mp, DA_FILTER_SPECIAL_MULTICAST_TABLE_BASE
                                (eth_port_num) + table_index, 0);
 
                /* Clear DA filter other multicast table (Ex_dFOMT) */
-               mv_write(DA_FILTER_OTHER_MULTICAST_TABLE_BASE
+               wrl(mp, DA_FILTER_OTHER_MULTICAST_TABLE_BASE
                                (eth_port_num) + table_index, 0);
        }
 
@@ -2588,15 +2681,15 @@ static void eth_port_init_mac_tables(struct mv643xx_private *mp)
 
        /* Clear DA filter unicast table (Ex_dFUT) */
        for (table_index = 0; table_index <= 0xC; table_index += 4)
-               mv_write(DA_FILTER_UNICAST_TABLE_BASE(port_num) +
+               wrl(mp, DA_FILTER_UNICAST_TABLE_BASE(port_num) +
                                        table_index, 0);
 
        for (table_index = 0; table_index <= 0xFC; table_index += 4) {
                /* Clear DA filter special multicast table (Ex_dFSMT) */
-               mv_write(DA_FILTER_SPECIAL_MULTICAST_TABLE_BASE(port_num) +
+               wrl(mp, DA_FILTER_SPECIAL_MULTICAST_TABLE_BASE(port_num) +
                                        table_index, 0);
                /* Clear DA filter other multicast table (Ex_dFOMT) */
-               mv_write(DA_FILTER_OTHER_MULTICAST_TABLE_BASE(port_num) +
+               wrl(mp, DA_FILTER_OTHER_MULTICAST_TABLE_BASE(port_num) +
                                        table_index, 0);
        }
 }
@@ -2626,12 +2719,12 @@ static void eth_clear_mib_counters(struct mv643xx_private *mp)
        /* Perform dummy reads from MIB counters */
        for (i = ETH_MIB_GOOD_OCTETS_RECEIVED_LOW; i < ETH_MIB_LATE_COLLISION;
                                                                        i += 4)
-               mv_read(MIB_COUNTERS_BASE(port_num) + i);
+               rdl(mp, MIB_COUNTERS_BASE(port_num) + i);
 }
 
 static inline u32 read_mib(struct mv643xx_private *mp, int offset)
 {
-       return mv_read(MIB_COUNTERS_BASE(mp->port_num) + offset);
+       return rdl(mp, MIB_COUNTERS_BASE(mp->port_num) + offset);
 }
 
 static void eth_update_mib_counters(struct mv643xx_private *mp)
@@ -2716,7 +2809,7 @@ static int ethernet_phy_get(struct mv643xx_private *mp)
 {
        unsigned int reg_data;
 
-       reg_data = mv_read(PHY_ADDR_REG);
+       reg_data = rdl(mp, PHY_ADDR_REG);
 
        return ((reg_data >> (5 * mp->port_num)) & 0x1f);
 }
@@ -2743,10 +2836,10 @@ static void ethernet_phy_set(struct mv643xx_private *mp, int phy_addr)
        u32 reg_data;
        int addr_shift = 5 * mp->port_num;
 
-       reg_data = mv_read(PHY_ADDR_REG);
+       reg_data = rdl(mp, PHY_ADDR_REG);
        reg_data &= ~(0x1f << addr_shift);
        reg_data |= (phy_addr & 0x1f) << addr_shift;
-       mv_write(PHY_ADDR_REG, reg_data);
+       wrl(mp, PHY_ADDR_REG, reg_data);
 }
 
 /*
@@ -2784,13 +2877,13 @@ static void ethernet_phy_reset(struct mv643xx_private *mp)
 static void mv643xx_eth_port_enable_tx(struct mv643xx_private *mp,
                                        unsigned int queues)
 {
-       mv_write(TRANSMIT_QUEUE_COMMAND_REG(mp->port_num), queues);
+       wrl(mp, TRANSMIT_QUEUE_COMMAND_REG(mp->port_num), queues);
 }
 
 static void mv643xx_eth_port_enable_rx(struct mv643xx_private *mp,
                                        unsigned int queues)
 {
-       mv_write(RECEIVE_QUEUE_COMMAND_REG(mp->port_num), queues);
+       wrl(mp, RECEIVE_QUEUE_COMMAND_REG(mp->port_num), queues);
 }
 
 static unsigned int mv643xx_eth_port_disable_tx(struct mv643xx_private *mp)
@@ -2799,18 +2892,18 @@ static unsigned int mv643xx_eth_port_disable_tx(struct mv643xx_private *mp)
        u32 queues;
 
        /* Stop Tx port activity. Check port Tx activity. */
-       queues = mv_read(TRANSMIT_QUEUE_COMMAND_REG(port_num)) & 0xFF;
+       queues = rdl(mp, TRANSMIT_QUEUE_COMMAND_REG(port_num)) & 0xFF;
        if (queues) {
                /* Issue stop command for active queues only */
-               mv_write(TRANSMIT_QUEUE_COMMAND_REG(port_num), (queues << 8));
+               wrl(mp, TRANSMIT_QUEUE_COMMAND_REG(port_num), (queues << 8));
 
                /* Wait for all Tx activity to terminate. */
                /* Check port cause register that all Tx queues are stopped */
-               while (mv_read(TRANSMIT_QUEUE_COMMAND_REG(port_num)) & 0xFF)
+               while (rdl(mp, TRANSMIT_QUEUE_COMMAND_REG(port_num)) & 0xFF)
                        udelay(PHY_WAIT_MICRO_SECONDS);
 
                /* Wait for Tx FIFO to empty */
-               while (mv_read(PORT_STATUS_REG(port_num)) &
+               while (rdl(mp, PORT_STATUS_REG(port_num)) &
                                                        ETH_PORT_TX_FIFO_EMPTY)
                        udelay(PHY_WAIT_MICRO_SECONDS);
        }
@@ -2824,14 +2917,14 @@ static unsigned int mv643xx_eth_port_disable_rx(struct mv643xx_private *mp)
        u32 queues;
 
        /* Stop Rx port activity. Check port Rx activity. */
-       queues = mv_read(RECEIVE_QUEUE_COMMAND_REG(port_num)) & 0xFF;
+       queues = rdl(mp, RECEIVE_QUEUE_COMMAND_REG(port_num)) & 0xFF;
        if (queues) {
                /* Issue stop command for active queues only */
-               mv_write(RECEIVE_QUEUE_COMMAND_REG(port_num), (queues << 8));
+               wrl(mp, RECEIVE_QUEUE_COMMAND_REG(port_num), (queues << 8));
 
                /* Wait for all Rx activity to terminate. */
                /* Check port cause register that all Rx queues are stopped */
-               while (mv_read(RECEIVE_QUEUE_COMMAND_REG(port_num)) & 0xFF)
+               while (rdl(mp, RECEIVE_QUEUE_COMMAND_REG(port_num)) & 0xFF)
                        udelay(PHY_WAIT_MICRO_SECONDS);
        }
 
@@ -2868,11 +2961,11 @@ static void eth_port_reset(struct mv643xx_private *mp)
        eth_clear_mib_counters(mp);
 
        /* Reset the Enable bit in the Configuration Register */
-       reg_data = mv_read(PORT_SERIAL_CONTROL_REG(port_num));
+       reg_data = rdl(mp, PORT_SERIAL_CONTROL_REG(port_num));
        reg_data &= ~(SERIAL_PORT_ENABLE                |
                        DO_NOT_FORCE_LINK_FAIL  |
                        FORCE_LINK_PASS);
-       mv_write(PORT_SERIAL_CONTROL_REG(port_num), reg_data);
+       wrl(mp, PORT_SERIAL_CONTROL_REG(port_num), reg_data);
 }
 
 
@@ -2899,39 +2992,38 @@ static void eth_port_reset(struct mv643xx_private *mp)
 static void eth_port_read_smi_reg(struct mv643xx_private *mp,
                                unsigned int phy_reg, unsigned int *value)
 {
+       void __iomem *smi_reg = mp->shared_smi->eth_base + SMI_REG;
        int phy_addr = ethernet_phy_get(mp);
        unsigned long flags;
        int i;
 
        /* the SMI register is a shared resource */
-       spin_lock_irqsave(&mv643xx_eth_phy_lock, flags);
+       spin_lock_irqsave(&mp->shared_smi->phy_lock, flags);
 
        /* wait for the SMI register to become available */
-       for (i = 0; mv_read(SMI_REG) & ETH_SMI_BUSY; i++) {
+       for (i = 0; readl(smi_reg) & ETH_SMI_BUSY; i++) {
                if (i == PHY_WAIT_ITERATIONS) {
-                       printk("mv643xx PHY busy timeout, port %d\n",
-                               mp->port_num);
+                       printk("%s: PHY busy timeout\n", mp->dev->name);
                        goto out;
                }
                udelay(PHY_WAIT_MICRO_SECONDS);
        }
 
-       mv_write(SMI_REG,
-               (phy_addr << 16) | (phy_reg << 21) | ETH_SMI_OPCODE_READ);
+       writel((phy_addr << 16) | (phy_reg << 21) | ETH_SMI_OPCODE_READ,
+               smi_reg);
 
        /* now wait for the data to be valid */
-       for (i = 0; !(mv_read(SMI_REG) & ETH_SMI_READ_VALID); i++) {
+       for (i = 0; !(readl(smi_reg) & ETH_SMI_READ_VALID); i++) {
                if (i == PHY_WAIT_ITERATIONS) {
-                       printk("mv643xx PHY read timeout, port %d\n",
-                               mp->port_num);
+                       printk("%s: PHY read timeout\n", mp->dev->name);
                        goto out;
                }
                udelay(PHY_WAIT_MICRO_SECONDS);
        }
 
-       *value = mv_read(SMI_REG) & 0xffff;
+       *value = readl(smi_reg) & 0xffff;
 out:
-       spin_unlock_irqrestore(&mv643xx_eth_phy_lock, flags);
+       spin_unlock_irqrestore(&mp->shared_smi->phy_lock, flags);
 }
 
 /*
@@ -2957,29 +3049,27 @@ out:
 static void eth_port_write_smi_reg(struct mv643xx_private *mp,
                                   unsigned int phy_reg, unsigned int value)
 {
-       int phy_addr;
-       int i;
+       void __iomem *smi_reg = mp->shared_smi->eth_base + SMI_REG;
+       int phy_addr = ethernet_phy_get(mp);
        unsigned long flags;
-
-       phy_addr = ethernet_phy_get(mp);
+       int i;
 
        /* the SMI register is a shared resource */
-       spin_lock_irqsave(&mv643xx_eth_phy_lock, flags);
+       spin_lock_irqsave(&mp->shared_smi->phy_lock, flags);
 
        /* wait for the SMI register to become available */
-       for (i = 0; mv_read(SMI_REG) & ETH_SMI_BUSY; i++) {
+       for (i = 0; readl(smi_reg) & ETH_SMI_BUSY; i++) {
                if (i == PHY_WAIT_ITERATIONS) {
-                       printk("mv643xx PHY busy timeout, port %d\n",
-                               mp->port_num);
+                       printk("%s: PHY busy timeout\n", mp->dev->name);
                        goto out;
                }
                udelay(PHY_WAIT_MICRO_SECONDS);
        }
 
-       mv_write(SMI_REG, (phy_addr << 16) | (phy_reg << 21) |
-                               ETH_SMI_OPCODE_WRITE | (value & 0xffff));
+       writel((phy_addr << 16) | (phy_reg << 21) |
+               ETH_SMI_OPCODE_WRITE | (value & 0xffff), smi_reg);
 out:
-       spin_unlock_irqrestore(&mv643xx_eth_phy_lock, flags);
+       spin_unlock_irqrestore(&mp->shared_smi->phy_lock, flags);
 }
 
 /*