]> err.no Git - linux-2.6/blobdiff - drivers/net/ixgb/ixgb_main.c
Merge branch 'master' of /home/cbou/linux-2.6
[linux-2.6] / drivers / net / ixgb / ixgb_main.c
index f7dda049dd8604485f768383ca57eb4c26898c6c..aa75385cd6c7ca67bfbc7c851db2101f986dd965 100644 (file)
@@ -1,7 +1,7 @@
 /*******************************************************************************
 
   Intel PRO/10GbE Linux driver
-  Copyright(c) 1999 - 2006 Intel Corporation.
+  Copyright(c) 1999 - 2008 Intel Corporation.
 
   This program is free software; you can redistribute it and/or modify it
   under the terms and conditions of the GNU General Public License,
 char ixgb_driver_name[] = "ixgb";
 static char ixgb_driver_string[] = "Intel(R) PRO/10GbE Network Driver";
 
-#ifndef CONFIG_IXGB_NAPI
-#define DRIVERNAPI
-#else
 #define DRIVERNAPI "-NAPI"
-#endif
-#define DRV_VERSION            "1.0.126-k4"DRIVERNAPI
+#define DRV_VERSION "1.0.135-k2" DRIVERNAPI
 const char ixgb_driver_version[] = DRV_VERSION;
-static const char ixgb_copyright[] = "Copyright (c) 1999-2006 Intel Corporation.";
+static const char ixgb_copyright[] = "Copyright (c) 1999-2008 Intel Corporation.";
 
 #define IXGB_CB_LENGTH 256
 static unsigned int copybreak __read_mostly = IXGB_CB_LENGTH;
@@ -92,13 +88,9 @@ static int ixgb_set_mac(struct net_device *netdev, void *p);
 static irqreturn_t ixgb_intr(int irq, void *data);
 static bool ixgb_clean_tx_irq(struct ixgb_adapter *adapter);
 
-#ifdef CONFIG_IXGB_NAPI
 static int ixgb_clean(struct napi_struct *, int);
 static bool ixgb_clean_rx_irq(struct ixgb_adapter *, int *, int);
-#else
-static bool ixgb_clean_rx_irq(struct ixgb_adapter *);
-#endif
-static void ixgb_alloc_rx_buffers(struct ixgb_adapter *);
+static void ixgb_alloc_rx_buffers(struct ixgb_adapter *, int);
 
 static void ixgb_tx_timeout(struct net_device *dev);
 static void ixgb_tx_timeout_task(struct work_struct *work);
@@ -225,7 +217,7 @@ ixgb_up(struct ixgb_adapter *adapter)
        ixgb_configure_tx(adapter);
        ixgb_setup_rctl(adapter);
        ixgb_configure_rx(adapter);
-       ixgb_alloc_rx_buffers(adapter);
+       ixgb_alloc_rx_buffers(adapter, IXGB_DESC_UNUSED(&adapter->rx_ring));
 
        /* disable interrupts and get the hardware into a known state */
        IXGB_WRITE_REG(&adapter->hw, IMC, 0xffffffff);
@@ -271,9 +263,7 @@ ixgb_up(struct ixgb_adapter *adapter)
 
        clear_bit(__IXGB_DOWN, &adapter->flags);
 
-#ifdef CONFIG_IXGB_NAPI
        napi_enable(&adapter->napi);
-#endif
        ixgb_irq_enable(adapter);
 
        mod_timer(&adapter->watchdog_timer, jiffies);
@@ -289,9 +279,7 @@ ixgb_down(struct ixgb_adapter *adapter, bool kill_watchdog)
        /* prevent the interrupt handler from restarting watchdog */
        set_bit(__IXGB_DOWN, &adapter->flags);
 
-#ifdef CONFIG_IXGB_NAPI
        napi_disable(&adapter->napi);
-#endif
        /* waiting for NAPI to complete can re-enable interrupts */
        ixgb_irq_disable(adapter);
        free_irq(adapter->pdev->irq, netdev);
@@ -346,8 +334,7 @@ ixgb_reset(struct ixgb_adapter *adapter)
  **/
 
 static int __devinit
-ixgb_probe(struct pci_dev *pdev,
-               const struct pci_device_id *ent)
+ixgb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
        struct net_device *netdev = NULL;
        struct ixgb_adapter *adapter;
@@ -356,15 +343,16 @@ ixgb_probe(struct pci_dev *pdev,
        int i;
        int err;
 
-       if ((err = pci_enable_device(pdev)))
+       err = pci_enable_device(pdev);
+       if (err)
                return err;
 
        if (!(err = pci_set_dma_mask(pdev, DMA_64BIT_MASK)) &&
-          !(err = pci_set_consistent_dma_mask(pdev, DMA_64BIT_MASK))) {
+           !(err = pci_set_consistent_dma_mask(pdev, DMA_64BIT_MASK))) {
                pci_using_dac = 1;
        } else {
                if ((err = pci_set_dma_mask(pdev, DMA_32BIT_MASK)) ||
-                  (err = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK))) {
+                   (err = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK))) {
                        printk(KERN_ERR
                         "ixgb: No usable DMA configuration, aborting\n");
                        goto err_dma_mask;
@@ -372,7 +360,8 @@ ixgb_probe(struct pci_dev *pdev,
                pci_using_dac = 0;
        }
 
-       if ((err = pci_request_regions(pdev, ixgb_driver_name)))
+       err = pci_request_regions(pdev, ixgb_driver_name);
+       if (err)
                goto err_request_regions;
 
        pci_set_master(pdev);
@@ -399,7 +388,7 @@ ixgb_probe(struct pci_dev *pdev,
                goto err_ioremap;
        }
 
-       for(i = BAR_1; i <= BAR_5; i++) {
+       for (i = BAR_1; i <= BAR_5; i++) {
                if (pci_resource_len(pdev, i) == 0)
                        continue;
                if (pci_resource_flags(pdev, i) & IORESOURCE_IO) {
@@ -418,9 +407,7 @@ ixgb_probe(struct pci_dev *pdev,
        ixgb_set_ethtool_ops(netdev);
        netdev->tx_timeout = &ixgb_tx_timeout;
        netdev->watchdog_timeo = 5 * HZ;
-#ifdef CONFIG_IXGB_NAPI
        netif_napi_add(netdev, &adapter->napi, ixgb_clean, 64);
-#endif
        netdev->vlan_rx_register = ixgb_vlan_rx_register;
        netdev->vlan_rx_add_vid = ixgb_vlan_rx_add_vid;
        netdev->vlan_rx_kill_vid = ixgb_vlan_rx_kill_vid;
@@ -436,7 +423,8 @@ ixgb_probe(struct pci_dev *pdev,
 
        /* setup the private structure */
 
-       if ((err = ixgb_sw_init(adapter)))
+       err = ixgb_sw_init(adapter);
+       if (err)
                goto err_sw_init;
 
        netdev->features = NETIF_F_SG |
@@ -475,7 +463,8 @@ ixgb_probe(struct pci_dev *pdev,
        INIT_WORK(&adapter->tx_timeout_task, ixgb_tx_timeout_task);
 
        strcpy(netdev->name, "eth%d");
-       if ((err = register_netdev(netdev)))
+       err = register_netdev(netdev);
+       if (err)
                goto err_register;
 
        /* we're going to reset, so assume we have no link for now */
@@ -562,7 +551,7 @@ ixgb_sw_init(struct ixgb_adapter *adapter)
           || (hw->device_id == IXGB_DEVICE_ID_82597EX_CX4)
           || (hw->device_id == IXGB_DEVICE_ID_82597EX_LR)
           || (hw->device_id == IXGB_DEVICE_ID_82597EX_SR))
-                       hw->mac_type = ixgb_82597;
+               hw->mac_type = ixgb_82597;
        else {
                /* should never have loaded on this device */
                DPRINTK(PROBE, ERR, "unsupported device id\n");
@@ -595,16 +584,18 @@ ixgb_open(struct net_device *netdev)
        int err;
 
        /* allocate transmit descriptors */
-
-       if ((err = ixgb_setup_tx_resources(adapter)))
+       err = ixgb_setup_tx_resources(adapter);
+       if (err)
                goto err_setup_tx;
 
        /* allocate receive descriptors */
 
-       if ((err = ixgb_setup_rx_resources(adapter)))
+       err = ixgb_setup_rx_resources(adapter);
+       if (err)
                goto err_setup_rx;
 
-       if ((err = ixgb_up(adapter)))
+       err = ixgb_up(adapter);
+       if (err)
                goto err_up;
 
        return 0;
@@ -702,8 +693,8 @@ ixgb_configure_tx(struct ixgb_adapter *adapter)
        u32 tctl;
        struct ixgb_hw *hw = &adapter->hw;
 
-       /* Setup the Base and Length of the Tx Descriptor Ring 
-        * tx_ring.dma can be either a 32 or 64 bit value 
+       /* Setup the Base and Length of the Tx Descriptor Ring
+        * tx_ring.dma can be either a 32 or 64 bit value
         */
 
        IXGB_WRITE_REG(hw, TDBAL, (tdba & 0x00000000ffffffffULL));
@@ -729,8 +720,8 @@ ixgb_configure_tx(struct ixgb_adapter *adapter)
 
        /* Setup Transmit Descriptor Settings for this adapter */
        adapter->tx_cmd_type =
-               IXGB_TX_DESC_TYPE 
-               (adapter->tx_int_delay_enable ? IXGB_TX_DESC_CMD_IDE : 0);
+               IXGB_TX_DESC_TYPE |
+               (adapter->tx_int_delay_enable ? IXGB_TX_DESC_CMD_IDE : 0);
 }
 
 /**
@@ -792,8 +783,8 @@ ixgb_setup_rctl(struct ixgb_adapter *adapter)
        rctl &= ~(3 << IXGB_RCTL_MO_SHIFT);
 
        rctl |=
-               IXGB_RCTL_BAM | IXGB_RCTL_RDMTS_1_2 | 
-               IXGB_RCTL_RXEN | IXGB_RCTL_CFF | 
+               IXGB_RCTL_BAM | IXGB_RCTL_RDMTS_1_2 |
+               IXGB_RCTL_RXEN | IXGB_RCTL_CFF |
                (adapter->hw.mc_filter_type << IXGB_RCTL_MO_SHIFT);
 
        rctl |= IXGB_RCTL_SECRC;
@@ -890,7 +881,7 @@ ixgb_free_tx_resources(struct ixgb_adapter *adapter)
 
 static void
 ixgb_unmap_and_free_tx_resource(struct ixgb_adapter *adapter,
-                                       struct ixgb_buffer *buffer_info)
+                                struct ixgb_buffer *buffer_info)
 {
        struct pci_dev *pdev = adapter->pdev;
 
@@ -898,8 +889,10 @@ ixgb_unmap_and_free_tx_resource(struct ixgb_adapter *adapter,
                pci_unmap_page(pdev, buffer_info->dma, buffer_info->length,
                               PCI_DMA_TODEVICE);
 
+       /* okay to call kfree_skb here instead of kfree_skb_any because
+        * this is never called in interrupt context */
        if (buffer_info->skb)
-               dev_kfree_skb_any(buffer_info->skb);
+               dev_kfree_skb(buffer_info->skb);
 
        buffer_info->skb = NULL;
        buffer_info->dma = 0;
@@ -924,7 +917,7 @@ ixgb_clean_tx_ring(struct ixgb_adapter *adapter)
 
        /* Free all the Tx ring sk_buffs */
 
-       for(i = 0; i < tx_ring->count; i++) {
+       for (i = 0; i < tx_ring->count; i++) {
                buffer_info = &tx_ring->buffer_info[i];
                ixgb_unmap_and_free_tx_resource(adapter, buffer_info);
        }
@@ -982,7 +975,7 @@ ixgb_clean_rx_ring(struct ixgb_adapter *adapter)
 
        /* Free all the Rx ring sk_buffs */
 
-       for(i = 0; i < rx_ring->count; i++) {
+       for (i = 0; i < rx_ring->count; i++) {
                buffer_info = &rx_ring->buffer_info[i];
                if (buffer_info->skb) {
 
@@ -1060,11 +1053,15 @@ ixgb_set_multi(struct net_device *netdev)
 
        if (netdev->flags & IFF_PROMISC) {
                rctl |= (IXGB_RCTL_UPE | IXGB_RCTL_MPE);
-       } else if (netdev->flags & IFF_ALLMULTI) {
-               rctl |= IXGB_RCTL_MPE;
-               rctl &= ~IXGB_RCTL_UPE;
+               rctl &= ~IXGB_RCTL_VFE;
        } else {
-               rctl &= ~(IXGB_RCTL_UPE | IXGB_RCTL_MPE);
+               if (netdev->flags & IFF_ALLMULTI) {
+                       rctl |= IXGB_RCTL_MPE;
+                       rctl &= ~IXGB_RCTL_UPE;
+               } else {
+                       rctl &= ~(IXGB_RCTL_UPE | IXGB_RCTL_MPE);
+               }
+               rctl |= IXGB_RCTL_VFE;
        }
 
        if (netdev->mc_count > IXGB_MAX_NUM_MULTICAST_ADDRESSES) {
@@ -1076,10 +1073,11 @@ ixgb_set_multi(struct net_device *netdev)
 
                IXGB_WRITE_REG(hw, RCTL, rctl);
 
-               for(i = 0, mc_ptr = netdev->mc_list; mc_ptr;
-                       i++, mc_ptr = mc_ptr->next)
+               for (i = 0, mc_ptr = netdev->mc_list;
+                    mc_ptr;
+                    i++, mc_ptr = mc_ptr->next)
                        memcpy(&mta[i * IXGB_ETH_LENGTH_OF_ADDRESS],
-                                  mc_ptr->dmi_addr, IXGB_ETH_LENGTH_OF_ADDRESS);
+                              mc_ptr->dmi_addr, IXGB_ETH_LENGTH_OF_ADDRESS);
 
                ixgb_mc_addr_list_update(hw, mta, netdev->mc_count, 0);
        }
@@ -1199,7 +1197,7 @@ ixgb_tso(struct ixgb_adapter *adapter, struct sk_buff *skb)
                context_desc->hdr_len = hdr_len;
                context_desc->status = 0;
                context_desc->cmd_type_len = cpu_to_le32(
-                                                 IXGB_CONTEXT_DESC_TYPE 
+                                                 IXGB_CONTEXT_DESC_TYPE
                                                | IXGB_CONTEXT_DESC_CMD_TSE
                                                | IXGB_CONTEXT_DESC_CMD_IP
                                                | IXGB_CONTEXT_DESC_CMD_TCP
@@ -1274,7 +1272,7 @@ ixgb_tx_map(struct ixgb_adapter *adapter, struct sk_buff *skb,
 
        i = tx_ring->next_to_use;
 
-       while(len) {
+       while (len) {
                buffer_info = &tx_ring->buffer_info[i];
                size = min(len, IXGB_MAX_DATA_PER_TXD);
                /* Workaround for premature desc write-backs
@@ -1298,14 +1296,14 @@ ixgb_tx_map(struct ixgb_adapter *adapter, struct sk_buff *skb,
                if (++i == tx_ring->count) i = 0;
        }
 
-       for(f = 0; f < nr_frags; f++) {
+       for (f = 0; f < nr_frags; f++) {
                struct skb_frag_struct *frag;
 
                frag = &skb_shinfo(skb)->frags[f];
                len = frag->size;
                offset = 0;
 
-               while(len) {
+               while (len) {
                        buffer_info = &tx_ring->buffer_info[i];
                        size = min(len, IXGB_MAX_DATA_PER_TXD);
 
@@ -1362,7 +1360,7 @@ ixgb_tx_queue(struct ixgb_adapter *adapter, int count, int vlan_id,int tx_flags)
 
        i = tx_ring->next_to_use;
 
-       while(count--) {
+       while (count--) {
                buffer_info = &tx_ring->buffer_info[i];
                tx_desc = IXGB_TX_DESC(*tx_ring, i);
                tx_desc->buff_addr = cpu_to_le64(buffer_info->dma);
@@ -1375,8 +1373,8 @@ ixgb_tx_queue(struct ixgb_adapter *adapter, int count, int vlan_id,int tx_flags)
                if (++i == tx_ring->count) i = 0;
        }
 
-       tx_desc->cmd_type_len |= cpu_to_le32(IXGB_TX_DESC_CMD_EOP 
-                               | IXGB_TX_DESC_CMD_RS );
+       tx_desc->cmd_type_len |=
+               cpu_to_le32(IXGB_TX_DESC_CMD_EOP | IXGB_TX_DESC_CMD_RS);
 
        /* Force memory writes to complete before letting h/w
         * know there are new descriptors to fetch.  (Only
@@ -1441,7 +1439,7 @@ ixgb_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
        }
 
        if (skb->len <= 0) {
-               dev_kfree_skb_any(skb);
+               dev_kfree_skb(skb);
                return 0;
        }
 
@@ -1455,10 +1453,10 @@ ixgb_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
        }
 
        first = adapter->tx_ring.next_to_use;
-       
+
        tso = ixgb_tso(adapter, skb);
        if (tso < 0) {
-               dev_kfree_skb_any(skb);
+               dev_kfree_skb(skb);
                return NETDEV_TX_OK;
        }
 
@@ -1577,16 +1575,16 @@ ixgb_update_stats(struct ixgb_adapter *adapter)
                u64 multi = IXGB_READ_REG(&adapter->hw, MPRCL);
                u32 bcast_l = IXGB_READ_REG(&adapter->hw, BPRCL);
                u32 bcast_h = IXGB_READ_REG(&adapter->hw, BPRCH);
-               u64 bcast = ((u64)bcast_h << 32) | bcast_l; 
+               u64 bcast = ((u64)bcast_h << 32) | bcast_l;
 
                multi |= ((u64)IXGB_READ_REG(&adapter->hw, MPRCH) << 32);
                /* fix up multicast stats by removing broadcasts */
                if (multi >= bcast)
                        multi -= bcast;
-               
+
                adapter->stats.mprcl += (multi & 0xFFFFFFFF);
                adapter->stats.mprch += (multi >> 32);
-               adapter->stats.bprcl += bcast_l; 
+               adapter->stats.bprcl += bcast_l;
                adapter->stats.bprch += bcast_h;
        } else {
                adapter->stats.mprcl += IXGB_READ_REG(&adapter->hw, MPRCL);
@@ -1701,9 +1699,6 @@ ixgb_intr(int irq, void *data)
        struct ixgb_adapter *adapter = netdev_priv(netdev);
        struct ixgb_hw *hw = &adapter->hw;
        u32 icr = IXGB_READ_REG(hw, ICR);
-#ifndef CONFIG_IXGB_NAPI
-       unsigned int i;
-#endif
 
        if (unlikely(!icr))
                return IRQ_NONE;  /* Not our interrupt */
@@ -1712,30 +1707,18 @@ ixgb_intr(int irq, void *data)
                if (!test_bit(__IXGB_DOWN, &adapter->flags))
                        mod_timer(&adapter->watchdog_timer, jiffies);
 
-#ifdef CONFIG_IXGB_NAPI
        if (netif_rx_schedule_prep(netdev, &adapter->napi)) {
 
-               /* Disable interrupts and register for poll. The flush 
+               /* Disable interrupts and register for poll. The flush
                  of the posted write is intentionally left out.
                */
 
                IXGB_WRITE_REG(&adapter->hw, IMC, ~0);
                __netif_rx_schedule(netdev, &adapter->napi);
        }
-#else
-       /* yes, that is actually a & and it is meant to make sure that
-        * every pass through this for loop checks both receive and
-        * transmit queues for completed descriptors, intended to
-        * avoid starvation issues and assist tx/rx fairness. */
-       for(i = 0; i < IXGB_MAX_INTR; i++)
-               if (!ixgb_clean_rx_irq(adapter) &
-                  !ixgb_clean_tx_irq(adapter))
-                       break;
-#endif 
        return IRQ_HANDLED;
 }
 
-#ifdef CONFIG_IXGB_NAPI
 /**
  * ixgb_clean - NAPI Rx polling callback
  * @adapter: board private structure
@@ -1760,7 +1743,6 @@ ixgb_clean(struct napi_struct *napi, int budget)
 
        return work_done;
 }
-#endif
 
 /**
  * ixgb_clean_tx_irq - Reclaim resources after transmit completes
@@ -1781,15 +1763,15 @@ ixgb_clean_tx_irq(struct ixgb_adapter *adapter)
        eop = tx_ring->buffer_info[i].next_to_watch;
        eop_desc = IXGB_TX_DESC(*tx_ring, eop);
 
-       while(eop_desc->status & IXGB_TX_DESC_STATUS_DD) {
+       while (eop_desc->status & IXGB_TX_DESC_STATUS_DD) {
 
                for (cleaned = false; !cleaned; ) {
                        tx_desc = IXGB_TX_DESC(*tx_ring, i);
                        buffer_info = &tx_ring->buffer_info[i];
 
-                       if (tx_desc->popts
-                           & (IXGB_TX_DESC_POPTS_TXSM |
-                              IXGB_TX_DESC_POPTS_IXSM))
+                       if (tx_desc->popts &
+                          (IXGB_TX_DESC_POPTS_TXSM |
+                           IXGB_TX_DESC_POPTS_IXSM))
                                adapter->hw_csum_tx_good++;
 
                        ixgb_unmap_and_free_tx_resource(adapter, buffer_info);
@@ -1862,8 +1844,8 @@ ixgb_clean_tx_irq(struct ixgb_adapter *adapter)
 
 static void
 ixgb_rx_checksum(struct ixgb_adapter *adapter,
-                struct ixgb_rx_desc *rx_desc,
-                struct sk_buff *skb)
+                 struct ixgb_rx_desc *rx_desc,
+                 struct sk_buff *skb)
 {
        /* Ignore Checksum bit is set OR
         * TCP Checksum has not been calculated
@@ -1893,11 +1875,7 @@ ixgb_rx_checksum(struct ixgb_adapter *adapter,
  **/
 
 static bool
-#ifdef CONFIG_IXGB_NAPI
 ixgb_clean_rx_irq(struct ixgb_adapter *adapter, int *work_done, int work_to_do)
-#else
-ixgb_clean_rx_irq(struct ixgb_adapter *adapter)
-#endif
 {
        struct ixgb_desc_ring *rx_ring = &adapter->rx_ring;
        struct net_device *netdev = adapter->netdev;
@@ -1906,27 +1884,26 @@ ixgb_clean_rx_irq(struct ixgb_adapter *adapter)
        struct ixgb_buffer *buffer_info, *next_buffer, *next2_buffer;
        u32 length;
        unsigned int i, j;
+       int cleaned_count = 0;
        bool cleaned = false;
 
        i = rx_ring->next_to_clean;
        rx_desc = IXGB_RX_DESC(*rx_ring, i);
        buffer_info = &rx_ring->buffer_info[i];
 
-       while(rx_desc->status & IXGB_RX_DESC_STATUS_DD) {
-               struct sk_buff *skb, *next_skb;
+       while (rx_desc->status & IXGB_RX_DESC_STATUS_DD) {
+               struct sk_buff *skb;
                u8 status;
 
-#ifdef CONFIG_IXGB_NAPI
                if (*work_done >= work_to_do)
                        break;
 
                (*work_done)++;
-#endif
                status = rx_desc->status;
                skb = buffer_info->skb;
                buffer_info->skb = NULL;
 
-               prefetch(skb->data);
+               prefetch(skb->data - NET_IP_ALIGN);
 
                if (++i == rx_ring->count) i = 0;
                next_rxd = IXGB_RX_DESC(*rx_ring, i);
@@ -1937,17 +1914,18 @@ ixgb_clean_rx_irq(struct ixgb_adapter *adapter)
                prefetch(next2_buffer);
 
                next_buffer = &rx_ring->buffer_info[i];
-               next_skb = next_buffer->skb;
-               prefetch(next_skb);
 
                cleaned = true;
+               cleaned_count++;
 
                pci_unmap_single(pdev,
                                 buffer_info->dma,
                                 buffer_info->length,
                                 PCI_DMA_FROMDEVICE);
+               buffer_info->dma = 0;
 
                length = le16_to_cpu(rx_desc->length);
+               rx_desc->length = 0;
 
                if (unlikely(!(status & IXGB_RX_DESC_STATUS_EOP))) {
 
@@ -1960,11 +1938,9 @@ ixgb_clean_rx_irq(struct ixgb_adapter *adapter)
                        goto rxdesc_done;
                }
 
-               if (unlikely(rx_desc->errors
-                            & (IXGB_RX_DESC_ERRORS_CE | IXGB_RX_DESC_ERRORS_SE
-                               | IXGB_RX_DESC_ERRORS_P |
-                               IXGB_RX_DESC_ERRORS_RXE))) {
-
+               if (unlikely(rx_desc->errors &
+                   (IXGB_RX_DESC_ERRORS_CE | IXGB_RX_DESC_ERRORS_SE |
+                    IXGB_RX_DESC_ERRORS_P | IXGB_RX_DESC_ERRORS_RXE))) {
                        dev_kfree_skb_irq(skb);
                        goto rxdesc_done;
                }
@@ -1997,27 +1973,24 @@ ixgb_clean_rx_irq(struct ixgb_adapter *adapter)
                ixgb_rx_checksum(adapter, rx_desc, skb);
 
                skb->protocol = eth_type_trans(skb, netdev);
-#ifdef CONFIG_IXGB_NAPI
                if (adapter->vlgrp && (status & IXGB_RX_DESC_STATUS_VP)) {
                        vlan_hwaccel_receive_skb(skb, adapter->vlgrp,
-                               le16_to_cpu(rx_desc->special));
+                                               le16_to_cpu(rx_desc->special));
                } else {
                        netif_receive_skb(skb);
                }
-#else /* CONFIG_IXGB_NAPI */
-               if (adapter->vlgrp && (status & IXGB_RX_DESC_STATUS_VP)) {
-                       vlan_hwaccel_rx(skb, adapter->vlgrp,
-                               le16_to_cpu(rx_desc->special));
-               } else {
-                       netif_rx(skb);
-               }
-#endif /* CONFIG_IXGB_NAPI */
                netdev->last_rx = jiffies;
 
 rxdesc_done:
                /* clean up descriptor, might be written over by hw */
                rx_desc->status = 0;
 
+               /* return some buffers to hardware, one at a time is too slow */
+               if (unlikely(cleaned_count >= IXGB_RX_BUFFER_WRITE)) {
+                       ixgb_alloc_rx_buffers(adapter, cleaned_count);
+                       cleaned_count = 0;
+               }
+
                /* use prefetched values */
                rx_desc = next_rxd;
                buffer_info = next_buffer;
@@ -2025,7 +1998,9 @@ rxdesc_done:
 
        rx_ring->next_to_clean = i;
 
-       ixgb_alloc_rx_buffers(adapter);
+       cleaned_count = IXGB_DESC_UNUSED(rx_ring);
+       if (cleaned_count)
+               ixgb_alloc_rx_buffers(adapter, cleaned_count);
 
        return cleaned;
 }
@@ -2036,7 +2011,7 @@ rxdesc_done:
  **/
 
 static void
-ixgb_alloc_rx_buffers(struct ixgb_adapter *adapter)
+ixgb_alloc_rx_buffers(struct ixgb_adapter *adapter, int cleaned_count)
 {
        struct ixgb_desc_ring *rx_ring = &adapter->rx_ring;
        struct net_device *netdev = adapter->netdev;
@@ -2053,7 +2028,7 @@ ixgb_alloc_rx_buffers(struct ixgb_adapter *adapter)
 
 
        /* leave three descriptors unused */
-       while(--cleancount > 2) {
+       while (--cleancount > 2 && cleaned_count--) {
                /* recycle! its good for you */
                skb = buffer_info->skb;
                if (skb) {
@@ -2086,7 +2061,7 @@ map_skb:
                rx_desc = IXGB_RX_DESC(*rx_ring, i);
                rx_desc->buff_addr = cpu_to_le64(buffer_info->dma);
                /* guarantee DD bit not set now before h/w gets descriptor
-                * this is the rest of the workaround for h/w double 
+                * this is the rest of the workaround for h/w double
                 * writeback. */
                rx_desc->status = 0;
 
@@ -2111,7 +2086,7 @@ map_skb:
 
 /**
  * ixgb_vlan_rx_register - enables or disables vlan tagging/stripping.
- * 
+ *
  * @param netdev network interface device structure
  * @param grp indicates to enable or disable tagging/stripping
  **/
@@ -2133,7 +2108,6 @@ ixgb_vlan_rx_register(struct net_device *netdev, struct vlan_group *grp)
                /* enable VLAN receive filtering */
 
                rctl = IXGB_READ_REG(&adapter->hw, RCTL);
-               rctl |= IXGB_RCTL_VFE;
                rctl &= ~IXGB_RCTL_CFIEN;
                IXGB_WRITE_REG(&adapter->hw, RCTL, rctl);
        } else {
@@ -2142,12 +2116,6 @@ ixgb_vlan_rx_register(struct net_device *netdev, struct vlan_group *grp)
                ctrl = IXGB_READ_REG(&adapter->hw, CTRL0);
                ctrl &= ~IXGB_CTRL0_VME;
                IXGB_WRITE_REG(&adapter->hw, CTRL0, ctrl);
-
-               /* disable VLAN filtering */
-
-               rctl = IXGB_READ_REG(&adapter->hw, RCTL);
-               rctl &= ~IXGB_RCTL_VFE;
-               IXGB_WRITE_REG(&adapter->hw, RCTL, rctl);
        }
 
        /* don't enable interrupts unless we are UP */
@@ -2198,7 +2166,7 @@ ixgb_restore_vlan(struct ixgb_adapter *adapter)
 
        if (adapter->vlgrp) {
                u16 vid;
-               for(vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) {
+               for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) {
                        if (!vlan_group_get_device(adapter->vlgrp, vid))
                                continue;
                        ixgb_vlan_rx_add_vid(adapter->netdev, vid);
@@ -2231,8 +2199,8 @@ static void ixgb_netpoll(struct net_device *dev)
  * This callback is called by the PCI subsystem whenever
  * a PCI bus error is detected.
  */
-static pci_ers_result_t ixgb_io_error_detected (struct pci_dev *pdev,
-                                    enum pci_channel_state state)
+static pci_ers_result_t ixgb_io_error_detected(struct pci_dev *pdev,
+                                               enum pci_channel_state state)
 {
        struct net_device *netdev = pci_get_drvdata(pdev);
        struct ixgb_adapter *adapter = netdev_priv(netdev);
@@ -2250,12 +2218,12 @@ static pci_ers_result_t ixgb_io_error_detected (struct pci_dev *pdev,
  * ixgb_io_slot_reset - called after the pci bus has been reset.
  * @pdev    pointer to pci device with error
  *
- * This callback is called after the PCI buss has been reset.
+ * This callback is called after the PCI bus has been reset.
  * Basically, this tries to restart the card from scratch.
  * This is a shortened version of the device probe/discovery code,
  * it resembles the first-half of the ixgb_probe() routine.
  */
-static pci_ers_result_t ixgb_io_slot_reset (struct pci_dev *pdev)
+static pci_ers_result_t ixgb_io_slot_reset(struct pci_dev *pdev)
 {
        struct net_device *netdev = pci_get_drvdata(pdev);
        struct ixgb_adapter *adapter = netdev_priv(netdev);
@@ -2299,7 +2267,7 @@ static pci_ers_result_t ixgb_io_slot_reset (struct pci_dev *pdev)
  * normal operation. Implementation resembles the second-half
  * of the ixgb_probe() routine.
  */
-static void ixgb_io_resume (struct pci_dev *pdev)
+static void ixgb_io_resume(struct pci_dev *pdev)
 {
        struct net_device *netdev = pci_get_drvdata(pdev);
        struct ixgb_adapter *adapter = netdev_priv(netdev);