]> err.no Git - linux-2.6/blobdiff - drivers/media/video/cx23885/cx23885-core.c
V4L/DVB (7005): cx23885: SRAM reallocation prior to analog video implementation
[linux-2.6] / drivers / media / video / cx23885 / cx23885-core.c
index 876d396fb7a3276d9b48a5b30eeddea21dab69f9..31723dd7cbdc0f65e0aebb974e5cd31d6ded7f5d 100644 (file)
@@ -73,14 +73,14 @@ static LIST_HEAD(cx23885_devlist);
  * 0x00010ea0 0x00010xxx Free
  */
 
-struct sram_channel cx23885_sram_channels[] = {
+static struct sram_channel cx23885_sram_channels[] = {
        [SRAM_CH01] = {
-               .name           = "test ch1",
+               .name           = "VID A",
                .cmds_start     = 0x10000,
-               .ctrl_start     = 0x10500,
-               .cdt            = 0x10900,
-               .fifo_start     = 0x3000,
-               .fifo_size      = 0x1000,
+               .ctrl_start     = 0x105b0,
+               .cdt            = 0x107b0,
+               .fifo_start     = 0x40,
+               .fifo_size      = 0x2800,
                .ptr1_reg       = DMA1_PTR1,
                .ptr2_reg       = DMA1_PTR2,
                .cnt1_reg       = DMA1_CNT1,
@@ -100,12 +100,12 @@ struct sram_channel cx23885_sram_channels[] = {
                .cnt2_reg       = DMA2_CNT2,
        },
        [SRAM_CH03] = {
-               .name           = "ch3",
-               .cmds_start     = 0x0,
-               .ctrl_start     = 0x0,
-               .cdt            = 0x0,
-               .fifo_start     = 0x0,
-               .fifo_size      = 0x0,
+               .name           = "TS1 B",
+               .cmds_start     = 0x100A0,
+               .ctrl_start     = 0x10630,
+               .cdt            = 0x10870,
+               .fifo_start     = 0x5000,
+               .fifo_size      = 0x1000,
                .ptr1_reg       = DMA3_PTR1,
                .ptr2_reg       = DMA3_PTR2,
                .cnt1_reg       = DMA3_CNT1,
@@ -139,7 +139,7 @@ struct sram_channel cx23885_sram_channels[] = {
                .name           = "TS2 C",
                .cmds_start     = 0x10140,
                .ctrl_start     = 0x10680,
-               .cdt            = 0x10480,
+               .cdt            = 0x108d0,
                .fifo_start     = 0x6000,
                .fifo_size      = 0x1000,
                .ptr1_reg       = DMA5_PTR1,
@@ -205,14 +205,14 @@ struct sram_channel cx23885_sram_channels[] = {
  * 0x00010ea0 0x00010xxx Free
  */
 
-struct sram_channel cx23887_sram_channels[] = {
+static struct sram_channel cx23887_sram_channels[] = {
        [SRAM_CH01] = {
-               .name           = "test ch1",
-               .cmds_start     = 0x0,
-               .ctrl_start     = 0x0,
-               .cdt            = 0x0,
-               .fifo_start     = 0x0,
-               .fifo_size      = 0x0,
+               .name           = "VID A",
+               .cmds_start     = 0x10000,
+               .ctrl_start     = 0x105b0,
+               .cdt            = 0x107b0,
+               .fifo_start     = 0x40,
+               .fifo_size      = 0x2800,
                .ptr1_reg       = DMA1_PTR1,
                .ptr2_reg       = DMA1_PTR2,
                .cnt1_reg       = DMA1_CNT1,
@@ -231,12 +231,12 @@ struct sram_channel cx23887_sram_channels[] = {
                .cnt2_reg       = DMA2_CNT2,
        },
        [SRAM_CH03] = {
-               .name           = "ch3",
-               .cmds_start     = 0x0,
-               .ctrl_start     = 0x0,
-               .cdt            = 0x0,
-               .fifo_start     = 0x0,
-               .fifo_size      = 0x0,
+               .name           = "TS1 B",
+               .cmds_start     = 0x100A0,
+               .ctrl_start     = 0x10780,
+               .cdt            = 0x10400,
+               .fifo_start     = 0x5000,
+               .fifo_size      = 0x1000,
                .ptr1_reg       = DMA3_PTR1,
                .ptr2_reg       = DMA3_PTR2,
                .cnt1_reg       = DMA3_CNT1,
@@ -270,7 +270,7 @@ struct sram_channel cx23887_sram_channels[] = {
                .name           = "TS2 C",
                .cmds_start     = 0x10140,
                .ctrl_start     = 0x10680,
-               .cdt            = 0x10480,
+               .cdt            = 0x108d0,
                .fifo_start     = 0x6000,
                .fifo_size      = 0x1000,
                .ptr1_reg       = DMA5_PTR1,
@@ -331,8 +331,8 @@ static int cx23885_risc_decode(u32 risc)
                [ RISC_WRITECR >> 28 ] = "writecr",
        };
        static int incr[16] = {
-               [ RISC_WRITE   >> 28 ] = 3, // 2
-               [ RISC_JUMP    >> 28 ] = 3, // 2
+               [ RISC_WRITE   >> 28 ] = 3,
+               [ RISC_JUMP    >> 28 ] = 3,
                [ RISC_SKIP    >> 28 ] = 1,
                [ RISC_SYNC    >> 28 ] = 1,
                [ RISC_WRITERM >> 28 ] = 3,
@@ -349,15 +349,15 @@ static int cx23885_risc_decode(u32 risc)
 
        printk("0x%08x [ %s", risc,
               instr[risc >> 28] ? instr[risc >> 28] : "INVALID");
-       for (i = ARRAY_SIZE(bits)-1; i >= 0; i--)
+       for (i = ARRAY_SIZE(bits) - 1; i >= 0; i--)
                if (risc & (1 << (i + 12)))
-                       printk(" %s",bits[i]);
+                       printk(" %s", bits[i]);
        printk(" count=%d ]\n", risc & 0xfff);
        return incr[risc >> 28] ? incr[risc >> 28] : 1;
 }
 
-void cx23885_wakeup(struct cx23885_tsport *port,
-                struct cx23885_dmaqueue *q, u32 count)
+static void cx23885_wakeup(struct cx23885_tsport *port,
+                          struct cx23885_dmaqueue *q, u32 count)
 {
        struct cx23885_dev *dev = port->dev;
        struct cx23885_buffer *buf;
@@ -368,46 +368,49 @@ void cx23885_wakeup(struct cx23885_tsport *port,
                        break;
                buf = list_entry(q->active.next,
                                 struct cx23885_buffer, vb.queue);
+
                /* count comes from the hw and is is 16bit wide --
                 * this trick handles wrap-arounds correctly for
                 * up to 32767 buffers in flight... */
                if ((s16) (count - buf->count) < 0)
                        break;
+
                do_gettimeofday(&buf->vb.ts);
-               dprintk(2,"[%p/%d] wakeup reg=%d buf=%d\n",buf,buf->vb.i,
+               dprintk(2, "[%p/%d] wakeup reg=%d buf=%d\n", buf, buf->vb.i,
                        count, buf->count);
-               buf->vb.state = STATE_DONE;
+               buf->vb.state = VIDEOBUF_DONE;
                list_del(&buf->vb.queue);
                wake_up(&buf->vb.done);
        }
        if (list_empty(&q->active)) {
                del_timer(&q->timeout);
        } else {
-               mod_timer(&q->timeout, jiffies+BUFFER_TIMEOUT);
+               mod_timer(&q->timeout, jiffies + BUFFER_TIMEOUT);
        }
        if (bc != 1)
-               printk("%s: %d buffers handled (should be 1)\n",__FUNCTION__,bc);
+               printk("%s: %d buffers handled (should be 1)\n",
+                      __FUNCTION__, bc);
 }
-void cx23885_sram_channel_dump(struct cx23885_dev *dev,
-                           struct sram_channel *ch);
 
-int cx23885_sram_channel_setup(struct cx23885_dev *dev,
-                           struct sram_channel *ch,
-                           unsigned int bpl, u32 risc)
+static int cx23885_sram_channel_setup(struct cx23885_dev *dev,
+                                     struct sram_channel *ch,
+                                     unsigned int bpl, u32 risc)
 {
-       unsigned int i,lines;
+       unsigned int i, lines;
        u32 cdt;
 
        if (ch->cmds_start == 0)
        {
-               dprintk(1, "%s() Erasing channel [%s]\n",__FUNCTION__, ch->name);
+               dprintk(1, "%s() Erasing channel [%s]\n", __FUNCTION__,
+                       ch->name);
                cx_write(ch->ptr1_reg, 0);
                cx_write(ch->ptr2_reg, 0);
                cx_write(ch->cnt2_reg, 0);
                cx_write(ch->cnt1_reg, 0);
                return 0;
        } else {
-               dprintk(1, "%s() Configuring channel [%s]\n",__FUNCTION__, ch->name);
+               dprintk(1, "%s() Configuring channel [%s]\n", __FUNCTION__,
+                       ch->name);
        }
 
        bpl   = (bpl + 7) & ~7; /* alignment */
@@ -417,13 +420,14 @@ int cx23885_sram_channel_setup(struct cx23885_dev *dev,
                lines = 6;
        BUG_ON(lines < 2);
 
-       cx_write(8+0, cpu_to_le32(RISC_JUMP | RISC_IRQ1 | RISC_CNT_INC) );
-       cx_write(8+4, cpu_to_le32(8) );
-       cx_write(8+8, cpu_to_le32(0) );
+       cx_write(8 + 0, cpu_to_le32(RISC_JUMP | RISC_IRQ1 | RISC_CNT_INC) );
+       cx_write(8 + 4, cpu_to_le32(8) );
+       cx_write(8 + 8, cpu_to_le32(0) );
 
        /* write CDT */
        for (i = 0; i < lines; i++) {
-               dprintk(2, "%s() 0x%08x <- 0x%08x\n", __FUNCTION__, cdt + 16*i, ch->fifo_start + bpl*i);
+               dprintk(2, "%s() 0x%08x <- 0x%08x\n", __FUNCTION__, cdt + 16*i,
+                       ch->fifo_start + bpl*i);
                cx_write(cdt + 16*i, ch->fifo_start + bpl*i);
                cx_write(cdt + 16*i +  4, 0);
                cx_write(cdt + 16*i +  8, 0);
@@ -452,8 +456,8 @@ int cx23885_sram_channel_setup(struct cx23885_dev *dev,
        cx_write(ch->cnt2_reg, (lines*16) >> 3);
        cx_write(ch->cnt1_reg, (bpl >> 3) -1);
 
-       dprintk(2,"[bridged %d] sram setup %s: bpl=%d lines=%d\n",
-               cx23885_boards[dev->board].bridge,
+       dprintk(2,"[bridge %d] sram setup %s: bpl=%d lines=%d\n",
+               dev->bridge,
                ch->name,
                bpl,
                lines);
@@ -461,8 +465,8 @@ int cx23885_sram_channel_setup(struct cx23885_dev *dev,
        return 0;
 }
 
-void cx23885_sram_channel_dump(struct cx23885_dev *dev,
-                           struct sram_channel *ch)
+static void cx23885_sram_channel_dump(struct cx23885_dev *dev,
+                                     struct sram_channel *ch)
 {
        static char *name[] = {
                "init risc lo",
@@ -481,7 +485,7 @@ void cx23885_sram_channel_dump(struct cx23885_dev *dev,
                "line / byte",
        };
        u32 risc;
-       unsigned int i,j,n;
+       unsigned int i, j, n;
 
        printk("%s: %s - dma channel status dump\n",
               dev->name, ch->name);
@@ -491,16 +495,19 @@ void cx23885_sram_channel_dump(struct cx23885_dev *dev,
                       cx_read(ch->cmds_start + 4*i));
 
        for (i = 0; i < 4; i++) {
-               risc = cx_read(ch->cmds_start + 4 * (i+14));
+               risc = cx_read(ch->cmds_start + 4 * (i + 14));
                printk("%s:   risc%d: ", dev->name, i);
                cx23885_risc_decode(risc);
        }
        for (i = 0; i < (64 >> 2); i += n) {
-               risc = cx_read(ch->ctrl_start + 4 * i); /* No consideration for bits 63-32 */
-               printk("%s:   (0x%08x) iq %x: ", dev->name, ch->ctrl_start + 4 * i, i);
+               risc = cx_read(ch->ctrl_start + 4 * i);
+               /* No consideration for bits 63-32 */
+
+               printk("%s:   (0x%08x) iq %x: ", dev->name,
+                      ch->ctrl_start + 4 * i, i);
                n = cx23885_risc_decode(risc);
                for (j = 1; j < n; j++) {
-                       risc = cx_read(ch->ctrl_start + 4 * (i+j));
+                       risc = cx_read(ch->ctrl_start + 4 * (i + j));
                        printk("%s:   iq %x: 0x%08x [ arg #%d ]\n",
                               dev->name, i+j, risc, j);
                }
@@ -509,7 +516,7 @@ void cx23885_sram_channel_dump(struct cx23885_dev *dev,
        printk("%s: fifo: 0x%08x -> 0x%x\n",
               dev->name, ch->fifo_start, ch->fifo_start+ch->fifo_size);
        printk("%s: ctrl: 0x%08x -> 0x%x\n",
-              dev->name, ch->ctrl_start, ch->ctrl_start+6*16);
+              dev->name, ch->ctrl_start, ch->ctrl_start + 6*16);
        printk("%s:   ptr1_reg: 0x%08x\n",
               dev->name, cx_read(ch->ptr1_reg));
        printk("%s:   ptr2_reg: 0x%08x\n",
@@ -520,10 +527,11 @@ void cx23885_sram_channel_dump(struct cx23885_dev *dev,
               dev->name, cx_read(ch->cnt2_reg));
 }
 
-void cx23885_risc_disasm(struct cx23885_tsport *port, struct btcx_riscmem *risc)
+static void cx23885_risc_disasm(struct cx23885_tsport *port,
+                               struct btcx_riscmem *risc)
 {
        struct cx23885_dev *dev = port->dev;
-       unsigned int i,j,n;
+       unsigned int i, j, n;
 
        printk("%s: risc disasm: %p [dma=0x%08lx]\n",
               dev->name, risc->cpu, (unsigned long)risc->dma);
@@ -532,13 +540,13 @@ void cx23885_risc_disasm(struct cx23885_tsport *port, struct btcx_riscmem *risc)
                n = cx23885_risc_decode(risc->cpu[i]);
                for (j = 1; j < n; j++)
                        printk("%s:   %04d: 0x%08x [ arg #%d ]\n",
-                              dev->name, i+j, risc->cpu[i+j], j);
+                              dev->name, i + j, risc->cpu[i + j], j);
                if (risc->cpu[i] == RISC_JUMP)
                        break;
        }
 }
 
-void cx23885_shutdown(struct cx23885_dev *dev)
+static void cx23885_shutdown(struct cx23885_dev *dev)
 {
        /* disable RISC controller */
        cx_write(DEV_CNTRL2, 0);
@@ -568,7 +576,7 @@ void cx23885_shutdown(struct cx23885_dev *dev)
 
 }
 
-void cx23885_reset(struct cx23885_dev *dev)
+static void cx23885_reset(struct cx23885_dev *dev)
 {
        dprintk(1, "%s()\n", __FUNCTION__);
 
@@ -584,10 +592,9 @@ void cx23885_reset(struct cx23885_dev *dev)
 
        mdelay(100);
 
-#if SRAM
        cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH01 ], 188*4, 0);
        cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH02 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH03 ], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH03 ], 188*4, 0);
        cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH04 ], 128, 0);
        cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH05 ], 128, 0);
        cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH06 ], 188*4, 0);
@@ -595,50 +602,7 @@ void cx23885_reset(struct cx23885_dev *dev)
        cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH08 ], 128, 0);
        cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH09 ], 128, 0);
 
-#else
-       // FIXME: Put a pointer to the sram_channel table in cx23885_dev
-       // and stop all this ugly switch/if code
-       switch(cx23885_boards[dev->board].bridge) {
-       case CX23885_BRIDGE_885:
-               cx23885_sram_channel_setup(dev, &cx23885_sram_channels[ SRAM_CH01 ], 188*4, 0);
-               cx23885_sram_channel_setup(dev, &cx23885_sram_channels[ SRAM_CH02 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23885_sram_channels[ SRAM_CH03 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23885_sram_channels[ SRAM_CH04 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23885_sram_channels[ SRAM_CH05 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23885_sram_channels[ SRAM_CH06 ], 188*4, 0);
-               cx23885_sram_channel_setup(dev, &cx23885_sram_channels[ SRAM_CH07 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23885_sram_channels[ SRAM_CH08 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23885_sram_channels[ SRAM_CH09 ], 128, 0);
-               break;
-       case CX23885_BRIDGE_887:
-               cx23885_sram_channel_setup(dev, &cx23887_sram_channels[ SRAM_CH01 ], 188*4, 0);
-               cx23885_sram_channel_setup(dev, &cx23887_sram_channels[ SRAM_CH02 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23887_sram_channels[ SRAM_CH03 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23887_sram_channels[ SRAM_CH04 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23887_sram_channels[ SRAM_CH05 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23887_sram_channels[ SRAM_CH06 ], 188*4, 0);
-               cx23885_sram_channel_setup(dev, &cx23887_sram_channels[ SRAM_CH07 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23887_sram_channels[ SRAM_CH08 ], 128, 0);
-               cx23885_sram_channel_setup(dev, &cx23887_sram_channels[ SRAM_CH09 ], 128, 0);
-               break;
-       default:
-               printk(KERN_ERR "%s() error, default case", __FUNCTION__ );
-       }
-#endif
-
-       switch(dev->board) {
-       case CX23885_BOARD_HAUPPAUGE_HVR1800:
-               /* GPIO-0 656_CLK */
-               /* GPIO-1 656_D0 */
-               /* GPIO-2 8295A Reset */
-               /* GPIO-3-10 cx23417 data0-7 */
-               /* GPIO-11-14 cx23417 addr0-3 */
-               /* GPIO-15-18 cx23417 READY, CS, RD, WR */
-               /* GPIO-19 IR_RX */
-               dprintk( 1, "%s() Configuring HVR1800 GPIO's\n", __FUNCTION__);
-               // FIXME: Analog requires the tuner is brought out of reset
-               break;
-       }
+       cx23885_gpio_setup(dev);
 }
 
 
@@ -646,19 +610,21 @@ static int cx23885_pci_quirks(struct cx23885_dev *dev)
 {
        dprintk(1, "%s()\n", __FUNCTION__);
 
-       switch(dev->board) {
-       case CX23885_BOARD_HAUPPAUGE_HVR1800lp:
+       /* The cx23885 bridge has a weird bug which causes NMI to be asserted
+        * when DMA begins if RDR_TLCTL0 bit4 is not cleared. It does not
+        * occur on the cx23887 bridge.
+        */
+       if(dev->bridge == CX23885_BRIDGE_885)
                cx_clear(RDR_TLCTL0, 1 << 4);
-               break;
-       }
+
        return 0;
 }
 
 static int get_resources(struct cx23885_dev *dev)
 {
        if (request_mem_region(pci_resource_start(dev->pci,0),
-                               pci_resource_len(dev->pci,0),
-                               dev->name))
+                              pci_resource_len(dev->pci,0),
+                              dev->name))
                return 0;
 
        printk(KERN_ERR "%s: can't get MMIO memory @ 0x%llx\n",
@@ -668,22 +634,112 @@ static int get_resources(struct cx23885_dev *dev)
 }
 
 static void cx23885_timeout(unsigned long data);
-int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
-                     u32 reg, u32 mask, u32 value);
+static int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
+                               u32 reg, u32 mask, u32 value);
 
-static int cx23885_ir_init(struct cx23885_dev *dev)
+static int cx23885_init_tsport(struct cx23885_dev *dev, struct cx23885_tsport *port, int portno)
 {
-       dprintk(1, "%s()\n", __FUNCTION__);
-
-       switch (dev->board) {
-       case CX23885_BOARD_HAUPPAUGE_HVR1800:
-               dprintk(1, "%s() FIXME - Implement IR support\n", __FUNCTION__);
+       dprintk(1, "%s(portno=%d)\n", __FUNCTION__, portno);
+
+       /* Transport bus init dma queue  - Common settings */
+       port->dma_ctl_val        = 0x11; /* Enable RISC controller and Fifo */
+       port->ts_int_msk_val     = 0x1111; /* TS port bits for RISC */
+
+       spin_lock_init(&port->slock);
+       port->dev = dev;
+       port->nr = portno;
+
+       INIT_LIST_HEAD(&port->mpegq.active);
+       INIT_LIST_HEAD(&port->mpegq.queued);
+       port->mpegq.timeout.function = cx23885_timeout;
+       port->mpegq.timeout.data = (unsigned long)port;
+       init_timer(&port->mpegq.timeout);
+
+       switch(portno) {
+       case 1:
+               port->reg_gpcnt          = VID_B_GPCNT;
+               port->reg_gpcnt_ctl      = VID_B_GPCNT_CTL;
+               port->reg_dma_ctl        = VID_B_DMA_CTL;
+               port->reg_lngth          = VID_B_LNGTH;
+               port->reg_hw_sop_ctrl    = VID_B_HW_SOP_CTL;
+               port->reg_gen_ctrl       = VID_B_GEN_CTL;
+               port->reg_bd_pkt_status  = VID_B_BD_PKT_STATUS;
+               port->reg_sop_status     = VID_B_SOP_STATUS;
+               port->reg_fifo_ovfl_stat = VID_B_FIFO_OVFL_STAT;
+               port->reg_vld_misc       = VID_B_VLD_MISC;
+               port->reg_ts_clk_en      = VID_B_TS_CLK_EN;
+               port->reg_src_sel        = VID_B_SRC_SEL;
+               port->reg_ts_int_msk     = VID_B_INT_MSK;
+               port->reg_ts_int_stat   = VID_B_INT_STAT;
+               port->sram_chno          = SRAM_CH03; /* VID_B */
+               port->pci_irqmask        = 0x02; /* VID_B bit1 */
+               break;
+       case 2:
+               port->reg_gpcnt          = VID_C_GPCNT;
+               port->reg_gpcnt_ctl      = VID_C_GPCNT_CTL;
+               port->reg_dma_ctl        = VID_C_DMA_CTL;
+               port->reg_lngth          = VID_C_LNGTH;
+               port->reg_hw_sop_ctrl    = VID_C_HW_SOP_CTL;
+               port->reg_gen_ctrl       = VID_C_GEN_CTL;
+               port->reg_bd_pkt_status  = VID_C_BD_PKT_STATUS;
+               port->reg_sop_status     = VID_C_SOP_STATUS;
+               port->reg_fifo_ovfl_stat = VID_C_FIFO_OVFL_STAT;
+               port->reg_vld_misc       = VID_C_VLD_MISC;
+               port->reg_ts_clk_en      = VID_C_TS_CLK_EN;
+               port->reg_src_sel        = 0;
+               port->reg_ts_int_msk     = VID_C_INT_MSK;
+               port->reg_ts_int_stat    = VID_C_INT_STAT;
+               port->sram_chno          = SRAM_CH06; /* VID_C */
+               port->pci_irqmask        = 0x04; /* VID_C bit2 */
                break;
+       default:
+               BUG();
        }
 
+       cx23885_risc_stopper(dev->pci, &port->mpegq.stopper,
+                    port->reg_dma_ctl, port->dma_ctl_val, 0x00);
+
        return 0;
 }
 
+static void cx23885_dev_checkrevision(struct cx23885_dev *dev)
+{
+       switch (cx_read(RDR_CFG2) & 0xff) {
+       case 0x00:
+               /* cx23885 */
+               dev->hwrevision = 0xa0;
+               break;
+       case 0x01:
+               /* CX23885-12Z */
+               dev->hwrevision = 0xa1;
+               break;
+       case 0x02:
+               /* CX23885-13Z */
+               dev->hwrevision = 0xb0;
+               break;
+       case 0x03:
+               /* CX23888-22Z */
+               dev->hwrevision = 0xc0;
+               break;
+       case 0x0e:
+               /* CX23887-15Z */
+               dev->hwrevision = 0xc0;
+       case 0x0f:
+               /* CX23887-14Z */
+               dev->hwrevision = 0xb1;
+               break;
+       default:
+               printk(KERN_ERR "%s() New hardware revision found 0x%x\n",
+                       __FUNCTION__, dev->hwrevision);
+       }
+       if (dev->hwrevision)
+               printk(KERN_INFO "%s() Hardware revision = 0x%02x\n",
+                       __FUNCTION__, dev->hwrevision);
+       else
+               printk(KERN_ERR "%s() Hardware revision unknown 0x%x\n",
+                       __FUNCTION__, dev->hwrevision);
+}
+
 static int cx23885_dev_setup(struct cx23885_dev *dev)
 {
        int i;
@@ -693,6 +749,39 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
        atomic_inc(&dev->refcount);
 
        dev->nr = cx23885_devcount++;
+       sprintf(dev->name, "cx23885[%d]", dev->nr);
+
+       mutex_lock(&devlist);
+       list_add_tail(&dev->devlist, &cx23885_devlist);
+       mutex_unlock(&devlist);
+
+       /* Configure the internal memory */
+       if(dev->pci->device == 0x8880) {
+               dev->bridge = CX23885_BRIDGE_887;
+               dev->sram_channels = cx23887_sram_channels;
+       } else
+       if(dev->pci->device == 0x8852) {
+               dev->bridge = CX23885_BRIDGE_885;
+               dev->sram_channels = cx23885_sram_channels;
+       } else
+               BUG();
+
+       dprintk(1, "%s() Memory configured for PCIe bridge type %d\n",
+               __FUNCTION__, dev->bridge);
+
+       /* board config */
+       dev->board = UNSET;
+       if (card[dev->nr] < cx23885_bcount)
+               dev->board = card[dev->nr];
+       for (i = 0; UNSET == dev->board  &&  i < cx23885_idcount; i++)
+               if (dev->pci->subsystem_vendor == cx23885_subids[i].subvendor &&
+                   dev->pci->subsystem_device == cx23885_subids[i].subdevice)
+                       dev->board = cx23885_subids[i].card;
+       if (UNSET == dev->board) {
+               dev->board = CX23885_BOARD_UNKNOWN;
+               cx23885_card_list(dev);
+       }
+
        dev->pci_bus  = dev->pci->bus->number;
        dev->pci_slot = PCI_SLOT(dev->pci->devfn);
        dev->pci_irqmask = 0x001f00;
@@ -722,98 +811,40 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
        dev->i2c_bus[2].dev = dev;
        dev->i2c_bus[2].reg_stat  = I2C3_STAT;
        dev->i2c_bus[2].reg_ctrl  = I2C3_CTRL;
-       dev->i2c_bus[2].reg_addr  = I2C2_ADDR;
+       dev->i2c_bus[2].reg_addr  = I2C3_ADDR;
        dev->i2c_bus[2].reg_rdata = I2C3_RDATA;
        dev->i2c_bus[2].reg_wdata = I2C3_WDATA;
        dev->i2c_bus[2].i2c_period = (0x07 << 24); /* 1.95MHz */
 
-       /* Transport bus init dma queue */
-       spin_lock_init(&dev->ts2.slock);
-       dev->ts2.dev = dev;
-       dev->ts2.nr = 2;
-       dev->ts2.sram_chno = SRAM_CH06;
-       INIT_LIST_HEAD(&dev->ts2.mpegq.active);
-       INIT_LIST_HEAD(&dev->ts2.mpegq.queued);
-       dev->ts2.mpegq.timeout.function = cx23885_timeout;
-       dev->ts2.mpegq.timeout.data     = (unsigned long)&dev->ts2;
-       init_timer(&dev->ts2.mpegq.timeout);
-
-       dev->ts2.reg_gpcnt = VID_C_GPCNT;
-       dev->ts2.reg_gpcnt_ctl = VID_C_GPCNT_CTL;
-       dev->ts2.reg_dma_ctl = VID_C_DMA_CTL;
-       dev->ts2.reg_lngth = VID_C_LNGTH;
-       dev->ts2.reg_hw_sop_ctrl = VID_C_HW_SOP_CTL;
-       dev->ts2.reg_gen_ctrl = VID_C_GEN_CTL;
-       dev->ts2.reg_bd_pkt_status = VID_C_BD_PKT_STATUS;
-       dev->ts2.reg_sop_status = VID_C_SOP_STATUS;
-       dev->ts2.reg_fifo_ovfl_stat = VID_C_FIFO_OVFL_STAT;
-       dev->ts2.reg_vld_misc = VID_C_VLD_MISC;
-       dev->ts2.reg_ts_clk_en = VID_C_TS_CLK_EN;
-       dev->ts2.reg_ts_int_msk = VID_C_INT_MSK;
-
-       // FIXME: Make this board specific
-       dev->ts2.pci_irqmask = 0x04; /* TS Port 2 bit */
-       dev->ts2.dma_ctl_val = 0x11; /* Enable RISC controller and Fifo */
-       dev->ts2.ts_int_msk_val = 0x1111; /* TS port bits for RISC */
-       dev->ts2.gen_ctrl_val = 0xc; /* Serial bus + punctured clock */
-       dev->ts2.ts_clk_en_val = 0x1; /* Enable TS_CLK */
-
-       cx23885_risc_stopper(dev->pci, &dev->ts2.mpegq.stopper, dev->ts2.reg_dma_ctl, dev->ts2.dma_ctl_val, 0x00);
-
-       sprintf(dev->name,"cx23885[%d]", dev->nr);
+       if(cx23885_boards[dev->board].portb == CX23885_MPEG_DVB)
+               cx23885_init_tsport(dev, &dev->ts1, 1);
+
+       if(cx23885_boards[dev->board].portc == CX23885_MPEG_DVB)
+               cx23885_init_tsport(dev, &dev->ts2, 2);
 
        if (get_resources(dev) < 0) {
                printk(KERN_ERR "CORE %s No more PCIe resources for "
-                       "subsystem: %04x:%04x\n",
-                       dev->name, dev->pci->subsystem_vendor,
-                       dev->pci->subsystem_device);
+                      "subsystem: %04x:%04x\n",
+                      dev->name, dev->pci->subsystem_vendor,
+                      dev->pci->subsystem_device);
 
                cx23885_devcount--;
-               goto fail_free;
+               return -ENODEV;
        }
 
-       mutex_lock(&devlist);
-       list_add_tail(&dev->devlist, &cx23885_devlist);
-       mutex_unlock(&devlist);
-
        /* PCIe stuff */
        dev->lmmio = ioremap(pci_resource_start(dev->pci,0),
-                             pci_resource_len(dev->pci,0));
+                            pci_resource_len(dev->pci,0));
 
        dev->bmmio = (u8 __iomem *)dev->lmmio;
 
-       cx23885_pci_quirks(dev);
-
-       /* board config */
-       dev->board = UNSET;
-       if (card[dev->nr] < cx23885_bcount)
-               dev->board = card[dev->nr];
-       for (i = 0; UNSET == dev->board  &&  i < cx23885_idcount; i++)
-               if (dev->pci->subsystem_vendor == cx23885_subids[i].subvendor &&
-                   dev->pci->subsystem_device == cx23885_subids[i].subdevice)
-                       dev->board = cx23885_subids[i].card;
-       if (UNSET == dev->board) {
-               dev->board = CX23885_BOARD_UNKNOWN;
-               cx23885_card_list(dev);
-       }
        printk(KERN_INFO "CORE %s: subsystem: %04x:%04x, board: %s [card=%d,%s]\n",
-               dev->name, dev->pci->subsystem_vendor,
-               dev->pci->subsystem_device, cx23885_boards[dev->board].name,
-               dev->board, card[dev->nr] == dev->board ?
-               "insmod option" : "autodetected");
-
-       /* Configure the hardware internal memory for fifos */
-       switch(cx23885_boards[dev->board].bridge) {
-       case CX23885_BRIDGE_UNDEFINED:
-       case CX23885_BRIDGE_885:
-               dev->sram_channels = cx23885_sram_channels;
-               break;
-       case CX23885_BRIDGE_887:
-               dev->sram_channels = cx23887_sram_channels;
-               break;
-       default:
-               printk(KERN_ERR "%s() error, default case", __FUNCTION__ );
-       }
+              dev->name, dev->pci->subsystem_vendor,
+              dev->pci->subsystem_device, cx23885_boards[dev->board].name,
+              dev->board, card[dev->nr] == dev->board ?
+              "insmod option" : "autodetected");
+
+       cx23885_pci_quirks(dev);
 
        /* init hardware */
        cx23885_reset(dev);
@@ -822,22 +853,29 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
        cx23885_i2c_register(&dev->i2c_bus[1]);
        cx23885_i2c_register(&dev->i2c_bus[2]);
        cx23885_call_i2c_clients (&dev->i2c_bus[0], TUNER_SET_STANDBY, NULL);
-
        cx23885_card_setup(dev);
        cx23885_ir_init(dev);
 
-       if (cx23885_dvb_register(&dev->ts2) < 0) {
-               printk(KERN_ERR "%s() Failed to register dvb adapters\n", __FUNCTION__);
+       if(cx23885_boards[dev->board].portb == CX23885_MPEG_DVB) {
+               if (cx23885_dvb_register(&dev->ts1) < 0) {
+                       printk(KERN_ERR "%s() Failed to register dvb adapters on VID_B\n",
+                              __FUNCTION__);
+               }
        }
 
-       return 0;
+       if(cx23885_boards[dev->board].portc == CX23885_MPEG_DVB) {
+               if (cx23885_dvb_register(&dev->ts2) < 0) {
+                       printk(KERN_ERR "%s() Failed to register dvb adapters on VID_C\n",
+                              __FUNCTION__);
+               }
+       }
 
-fail_free:
-       kfree(dev);
-       return -ENODEV;
+       cx23885_dev_checkrevision(dev);
+
+       return 0;
 }
 
-void cx23885_dev_unregister(struct cx23885_dev *dev)
+static void cx23885_dev_unregister(struct cx23885_dev *dev)
 {
        release_mem_region(pci_resource_start(dev->pci,0),
                           pci_resource_len(dev->pci,0));
@@ -845,7 +883,12 @@ void cx23885_dev_unregister(struct cx23885_dev *dev)
        if (!atomic_dec_and_test(&dev->refcount))
                return;
 
-       cx23885_dvb_unregister(&dev->ts2);
+       if(cx23885_boards[dev->board].portb == CX23885_MPEG_DVB)
+               cx23885_dvb_unregister(&dev->ts1);
+
+       if(cx23885_boards[dev->board].portc == CX23885_MPEG_DVB)
+               cx23885_dvb_unregister(&dev->ts2);
+
        cx23885_i2c_unregister(&dev->i2c_bus[2]);
        cx23885_i2c_unregister(&dev->i2c_bus[1]);
        cx23885_i2c_unregister(&dev->i2c_bus[0]);
@@ -854,12 +897,12 @@ void cx23885_dev_unregister(struct cx23885_dev *dev)
 }
 
 static u32* cx23885_risc_field(u32 *rp, struct scatterlist *sglist,
-                           unsigned int offset, u32 sync_line,
-                           unsigned int bpl, unsigned int padding,
-                           unsigned int lines)
+                              unsigned int offset, u32 sync_line,
+                              unsigned int bpl, unsigned int padding,
+                              unsigned int lines)
 {
        struct scatterlist *sg;
-       unsigned int line,todo;
+       unsigned int line, todo;
 
        /* sync instruction */
        if (sync_line != NO_SYNC_LINE)
@@ -907,50 +950,12 @@ static u32* cx23885_risc_field(u32 *rp, struct scatterlist *sglist,
        return rp;
 }
 
-int cx23885_risc_buffer(struct pci_dev *pci, struct btcx_riscmem *risc,
-                    struct scatterlist *sglist,
-                    unsigned int top_offset, unsigned int bottom_offset,
-                    unsigned int bpl, unsigned int padding, unsigned int lines)
-{
-       u32 instructions,fields;
-       u32 *rp;
-       int rc;
-
-       fields = 0;
-       if (UNSET != top_offset)
-               fields++;
-       if (UNSET != bottom_offset)
-               fields++;
-
-       /* estimate risc mem: worst case is one write per page border +
-          one write per scan line + syncs + jump (all 2 dwords).  Padding
-          can cause next bpl to start close to a page border.  First DMA
-          region may be smaller than PAGE_SIZE */
-       /* write and jump need and extra dword */
-       instructions  = fields * (1 + ((bpl + padding) * lines) / PAGE_SIZE + lines);
-       instructions += 2;
-       //if ((rc = btcx_riscmem_alloc(pci,risc,instructions*8)) < 0)
-       if ((rc = btcx_riscmem_alloc(pci,risc,instructions*12)) < 0)
-               return rc;
-
-       /* write risc instructions */
-       rp = risc->cpu;
-       if (UNSET != top_offset)
-               rp = cx23885_risc_field(rp, sglist, top_offset, 0,
-                                    bpl, padding, lines);
-       if (UNSET != bottom_offset)
-               rp = cx23885_risc_field(rp, sglist, bottom_offset, 0x200,
-                                    bpl, padding, lines);
-
-       /* save pointer to jmp instruction address */
-       risc->jmp = rp;
-       BUG_ON((risc->jmp - risc->cpu + 2) * sizeof (*risc->cpu) > risc->size);
-       return 0;
-}
 
-int cx23885_risc_databuffer(struct pci_dev *pci, struct btcx_riscmem *risc,
-                        struct scatterlist *sglist, unsigned int bpl,
-                        unsigned int lines)
+static int cx23885_risc_databuffer(struct pci_dev *pci,
+                                  struct btcx_riscmem *risc,
+                                  struct scatterlist *sglist,
+                                  unsigned int bpl,
+                                  unsigned int lines)
 {
        u32 instructions;
        u32 *rp;
@@ -964,7 +969,6 @@ int cx23885_risc_databuffer(struct pci_dev *pci, struct btcx_riscmem *risc,
        instructions  = 1 + (bpl * lines) / PAGE_SIZE + lines;
        instructions += 1;
 
-       //if ((rc = btcx_riscmem_alloc(pci,risc,instructions*8)) < 0)
        if ((rc = btcx_riscmem_alloc(pci,risc,instructions*12)) < 0)
                return rc;
 
@@ -978,8 +982,8 @@ int cx23885_risc_databuffer(struct pci_dev *pci, struct btcx_riscmem *risc,
        return 0;
 }
 
-int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
-                     u32 reg, u32 mask, u32 value)
+static int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
+                               u32 reg, u32 mask, u32 value)
 {
        u32 *rp;
        int rc;
@@ -989,7 +993,6 @@ int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
 
        /* write risc instructions */
        rp = risc->cpu;
-       //*(rp++) = cpu_to_le32(RISC_WRITECR  | RISC_IRQ2 | RISC_IMM);
        *(rp++) = cpu_to_le32(RISC_WRITECR  | RISC_IRQ2);
        *(rp++) = cpu_to_le32(reg);
        *(rp++) = cpu_to_le32(value);
@@ -1002,143 +1005,78 @@ int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
 
 void cx23885_free_buffer(struct videobuf_queue *q, struct cx23885_buffer *buf)
 {
+       struct videobuf_dmabuf *dma = videobuf_to_dma(&buf->vb);
+
        BUG_ON(in_interrupt());
-       videobuf_waiton(&buf->vb,0,0);
-       videobuf_dma_unmap(q, &buf->vb.dma);
-       videobuf_dma_free(&buf->vb.dma);
+       videobuf_waiton(&buf->vb, 0, 0);
+       videobuf_dma_unmap(q, dma);
+       videobuf_dma_free(dma);
        btcx_riscmem_free((struct pci_dev *)q->dev, &buf->risc);
-       buf->vb.state = STATE_NEEDS_INIT;
+       buf->vb.state = VIDEOBUF_NEEDS_INIT;
 }
 
 static int cx23885_start_dma(struct cx23885_tsport *port,
-                           struct cx23885_dmaqueue *q,
-                           struct cx23885_buffer   *buf)
+                            struct cx23885_dmaqueue *q,
+                            struct cx23885_buffer   *buf)
 {
        struct cx23885_dev *dev = port->dev;
 
        dprintk(1, "%s() w: %d, h: %d, f: %d\n", __FUNCTION__,
-                       buf->vb.width, buf->vb.height, buf->vb.field);
+               buf->vb.width, buf->vb.height, buf->vb.field);
 
-#if SRAM
        /* setup fifo + format */
        cx23885_sram_channel_setup(dev,
-               &dev->sram_channels[ port->sram_chno ],
-               port->ts_packet_size, buf->risc.dma);
-       if(debug > 5)
+                                  &dev->sram_channels[ port->sram_chno ],
+                                  port->ts_packet_size, buf->risc.dma);
+       if(debug > 5) {
                cx23885_sram_channel_dump(dev, &dev->sram_channels[ port->sram_chno ] );
-#else
-       // FIXME: Put a pointer to the sram_channel table in cx23885_dev
-       // and stop all this ugly switch/if code
-       switch(cx23885_boards[dev->board].bridge) {
-       case CX23885_BRIDGE_885:
-               cx23885_sram_channel_setup(dev,
-                       &cx23885_sram_channels[ port->sram_chno ],
-                       port->ts_packet_size, buf->risc.dma);
-               if(debug > 5)
-                       cx23885_sram_channel_dump(dev, &cx23885_sram_channels[ port->sram_chno ] );
-               break;
-       case CX23885_BRIDGE_887:
-               cx23885_sram_channel_setup(dev,
-                       &cx23887_sram_channels[ port->sram_chno ],
-                       port->ts_packet_size, buf->risc.dma);
-               if(debug > 5)
-                       cx23885_sram_channel_dump(dev, &cx23887_sram_channels[ port->sram_chno ] );
-               break;
-       default:
-               printk(KERN_ERR "%s() error, default case", __FUNCTION__ );
-       }
-#endif
-
-       if(debug > 5)
                cx23885_risc_disasm(port, &buf->risc);
+       }
 
        /* write TS length to chip */
        cx_write(port->reg_lngth, buf->vb.width);
 
-       if (!(cx23885_boards[dev->board].portc & CX23885_MPEG_DVB)) {
-               printk( "%s() Failed. Unsupported value in .portc (0x%08x)\n", __FUNCTION__,
+       if ( (!(cx23885_boards[dev->board].portb & CX23885_MPEG_DVB)) &&
+               (!(cx23885_boards[dev->board].portc & CX23885_MPEG_DVB)) ) {
+               printk( "%s() Failed. Unsupported value in .portb/c (0x%08x)/(0x%08x)\n",
+                       __FUNCTION__,
+                       cx23885_boards[dev->board].portb,
                        cx23885_boards[dev->board].portc );
                return -EINVAL;
        }
 
-       // FIXME: review the need for these two lines
-       dprintk( 1, "%s() doing .dvb\n", __FUNCTION__);
        udelay(100);
 
+       /* If the port supports SRC SELECT, configure it */
+       if(port->reg_src_sel)
+               cx_write(port->reg_src_sel, port->src_sel_val);
+
        cx_write(port->reg_hw_sop_ctrl, 0x47 << 16 | 188 << 4);
        cx_write(port->reg_ts_clk_en, port->ts_clk_en_val);
-
-       // FIXME: review the need for this
-       cx_write(GPIO2, 0x00);
-
-       switch (dev->board) {
-       case CX23885_BOARD_HAUPPAUGE_HVR1800lp:
-       case CX23885_BOARD_HAUPPAUGE_HVR1800:
-               cx_write(port->reg_vld_misc, 0x00);
-               dprintk(1, "%s() Configuring HVR1800/lp/1500 board\n", __FUNCTION__);
-               break;
-       default:
-               // FIXME
-               printk(KERN_ERR "%s() error, default case", __FUNCTION__ );
-       }
-
+       cx_write(port->reg_vld_misc, 0x00);
        cx_write(port->reg_gen_ctrl, port->gen_ctrl_val);
        udelay(100);
 
+       // NOTE: this is 2 (reserved) for portb, does it matter?
        /* reset counter to zero */
        cx_write(port->reg_gpcnt_ctl, 3);
        q->count = 1;
 
-       /* A bug in the current 887 implementation, causes an NMI assert during
-        * starting or stopping interrupts or dma. Avoid the bug for the time being,
-        * enabling the developer to work on the demod/tuner locking work.
-        */
-       switch(cx23885_boards[dev->board].bridge) {
+       switch(dev->bridge) {
        case CX23885_BRIDGE_885:
+       case CX23885_BRIDGE_887:
                /* enable irqs */
                dprintk(1, "%s() enabling TS int's and DMA\n", __FUNCTION__ );
                cx_set(port->reg_ts_int_msk,  port->ts_int_msk_val);
                cx_set(port->reg_dma_ctl, port->dma_ctl_val);
                cx_set(PCI_INT_MSK, dev->pci_irqmask | port->pci_irqmask);
                break;
-       case CX23885_BRIDGE_887:
-               // FIXME
-               dprintk(1, "%s() NOT enabling TS int's and DMA, NMI bug\n", __FUNCTION__ );
-               break;
        default:
-               // FIXME: generate a sensible switch-default message
-               printk(KERN_ERR "%s() error, default case", __FUNCTION__ );
+               BUG();
        }
 
-       dprintk(1, "%s() Register Dump\n", __FUNCTION__);
-       dprintk(1, "%s() set port ts_int_msk, now %x\n", __FUNCTION__, cx_read(port->reg_ts_int_msk) );
-       dprintk(1, "%s() DEV_CNTRL2      0x%08x\n", __FUNCTION__, cx_read(DEV_CNTRL2) );
-       dprintk(1, "%s() PCI_INT_MSK     0x%08x\n", __FUNCTION__, cx_read(PCI_INT_MSK) );
-       dprintk(1, "%s() VID_A_INT_MSK   0x%08x\n", __FUNCTION__, cx_read(VID_A_INT_MSK) );
-       dprintk(1, "%s() VID_B_INT_MSK   0x%08x\n", __FUNCTION__, cx_read(VID_B_INT_MSK) );
-       dprintk(1, "%s() VID_C_INT_MSK   0x%08x\n", __FUNCTION__, cx_read(VID_C_INT_MSK) );
-       dprintk(1, "%s() VID_A_DMA_CTL   0x%08x\n", __FUNCTION__, cx_read(VID_A_DMA_CTL) );
-       dprintk(1, "%s() VID_B_DMA_CTL   0x%08x\n", __FUNCTION__, cx_read(VID_B_DMA_CTL) );
-       dprintk(1, "%s() VID_C_DMA_CTL   0x%08x\n", __FUNCTION__, cx_read(VID_C_DMA_CTL) );
-       dprintk(1, "%s() AUD_INT_INT_MSK 0x%08x\n", __FUNCTION__, cx_read(AUDIO_INT_INT_MSK) );
-       dprintk(1, "%s() AUD_INT_DMA_CTL 0x%08x\n", __FUNCTION__, cx_read(AUD_INT_DMA_CTL) );
-       dprintk(1, "%s() AUD_EXT_INT_MSK 0x%08x\n", __FUNCTION__, cx_read(AUDIO_EXT_INT_MSK) );
-       dprintk(1, "%s() AUD_EXT_DMA_CTL 0x%08x\n", __FUNCTION__, cx_read(AUD_EXT_DMA_CTL) );
-
        cx_set(DEV_CNTRL2, (1<<5)); /* Enable RISC controller */
 
-       dprintk(1, "%s() set dev_cntrl2, now %x\n", __FUNCTION__, cx_read(DEV_CNTRL2) );
-       dprintk(1, "%s() VID_C_DMA_CTL   , now %x\n", __FUNCTION__, cx_read(port->reg_dma_ctl) );
-       dprintk(1, "%s() VID_C_DMA_CTL   , now %x\n", __FUNCTION__, cx_read(VID_C_DMA_CTL) );
-       dprintk(1, "%s() PAD_CTRL %x\n", __FUNCTION__, cx_read(PAD_CTRL) );
-       dprintk(1, "%s() GPIO2 %x\n", __FUNCTION__, cx_read(GPIO2) );
-       dprintk(1, "%s() VID_C_LN_LNGTH  , now %x\n", __FUNCTION__, cx_read(port->reg_lngth) );
-       dprintk(1, "%s() VID_C_HW_SOP_CTL, now %x\n", __FUNCTION__, cx_read(port->reg_hw_sop_ctrl) );
-       dprintk(1, "%s() VID_C_GEN_CTL   , now %x\n", __FUNCTION__, cx_read(port->reg_gen_ctrl) );
-       dprintk(1, "%s() VID_C_SOP_STATUS, now %x\n", __FUNCTION__, cx_read(VID_C_SOP_STATUS) );
-       dprintk(1, "%s() VID_C_TS_CLK_EN , now %x\n", __FUNCTION__, cx_read(VID_C_TS_CLK_EN) );
-       dprintk(1, "%s() VID_C_FIFO_OVLST, now %x\n", __FUNCTION__, cx_read(VID_C_FIFO_OVFL_STAT) );
-       dprintk(1, "%s() VID_C_INT_MSTAT , now 0x%08x\n", __FUNCTION__, cx_read(VID_C_INT_MSTAT) );
        return 0;
 }
 
@@ -1159,58 +1097,56 @@ static int cx23885_restart_queue(struct cx23885_tsport *port,
 {
        struct cx23885_dev *dev = port->dev;
        struct cx23885_buffer *buf;
-       struct list_head *item;
 
        dprintk(5, "%s()\n", __FUNCTION__);
        if (list_empty(&q->active))
        {
-              struct cx23885_buffer *prev;
-              prev = NULL;
+               struct cx23885_buffer *prev;
+               prev = NULL;
 
                dprintk(5, "%s() queue is empty\n", __FUNCTION__);
 
-              for (;;) {
-                      if (list_empty(&q->queued))
-                              return 0;
-                      buf = list_entry(q->queued.next, struct cx23885_buffer, vb.queue);
-                      if (NULL == prev) {
-                              list_del(&buf->vb.queue);
-                              list_add_tail(&buf->vb.queue,&q->active);
-                              cx23885_start_dma(port, q, buf);
-                              buf->vb.state = STATE_ACTIVE;
-                              buf->count    = q->count++;
-                              mod_timer(&q->timeout, jiffies+BUFFER_TIMEOUT);
-                              dprintk(5,"[%p/%d] restart_queue - first active\n",
-                                      buf,buf->vb.i);
-
-                      } else if (prev->vb.width  == buf->vb.width  &&
-                                 prev->vb.height == buf->vb.height &&
-                                 prev->fmt       == buf->fmt) {
-                              list_del(&buf->vb.queue);
-                              list_add_tail(&buf->vb.queue,&q->active);
-                              buf->vb.state = STATE_ACTIVE;
-                              buf->count    = q->count++;
-                              prev->risc.jmp[1] = cpu_to_le32(buf->risc.dma);
-                              prev->risc.jmp[2] = cpu_to_le32(0); /* 64 bit bits 63-32 */
-                              dprintk(5,"[%p/%d] restart_queue - move to active\n",
-                                      buf,buf->vb.i);
-                      } else {
-                              return 0;
-                      }
-                      prev = buf;
-              }
+               for (;;) {
+                       if (list_empty(&q->queued))
+                               return 0;
+                       buf = list_entry(q->queued.next, struct cx23885_buffer,
+                                        vb.queue);
+                       if (NULL == prev) {
+                               list_del(&buf->vb.queue);
+                               list_add_tail(&buf->vb.queue, &q->active);
+                               cx23885_start_dma(port, q, buf);
+                               buf->vb.state = VIDEOBUF_ACTIVE;
+                               buf->count    = q->count++;
+                               mod_timer(&q->timeout, jiffies+BUFFER_TIMEOUT);
+                               dprintk(5, "[%p/%d] restart_queue - first active\n",
+                                       buf, buf->vb.i);
+
+                       } else if (prev->vb.width  == buf->vb.width  &&
+                                  prev->vb.height == buf->vb.height &&
+                                  prev->fmt       == buf->fmt) {
+                               list_del(&buf->vb.queue);
+                               list_add_tail(&buf->vb.queue, &q->active);
+                               buf->vb.state = VIDEOBUF_ACTIVE;
+                               buf->count    = q->count++;
+                               prev->risc.jmp[1] = cpu_to_le32(buf->risc.dma);
+                               prev->risc.jmp[2] = cpu_to_le32(0); /* 64 bit bits 63-32 */
+                               dprintk(5,"[%p/%d] restart_queue - move to active\n",
+                                       buf, buf->vb.i);
+                       } else {
+                               return 0;
+                       }
+                       prev = buf;
+               }
                return 0;
        }
 
        buf = list_entry(q->active.next, struct cx23885_buffer, vb.queue);
-       dprintk(2,"restart_queue [%p/%d]: restart dma\n",
+       dprintk(2, "restart_queue [%p/%d]: restart dma\n",
                buf, buf->vb.i);
        cx23885_start_dma(port, q, buf);
-       list_for_each(item,&q->active) {
-               buf = list_entry(item, struct cx23885_buffer, vb.queue);
+       list_for_each_entry(buf, &q->active, vb.queue)
                buf->count = q->count++;
-       }
-       mod_timer(&q->timeout, jiffies+BUFFER_TIMEOUT);
+       mod_timer(&q->timeout, jiffies + BUFFER_TIMEOUT);
        return 0;
 }
 
@@ -1227,23 +1163,23 @@ int cx23885_buf_prepare(struct videobuf_queue *q, struct cx23885_tsport *port,
        if (0 != buf->vb.baddr  &&  buf->vb.bsize < size)
                return -EINVAL;
 
-       if (STATE_NEEDS_INIT == buf->vb.state) {
+       if (VIDEOBUF_NEEDS_INIT == buf->vb.state) {
                buf->vb.width  = port->ts_packet_size;
                buf->vb.height = port->ts_packet_count;
                buf->vb.size   = size;
                buf->vb.field  = field /*V4L2_FIELD_TOP*/;
 
-               if (0 != (rc = videobuf_iolock(q,&buf->vb,NULL)))
+               if (0 != (rc = videobuf_iolock(q, &buf->vb, NULL)))
                        goto fail;
                cx23885_risc_databuffer(dev->pci, &buf->risc,
-                                    buf->vb.dma.sglist,
-                                    buf->vb.width, buf->vb.height);
+                                       videobuf_to_dma(&buf->vb)->sglist,
+                                       buf->vb.width, buf->vb.height);
        }
-       buf->vb.state = STATE_PREPARED;
+       buf->vb.state = VIDEOBUF_PREPARED;
        return 0;
 
  fail:
-       cx23885_free_buffer(q,buf);
+       cx23885_free_buffer(q, buf);
        return rc;
 }
 
@@ -1260,63 +1196,54 @@ void cx23885_buf_queue(struct cx23885_tsport *port, struct cx23885_buffer *buf)
 
        if (list_empty(&cx88q->active)) {
                dprintk( 1, "queue is empty - first active\n" );
-               list_add_tail(&buf->vb.queue,&cx88q->active);
+               list_add_tail(&buf->vb.queue, &cx88q->active);
                cx23885_start_dma(port, cx88q, buf);
-               buf->vb.state = STATE_ACTIVE;
+               buf->vb.state = VIDEOBUF_ACTIVE;
                buf->count    = cx88q->count++;
-               mod_timer(&cx88q->timeout, jiffies+BUFFER_TIMEOUT);
-               dprintk(1,"[%p/%d] %s - first active\n",
+               mod_timer(&cx88q->timeout, jiffies + BUFFER_TIMEOUT);
+               dprintk(1, "[%p/%d] %s - first active\n",
                        buf, buf->vb.i, __FUNCTION__);
-
        } else {
                dprintk( 1, "queue is not empty - append to active\n" );
-               prev = list_entry(cx88q->active.prev, struct cx23885_buffer, vb.queue);
-               list_add_tail(&buf->vb.queue,&cx88q->active);
-               buf->vb.state = STATE_ACTIVE;
+               prev = list_entry(cx88q->active.prev, struct cx23885_buffer,
+                                 vb.queue);
+               list_add_tail(&buf->vb.queue, &cx88q->active);
+               buf->vb.state = VIDEOBUF_ACTIVE;
                buf->count    = cx88q->count++;
                prev->risc.jmp[1] = cpu_to_le32(buf->risc.dma);
                prev->risc.jmp[2] = cpu_to_le32(0); /* 64 bit bits 63-32 */
                dprintk( 1, "[%p/%d] %s - append to active\n",
-                       buf, buf->vb.i, __FUNCTION__);
+                        buf, buf->vb.i, __FUNCTION__);
        }
 }
 
 /* ----------------------------------------------------------- */
 
-static void do_cancel_buffers(struct cx23885_tsport *port, char *reason, int restart)
+static void do_cancel_buffers(struct cx23885_tsport *port, char *reason,
+                             int restart)
 {
        struct cx23885_dev *dev = port->dev;
        struct cx23885_dmaqueue *q = &port->mpegq;
        struct cx23885_buffer *buf;
        unsigned long flags;
 
-       spin_lock_irqsave(&port->slock,flags);
+       spin_lock_irqsave(&port->slock, flags);
        while (!list_empty(&q->active)) {
-               buf = list_entry(q->active.next, struct cx23885_buffer, vb.queue);
+               buf = list_entry(q->active.next, struct cx23885_buffer,
+                                vb.queue);
                list_del(&buf->vb.queue);
-               buf->vb.state = STATE_ERROR;
+               buf->vb.state = VIDEOBUF_ERROR;
                wake_up(&buf->vb.done);
-               dprintk(1,"[%p/%d] %s - dma=0x%08lx\n",
+               dprintk(1, "[%p/%d] %s - dma=0x%08lx\n",
                        buf, buf->vb.i, reason, (unsigned long)buf->risc.dma);
        }
-       if (restart)
-       {
+       if (restart) {
                dprintk(1, "restarting queue\n" );
                cx23885_restart_queue(port, q);
        }
-       spin_unlock_irqrestore(&port->slock,flags);
+       spin_unlock_irqrestore(&port->slock, flags);
 }
 
-void cx23885_cancel_buffers(struct cx23885_tsport *port)
-{
-       struct cx23885_dev *dev = port->dev;
-       struct cx23885_dmaqueue *q = &port->mpegq;
-
-       dprintk(1, "%s()\n", __FUNCTION__ );
-       del_timer_sync(&q->timeout);
-       cx23885_stop_dma(port);
-       do_cancel_buffers(port, "cancel", 0);
-}
 
 static void cx23885_timeout(unsigned long data)
 {
@@ -1326,72 +1253,99 @@ static void cx23885_timeout(unsigned long data)
        dprintk(1, "%s()\n",__FUNCTION__);
 
        if (debug > 5)
-#if SRAM
                cx23885_sram_channel_dump(dev, &dev->sram_channels[ port->sram_chno ]);
-#else
-       {
-               // FIXME: Put a pointer to the sram_channel table in cx23885_dev
-               // and stop all this ugly switch/if code
-               if(cx23885_boards[dev->board].bridge == CX23885_BRIDGE_885)
-                       cx23885_sram_channel_dump(dev, &cx23885_sram_channels[ port->sram_chno ]);
-               if(cx23885_boards[dev->board].bridge == CX23885_BRIDGE_887)
-                       cx23885_sram_channel_dump(dev, &cx23887_sram_channels[ port->sram_chno ]);
-       }
-#endif
+
        cx23885_stop_dma(port);
        do_cancel_buffers(port, "timeout", 1);
 }
 
-#define PCI_MSK_APB_DMA   (1 << 12)
-#define PCI_MSK_AL_WR     (1 << 11)
-#define PCI_MSK_AL_RD     (1 << 10)
-#define PCI_MSK_RISC_WR   (1 <<  9)
-#define PCI_MSK_RISC_RD   (1 <<  8)
-
-#define PCI_MSK_AUD_EXT   (1 <<  4)
-#define PCI_MSK_AUD_INT   (1 <<  3)
-#define PCI_MSK_VID_C     (1 <<  2)
-#define PCI_MSK_VID_B     (1 <<  1)
-#define PCI_MSK_VID_A      1
-
-#define VID_C_MSK_BAD_PKT (1 << 20)
-#define VID_C_MSK_OPC_ERR (1 << 16)
-#define VID_C_MSK_SYNC    (1 << 12)
-#define VID_C_MSK_OF      (1 <<  8)
-#define VID_C_MSK_RISCI2  (1 <<  4)
-#define VID_C_MSK_RISCI1   1
-
-static irqreturn_t cx23885_irq(int irq, void *dev_id, struct pt_regs *regs)
+static int cx23885_irq_ts(struct cx23885_tsport *port, u32 status)
+{
+       struct cx23885_dev *dev = port->dev;
+       int handled = 0;
+       u32 count;
+
+       if ( (status & VID_BC_MSK_OPC_ERR) ||
+            (status & VID_BC_MSK_BAD_PKT) ||
+            (status & VID_BC_MSK_SYNC) ||
+            (status & VID_BC_MSK_OF))
+       {
+               if (status & VID_BC_MSK_OPC_ERR)
+                       dprintk(7, " (VID_BC_MSK_OPC_ERR 0x%08x)\n", VID_BC_MSK_OPC_ERR);
+               if (status & VID_BC_MSK_BAD_PKT)
+                       dprintk(7, " (VID_BC_MSK_BAD_PKT 0x%08x)\n", VID_BC_MSK_BAD_PKT);
+               if (status & VID_BC_MSK_SYNC)
+                       dprintk(7, " (VID_BC_MSK_SYNC    0x%08x)\n", VID_BC_MSK_SYNC);
+               if (status & VID_BC_MSK_OF)
+                       dprintk(7, " (VID_BC_MSK_OF      0x%08x)\n", VID_BC_MSK_OF);
+
+               printk(KERN_ERR "%s: mpeg risc op code error\n", dev->name);
+
+               cx_clear(port->reg_dma_ctl, port->dma_ctl_val);
+               cx23885_sram_channel_dump(dev, &dev->sram_channels[ port->sram_chno ]);
+
+       } else if (status & VID_BC_MSK_RISCI1) {
+
+               dprintk(7, " (RISCI1            0x%08x)\n", VID_BC_MSK_RISCI1);
+
+               spin_lock(&port->slock);
+               count = cx_read(port->reg_gpcnt);
+               cx23885_wakeup(port, &port->mpegq, count);
+               spin_unlock(&port->slock);
+
+       } else if (status & VID_BC_MSK_RISCI2) {
+
+               dprintk(7, " (RISCI2            0x%08x)\n", VID_BC_MSK_RISCI2);
+
+               spin_lock(&port->slock);
+               cx23885_restart_queue(port, &port->mpegq);
+               spin_unlock(&port->slock);
+
+       }
+       if (status) {
+               cx_write(port->reg_ts_int_stat, status);
+               handled = 1;
+       }
+
+       return handled;
+}
+
+static irqreturn_t cx23885_irq(int irq, void *dev_id)
 {
        struct cx23885_dev *dev = dev_id;
-       struct cx23885_tsport *port = &dev->ts2;
+       struct cx23885_tsport *ts1 = &dev->ts1;
+       struct cx23885_tsport *ts2 = &dev->ts2;
        u32 pci_status, pci_mask;
+       u32 ts1_status, ts1_mask;
        u32 ts2_status, ts2_mask;
-       int count = 0, handled = 0;
+       int ts1_count = 0, ts2_count = 0, handled = 0;
 
        pci_status = cx_read(PCI_INT_STAT);
        pci_mask = cx_read(PCI_INT_MSK);
-
+       ts1_status = cx_read(VID_B_INT_STAT);
+       ts1_mask = cx_read(VID_B_INT_MSK);
        ts2_status = cx_read(VID_C_INT_STAT);
        ts2_mask = cx_read(VID_C_INT_MSK);
 
-       if ( (pci_status == 0) && (ts2_status == 0) )
+       if ( (pci_status == 0) && (ts2_status == 0) && (ts1_status == 0) )
                goto out;
 
-       count = cx_read(port->reg_gpcnt);
+       ts1_count = cx_read(ts1->reg_gpcnt);
+       ts2_count = cx_read(ts2->reg_gpcnt);
        dprintk(7, "pci_status: 0x%08x  pci_mask: 0x%08x\n", pci_status, pci_mask );
-       dprintk(7, "ts2_status: 0x%08x  ts2_mask: 0x%08x count: 0x%x\n", ts2_status, ts2_mask, count );
+       dprintk(7, "ts1_status: 0x%08x  ts1_mask: 0x%08x count: 0x%x\n", ts1_status, ts1_mask, ts1_count );
+       dprintk(7, "ts2_status: 0x%08x  ts2_mask: 0x%08x count: 0x%x\n", ts2_status, ts2_mask, ts2_count );
 
        if ( (pci_status & PCI_MSK_RISC_RD) ||
-               (pci_status & PCI_MSK_RISC_WR) ||
-               (pci_status & PCI_MSK_AL_RD) ||
-               (pci_status & PCI_MSK_AL_WR) ||
-               (pci_status & PCI_MSK_APB_DMA) ||
-               (pci_status & PCI_MSK_VID_C) ||
-               (pci_status & PCI_MSK_VID_B) ||
-               (pci_status & PCI_MSK_VID_A) ||
-               (pci_status & PCI_MSK_AUD_INT) ||
-               (pci_status & PCI_MSK_AUD_EXT) )
+            (pci_status & PCI_MSK_RISC_WR) ||
+            (pci_status & PCI_MSK_AL_RD) ||
+            (pci_status & PCI_MSK_AL_WR) ||
+            (pci_status & PCI_MSK_APB_DMA) ||
+            (pci_status & PCI_MSK_VID_C) ||
+            (pci_status & PCI_MSK_VID_B) ||
+            (pci_status & PCI_MSK_VID_A) ||
+            (pci_status & PCI_MSK_AUD_INT) ||
+            (pci_status & PCI_MSK_AUD_EXT) )
        {
 
                if (pci_status & PCI_MSK_RISC_RD)
@@ -1417,63 +1371,25 @@ static irqreturn_t cx23885_irq(int irq, void *dev_id, struct pt_regs *regs)
 
        }
 
-       if ( (ts2_status & VID_C_MSK_OPC_ERR) ||
-               (ts2_status & VID_C_MSK_BAD_PKT) ||
-               (ts2_status & VID_C_MSK_SYNC) ||
-               (ts2_status & VID_C_MSK_OF))
-       {
-               if (ts2_status & VID_C_MSK_OPC_ERR)
-                       dprintk(7, " (VID_C_MSK_OPC_ERR 0x%08x)\n", VID_C_MSK_OPC_ERR);
-               if (ts2_status & VID_C_MSK_BAD_PKT)
-                       dprintk(7, " (VID_C_MSK_BAD_PKT 0x%08x)\n", VID_C_MSK_BAD_PKT);
-               if (ts2_status & VID_C_MSK_SYNC)
-                       dprintk(7, " (VID_C_MSK_SYNC    0x%08x)\n", VID_C_MSK_SYNC);
-               if (ts2_status & VID_C_MSK_OF)
-                       dprintk(7, " (VID_C_MSK_OF      0x%08x)\n", VID_C_MSK_OF);
-
-               printk(KERN_ERR "%s: mpeg risc op code error\n", dev->name);
-
-               cx_clear(port->reg_dma_ctl, port->dma_ctl_val);
-#if SRAM
-               cx23885_sram_channel_dump(dev, &dev->sram_channels[ port->sram_chno ]);
-#else
-               cx23885_sram_channel_dump(dev, &cx23885_sram_channels[ port->sram_chno ]);
-#endif
-
-
-       } else if (ts2_status & VID_C_MSK_RISCI1) {
+       if (ts1_status)
+               handled += cx23885_irq_ts(ts1, ts1_status);
 
-               dprintk(7, " (RISCI1            0x%08x)\n", VID_C_MSK_RISCI1);
-
-               spin_lock(&port->slock);
-               count = cx_read(port->reg_gpcnt);
-               cx23885_wakeup(port, &port->mpegq, count);
-               spin_unlock(&port->slock);
-
-       } else if (ts2_status & VID_C_MSK_RISCI2) {
-
-               dprintk(7, " (RISCI2            0x%08x)\n", VID_C_MSK_RISCI2);
-
-               spin_lock(&port->slock);
-               cx23885_restart_queue(port, &port->mpegq);
-               spin_unlock(&port->slock);
-
-       }
+       if (ts2_status)
+               handled += cx23885_irq_ts(ts2, ts2_status);
 
-       cx_write(VID_C_INT_STAT, ts2_status);
-       cx_write(PCI_INT_STAT, pci_status);
-       handled = 1;
+       if (handled)
+               cx_write(PCI_INT_STAT, pci_status);
 out:
        return IRQ_RETVAL(handled);
 }
 
 static int __devinit cx23885_initdev(struct pci_dev *pci_dev,
-                                   const struct pci_device_id *pci_id)
+                                    const struct pci_device_id *pci_id)
 {
        struct cx23885_dev *dev;
        int err;
 
-       dev = kzalloc(sizeof(*dev),GFP_KERNEL);
+       dev = kzalloc(sizeof(*dev), GFP_KERNEL);
        if (NULL == dev)
                return -ENOMEM;
 
@@ -1504,8 +1420,8 @@ static int __devinit cx23885_initdev(struct pci_dev *pci_dev,
                goto fail_irq;
        }
 
-       err = request_irq(pci_dev->irq, cx23885_irq
-                       , IRQF_SHARED | IRQF_DISABLED, dev->name, dev);
+       err = request_irq(pci_dev->irq, cx23885_irq,
+                         IRQF_SHARED | IRQF_DISABLED, dev->name, dev);
        if (err < 0) {
                printk(KERN_ERR "%s: can't get IRQ %d\n",
                       dev->name, pci_dev->irq);
@@ -1574,9 +1490,9 @@ static struct pci_driver cx23885_pci_driver = {
 static int cx23885_init(void)
 {
        printk(KERN_INFO "cx23885 driver version %d.%d.%d loaded\n",
-              (CX88_VERSION_CODE >> 16) & 0xff,
-              (CX88_VERSION_CODE >>  8) & 0xff,
-              CX88_VERSION_CODE & 0xff);
+              (CX23885_VERSION_CODE >> 16) & 0xff,
+              (CX23885_VERSION_CODE >>  8) & 0xff,
+              CX23885_VERSION_CODE & 0xff);
 #ifdef SNAPSHOT
        printk(KERN_INFO "cx23885: snapshot date %04d-%02d-%02d\n",
               SNAPSHOT/10000, (SNAPSHOT/100)%100, SNAPSHOT%100);