]> err.no Git - linux-2.6/blobdiff - drivers/ieee1394/csr1212.c
ieee1394: stricter error checks in csr1212
[linux-2.6] / drivers / ieee1394 / csr1212.c
index ff5a01ecfcaae7991fcbe6b51dfe8a4e1b90773f..54408cbe8f8f25c52c04d0f334eb750ec0719bfe 100644 (file)
  *   parameter expect size to be in bytes.
  */
 
-#ifndef __KERNEL__
-#include <string.h>
-#endif
+#include <linux/errno.h>
+#include <linux/string.h>
+#include <asm/bug.h>
+#include <asm/byteorder.h>
 
 #include "csr1212.h"
 
@@ -45,7 +46,7 @@
 #define __C (1 << CSR1212_KV_TYPE_CSR_OFFSET)
 #define __D (1 << CSR1212_KV_TYPE_DIRECTORY)
 #define __L (1 << CSR1212_KV_TYPE_LEAF)
-static const u_int8_t csr1212_key_id_type_map[0x30] = {
+static const u8 csr1212_key_id_type_map[0x30] = {
        __C,                    /* used by Apple iSight */
        __D | __L,              /* Descriptor */
        __I | __D | __L,        /* Bus_Dependent_Info */
@@ -81,8 +82,8 @@ static const u_int8_t csr1212_key_id_type_map[0x30] = {
 #undef __L
 
 
-#define quads_to_bytes(_q) ((_q) * sizeof(u_int32_t))
-#define bytes_to_quads(_b) (((_b) + sizeof(u_int32_t) - 1) / sizeof(u_int32_t))
+#define quads_to_bytes(_q) ((_q) * sizeof(u32))
+#define bytes_to_quads(_b) (((_b) + sizeof(u32) - 1) / sizeof(u32))
 
 static void free_keyval(struct csr1212_keyval *kv)
 {
@@ -93,14 +94,14 @@ static void free_keyval(struct csr1212_keyval *kv)
        CSR1212_FREE(kv);
 }
 
-static u_int16_t csr1212_crc16(const u_int32_t *buffer, size_t length)
+static u16 csr1212_crc16(const u32 *buffer, size_t length)
 {
        int shift;
-       u_int32_t data;
-       u_int16_t sum, crc = 0;
+       u32 data;
+       u16 sum, crc = 0;
 
        for (; length; length--) {
-               data = CSR1212_BE32_TO_CPU(*buffer);
+               data = be32_to_cpu(*buffer);
                buffer++;
                for (shift = 28; shift >= 0; shift -= 4 ) {
                        sum = ((crc >> 12) ^ (data >> shift)) & 0xf;
@@ -109,21 +110,21 @@ static u_int16_t csr1212_crc16(const u_int32_t *buffer, size_t length)
                crc &= 0xffff;
        }
 
-       return CSR1212_CPU_TO_BE16(crc);
+       return cpu_to_be16(crc);
 }
 
 #if 0
 /* Microsoft computes the CRC with the bytes in reverse order.  Therefore we
  * have a special version of the CRC algorithm to account for their buggy
  * software. */
-static u_int16_t csr1212_msft_crc16(const u_int32_t *buffer, size_t length)
+static u16 csr1212_msft_crc16(const u32 *buffer, size_t length)
 {
        int shift;
-       u_int32_t data;
-       u_int16_t sum, crc = 0;
+       u32 data;
+       u16 sum, crc = 0;
 
        for (; length; length--) {
-               data = CSR1212_LE32_TO_CPU(*buffer);
+               data = le32_to_cpu(*buffer);
                buffer++;
                for (shift = 28; shift >= 0; shift -= 4 ) {
                        sum = ((crc >> 12) ^ (data >> shift)) & 0xf;
@@ -132,7 +133,7 @@ static u_int16_t csr1212_msft_crc16(const u_int32_t *buffer, size_t length)
                crc &= 0xffff;
        }
 
-       return CSR1212_CPU_TO_BE16(crc);
+       return cpu_to_be16(crc);
 }
 #endif
 
@@ -150,7 +151,7 @@ csr1212_find_keyval(struct csr1212_keyval *dir, struct csr1212_keyval *kv)
 }
 
 static struct csr1212_keyval *
-csr1212_find_keyval_offset(struct csr1212_keyval *kv_list, u_int32_t offset)
+csr1212_find_keyval_offset(struct csr1212_keyval *kv_list, u32 offset)
 {
        struct csr1212_keyval *kv;
 
@@ -202,23 +203,16 @@ struct csr1212_csr *csr1212_create_csr(struct csr1212_bus_ops *ops,
 }
 
 void csr1212_init_local_csr(struct csr1212_csr *csr,
-                           const u_int32_t *bus_info_data, int max_rom)
+                           const u32 *bus_info_data, int max_rom)
 {
        static const int mr_map[] = { 4, 64, 1024, 0 };
 
-#ifdef __KERNEL__
        BUG_ON(max_rom & ~0x3);
        csr->max_rom = mr_map[max_rom];
-#else
-       if (max_rom & ~0x3) /* caller supplied invalid argument */
-               csr->max_rom = 0;
-       else
-               csr->max_rom = mr_map[max_rom];
-#endif
        memcpy(csr->bus_info_data, bus_info_data, csr->bus_info_len);
 }
 
-static struct csr1212_keyval *csr1212_new_keyval(u_int8_t type, u_int8_t key)
+static struct csr1212_keyval *csr1212_new_keyval(u8 type, u8 key)
 {
        struct csr1212_keyval *kv;
 
@@ -242,7 +236,7 @@ static struct csr1212_keyval *csr1212_new_keyval(u_int8_t type, u_int8_t key)
        return kv;
 }
 
-struct csr1212_keyval *csr1212_new_immediate(u_int8_t key, u_int32_t value)
+struct csr1212_keyval *csr1212_new_immediate(u8 key, u32 value)
 {
        struct csr1212_keyval *kv = csr1212_new_keyval(CSR1212_KV_TYPE_IMMEDIATE, key);
 
@@ -255,7 +249,7 @@ struct csr1212_keyval *csr1212_new_immediate(u_int8_t key, u_int32_t value)
 }
 
 static struct csr1212_keyval *
-csr1212_new_leaf(u_int8_t key, const void *data, size_t data_len)
+csr1212_new_leaf(u8 key, const void *data, size_t data_len)
 {
        struct csr1212_keyval *kv = csr1212_new_keyval(CSR1212_KV_TYPE_LEAF, key);
 
@@ -283,7 +277,7 @@ csr1212_new_leaf(u_int8_t key, const void *data, size_t data_len)
 }
 
 static struct csr1212_keyval *
-csr1212_new_csr_offset(u_int8_t key, u_int32_t csr_offset)
+csr1212_new_csr_offset(u8 key, u32 csr_offset)
 {
        struct csr1212_keyval *kv = csr1212_new_keyval(CSR1212_KV_TYPE_CSR_OFFSET, key);
 
@@ -297,7 +291,7 @@ csr1212_new_csr_offset(u_int8_t key, u_int32_t csr_offset)
        return kv;
 }
 
-struct csr1212_keyval *csr1212_new_directory(u_int8_t key)
+struct csr1212_keyval *csr1212_new_directory(u8 key)
 {
        struct csr1212_keyval *kv = csr1212_new_keyval(CSR1212_KV_TYPE_DIRECTORY, key);
 
@@ -312,43 +306,29 @@ struct csr1212_keyval *csr1212_new_directory(u_int8_t key)
        return kv;
 }
 
-int csr1212_associate_keyval(struct csr1212_keyval *kv,
-                            struct csr1212_keyval *associate)
+void csr1212_associate_keyval(struct csr1212_keyval *kv,
+                             struct csr1212_keyval *associate)
 {
-       if (!kv || !associate)
-               return CSR1212_EINVAL;
-
-       if (kv->key.id == CSR1212_KV_ID_DESCRIPTOR ||
-          (associate->key.id != CSR1212_KV_ID_DESCRIPTOR &&
-           associate->key.id != CSR1212_KV_ID_DEPENDENT_INFO &&
-           associate->key.id != CSR1212_KV_ID_EXTENDED_KEY &&
-           associate->key.id != CSR1212_KV_ID_EXTENDED_DATA &&
-           associate->key.id < 0x30))
-               return CSR1212_EINVAL;
-
-       if (kv->key.id == CSR1212_KV_ID_EXTENDED_KEY_SPECIFIER_ID &&
-          associate->key.id != CSR1212_KV_ID_EXTENDED_KEY)
-               return CSR1212_EINVAL;
-
-       if (kv->key.id == CSR1212_KV_ID_EXTENDED_KEY &&
-          associate->key.id != CSR1212_KV_ID_EXTENDED_DATA)
-               return CSR1212_EINVAL;
-
-       if (associate->key.id == CSR1212_KV_ID_EXTENDED_KEY &&
-          kv->key.id != CSR1212_KV_ID_EXTENDED_KEY_SPECIFIER_ID)
-               return CSR1212_EINVAL;
-
-       if (associate->key.id == CSR1212_KV_ID_EXTENDED_DATA &&
-          kv->key.id != CSR1212_KV_ID_EXTENDED_KEY)
-               return CSR1212_EINVAL;
+       BUG_ON(!kv || !associate || kv->key.id == CSR1212_KV_ID_DESCRIPTOR ||
+              (associate->key.id != CSR1212_KV_ID_DESCRIPTOR &&
+               associate->key.id != CSR1212_KV_ID_DEPENDENT_INFO &&
+               associate->key.id != CSR1212_KV_ID_EXTENDED_KEY &&
+               associate->key.id != CSR1212_KV_ID_EXTENDED_DATA &&
+               associate->key.id < 0x30) ||
+              (kv->key.id == CSR1212_KV_ID_EXTENDED_KEY_SPECIFIER_ID &&
+               associate->key.id != CSR1212_KV_ID_EXTENDED_KEY) ||
+              (kv->key.id == CSR1212_KV_ID_EXTENDED_KEY &&
+               associate->key.id != CSR1212_KV_ID_EXTENDED_DATA) ||
+              (associate->key.id == CSR1212_KV_ID_EXTENDED_KEY &&
+               kv->key.id != CSR1212_KV_ID_EXTENDED_KEY_SPECIFIER_ID) ||
+              (associate->key.id == CSR1212_KV_ID_EXTENDED_DATA &&
+               kv->key.id != CSR1212_KV_ID_EXTENDED_KEY));
 
        if (kv->associate)
                csr1212_release_keyval(kv->associate);
 
        associate->refcnt++;
        kv->associate = associate;
-
-       return CSR1212_SUCCESS;
 }
 
 int csr1212_attach_keyval_to_directory(struct csr1212_keyval *dir,
@@ -356,12 +336,11 @@ int csr1212_attach_keyval_to_directory(struct csr1212_keyval *dir,
 {
        struct csr1212_dentry *dentry;
 
-       if (!kv || !dir || dir->key.type != CSR1212_KV_TYPE_DIRECTORY)
-               return CSR1212_EINVAL;
+       BUG_ON(!kv || !dir || dir->key.type != CSR1212_KV_TYPE_DIRECTORY);
 
        dentry = CSR1212_MALLOC(sizeof(*dentry));
        if (!dentry)
-               return CSR1212_ENOMEM;
+               return -ENOMEM;
 
        dentry->kv = kv;
 
@@ -385,16 +364,16 @@ int csr1212_attach_keyval_to_directory(struct csr1212_keyval *dir,
 
 #define CSR1212_DESCRIPTOR_LEAF_SET_TYPE(kv, type) \
        ((kv)->value.leaf.data[0] = \
-        CSR1212_CPU_TO_BE32(CSR1212_DESCRIPTOR_LEAF_SPECIFIER_ID(kv) | \
-                            ((type) << CSR1212_DESCRIPTOR_LEAF_TYPE_SHIFT)))
+        cpu_to_be32(CSR1212_DESCRIPTOR_LEAF_SPECIFIER_ID(kv) | \
+                    ((type) << CSR1212_DESCRIPTOR_LEAF_TYPE_SHIFT)))
 #define CSR1212_DESCRIPTOR_LEAF_SET_SPECIFIER_ID(kv, spec_id) \
        ((kv)->value.leaf.data[0] = \
-        CSR1212_CPU_TO_BE32((CSR1212_DESCRIPTOR_LEAF_TYPE(kv) << \
-                             CSR1212_DESCRIPTOR_LEAF_TYPE_SHIFT) | \
-                            ((spec_id) & CSR1212_DESCRIPTOR_LEAF_SPECIFIER_ID_MASK)))
+        cpu_to_be32((CSR1212_DESCRIPTOR_LEAF_TYPE(kv) << \
+                     CSR1212_DESCRIPTOR_LEAF_TYPE_SHIFT) | \
+                    ((spec_id) & CSR1212_DESCRIPTOR_LEAF_SPECIFIER_ID_MASK)))
 
 static struct csr1212_keyval *
-csr1212_new_descriptor_leaf(u_int8_t dtype, u_int32_t specifier_id,
+csr1212_new_descriptor_leaf(u8 dtype, u32 specifier_id,
                            const void *data, size_t data_len)
 {
        struct csr1212_keyval *kv;
@@ -417,32 +396,30 @@ csr1212_new_descriptor_leaf(u_int8_t dtype, u_int32_t specifier_id,
 #define CSR1212_TEXTUAL_DESCRIPTOR_LEAF_SET_WIDTH(kv, width) \
        ((kv)->value.leaf.data[1] = \
         ((kv)->value.leaf.data[1] & \
-         CSR1212_CPU_TO_BE32(~(CSR1212_TEXTUAL_DESCRIPTOR_LEAF_WIDTH_MASK << \
-                               CSR1212_TEXTUAL_DESCRIPTOR_LEAF_WIDTH_SHIFT))) | \
-        CSR1212_CPU_TO_BE32(((width) & \
-                             CSR1212_TEXTUAL_DESCRIPTOR_LEAF_WIDTH_MASK) << \
-                            CSR1212_TEXTUAL_DESCRIPTOR_LEAF_WIDTH_SHIFT))
+         cpu_to_be32(~(CSR1212_TEXTUAL_DESCRIPTOR_LEAF_WIDTH_MASK << \
+                       CSR1212_TEXTUAL_DESCRIPTOR_LEAF_WIDTH_SHIFT))) | \
+        cpu_to_be32(((width) & CSR1212_TEXTUAL_DESCRIPTOR_LEAF_WIDTH_MASK) << \
+                    CSR1212_TEXTUAL_DESCRIPTOR_LEAF_WIDTH_SHIFT))
 
 #define CSR1212_TEXTUAL_DESCRIPTOR_LEAF_SET_CHAR_SET(kv, char_set) \
        ((kv)->value.leaf.data[1] = \
         ((kv)->value.leaf.data[1] & \
-         CSR1212_CPU_TO_BE32(~(CSR1212_TEXTUAL_DESCRIPTOR_LEAF_CHAR_SET_MASK << \
-                               CSR1212_TEXTUAL_DESCRIPTOR_LEAF_CHAR_SET_SHIFT))) | \
-        CSR1212_CPU_TO_BE32(((char_set) & \
-                             CSR1212_TEXTUAL_DESCRIPTOR_LEAF_CHAR_SET_MASK) << \
-                            CSR1212_TEXTUAL_DESCRIPTOR_LEAF_CHAR_SET_SHIFT))
+         cpu_to_be32(~(CSR1212_TEXTUAL_DESCRIPTOR_LEAF_CHAR_SET_MASK << \
+                       CSR1212_TEXTUAL_DESCRIPTOR_LEAF_CHAR_SET_SHIFT))) | \
+        cpu_to_be32(((char_set) & \
+                     CSR1212_TEXTUAL_DESCRIPTOR_LEAF_CHAR_SET_MASK) << \
+                    CSR1212_TEXTUAL_DESCRIPTOR_LEAF_CHAR_SET_SHIFT))
 
 #define CSR1212_TEXTUAL_DESCRIPTOR_LEAF_SET_LANGUAGE(kv, language) \
        ((kv)->value.leaf.data[1] = \
         ((kv)->value.leaf.data[1] & \
-         CSR1212_CPU_TO_BE32(~(CSR1212_TEXTUAL_DESCRIPTOR_LEAF_LANGUAGE_MASK))) | \
-        CSR1212_CPU_TO_BE32(((language) & \
-                             CSR1212_TEXTUAL_DESCRIPTOR_LEAF_LANGUAGE_MASK)))
+         cpu_to_be32(~(CSR1212_TEXTUAL_DESCRIPTOR_LEAF_LANGUAGE_MASK))) | \
+        cpu_to_be32(((language) & \
+                     CSR1212_TEXTUAL_DESCRIPTOR_LEAF_LANGUAGE_MASK)))
 
 static struct csr1212_keyval *
-csr1212_new_textual_descriptor_leaf(u_int8_t cwidth, u_int16_t cset,
-                                   u_int16_t language, const void *data,
-                                   size_t data_len)
+csr1212_new_textual_descriptor_leaf(u8 cwidth, u16 cset, u16 language,
+                                   const void *data, size_t data_len)
 {
        struct csr1212_keyval *kv;
        char *lstr;
@@ -459,7 +436,7 @@ csr1212_new_textual_descriptor_leaf(u_int8_t cwidth, u_int16_t cset,
        lstr = (char*)CSR1212_TEXTUAL_DESCRIPTOR_LEAF_DATA(kv);
 
        /* make sure last quadlet is zeroed out */
-       *((u_int32_t*)&(lstr[(data_len - 1) & ~0x3])) = 0;
+       *((u32*)&(lstr[(data_len - 1) & ~0x3])) = 0;
 
        /* don't copy the NUL terminator */
        memcpy(lstr, data, data_len);
@@ -618,43 +595,42 @@ void csr1212_destroy_csr(struct csr1212_csr *csr)
 static int csr1212_append_new_cache(struct csr1212_csr *csr, size_t romsize)
 {
        struct csr1212_csr_rom_cache *cache;
-       u_int64_t csr_addr;
+       u64 csr_addr;
 
-       if (!csr || !csr->ops || !csr->ops->allocate_addr_range ||
-           !csr->ops->release_addr || csr->max_rom < 1)
-               return CSR1212_EINVAL;
+       BUG_ON(!csr || !csr->ops || !csr->ops->allocate_addr_range ||
+              !csr->ops->release_addr || csr->max_rom < 1);
 
        /* ROM size must be a multiple of csr->max_rom */
        romsize = (romsize + (csr->max_rom - 1)) & ~(csr->max_rom - 1);
 
        csr_addr = csr->ops->allocate_addr_range(romsize, csr->max_rom, csr->private);
        if (csr_addr == CSR1212_INVALID_ADDR_SPACE) {
-               return CSR1212_ENOMEM;
+               return -ENOMEM;
        }
        if (csr_addr < CSR1212_REGISTER_SPACE_BASE) {
                /* Invalid address returned from allocate_addr_range(). */
                csr->ops->release_addr(csr_addr, csr->private);
-               return CSR1212_ENOMEM;
+               return -ENOMEM;
        }
 
        cache = csr1212_rom_cache_malloc(csr_addr - CSR1212_REGISTER_SPACE_BASE, romsize);
        if (!cache) {
                csr->ops->release_addr(csr_addr, csr->private);
-               return CSR1212_ENOMEM;
+               return -ENOMEM;
        }
 
        cache->ext_rom = csr1212_new_keyval(CSR1212_KV_TYPE_LEAF, CSR1212_KV_ID_EXTENDED_ROM);
        if (!cache->ext_rom) {
                csr->ops->release_addr(csr_addr, csr->private);
                CSR1212_FREE(cache);
-               return CSR1212_ENOMEM;
+               return -ENOMEM;
        }
 
        if (csr1212_attach_keyval_to_directory(csr->root_kv, cache->ext_rom) != CSR1212_SUCCESS) {
                csr1212_release_keyval(cache->ext_rom);
                csr->ops->release_addr(csr_addr, csr->private);
                CSR1212_FREE(cache);
-               return CSR1212_ENOMEM;
+               return -ENOMEM;
        }
        cache->ext_rom->offset = csr_addr - CSR1212_REGISTER_SPACE_BASE;
        cache->ext_rom->value.leaf.len = -1;
@@ -832,7 +808,7 @@ csr1212_generate_positions(struct csr1212_csr_rom_cache *cache,
 #define CSR1212_KV_KEY_TYPE_MASK       0x3     /* after shift */
 
 static void
-csr1212_generate_tree_subdir(struct csr1212_keyval *dir, u_int32_t *data_buffer)
+csr1212_generate_tree_subdir(struct csr1212_keyval *dir, u32 *data_buffer)
 {
        struct csr1212_dentry *dentry;
        struct csr1212_keyval *last_extkey_spec = NULL;
@@ -843,7 +819,7 @@ csr1212_generate_tree_subdir(struct csr1212_keyval *dir, u_int32_t *data_buffer)
                struct csr1212_keyval *a;
 
                for (a = dentry->kv; a; a = a->associate) {
-                       u_int32_t value = 0;
+                       u32 value = 0;
 
                        /* Special Case: Extended Key Specifier_ID */
                        if (a->key.id == CSR1212_KV_ID_EXTENDED_KEY_SPECIFIER_ID) {
@@ -890,18 +866,18 @@ csr1212_generate_tree_subdir(struct csr1212_keyval *dir, u_int32_t *data_buffer)
                        value |= (a->key.id & CSR1212_KV_KEY_ID_MASK) << CSR1212_KV_KEY_SHIFT;
                        value |= (a->key.type & CSR1212_KV_KEY_TYPE_MASK) <<
                                (CSR1212_KV_KEY_SHIFT + CSR1212_KV_KEY_TYPE_SHIFT);
-                       data_buffer[index] = CSR1212_CPU_TO_BE32(value);
+                       data_buffer[index] = cpu_to_be32(value);
                        index++;
                }
        }
 }
 
 struct csr1212_keyval_img {
-       u_int16_t length;
-       u_int16_t crc;
+       u16 length;
+       u16 crc;
 
        /* Must be last */
-       csr1212_quad_t data[0]; /* older gcc can't handle [] which is standard */
+       u32 data[0];    /* older gcc can't handle [] which is standard */
 };
 
 static void csr1212_fill_cache(struct csr1212_csr_rom_cache *cache)
@@ -926,14 +902,14 @@ static void csr1212_fill_cache(struct csr1212_csr_rom_cache *cache)
                                memcpy(kvi->data, kv->value.leaf.data,
                                       quads_to_bytes(kv->value.leaf.len));
 
-                       kvi->length = CSR1212_CPU_TO_BE16(kv->value.leaf.len);
+                       kvi->length = cpu_to_be16(kv->value.leaf.len);
                        kvi->crc = csr1212_crc16(kvi->data, kv->value.leaf.len);
                        break;
 
                case CSR1212_KV_TYPE_DIRECTORY:
                        csr1212_generate_tree_subdir(kv, kvi->data);
 
-                       kvi->length = CSR1212_CPU_TO_BE16(kv->value.directory.len);
+                       kvi->length = cpu_to_be16(kv->value.directory.len);
                        kvi->crc = csr1212_crc16(kvi->data, kv->value.directory.len);
                        break;
                }
@@ -948,7 +924,7 @@ static void csr1212_fill_cache(struct csr1212_csr_rom_cache *cache)
        }
 }
 
-#define CSR1212_EXTENDED_ROM_SIZE (0x10000 * sizeof(u_int32_t))
+#define CSR1212_EXTENDED_ROM_SIZE (0x10000 * sizeof(u32))
 
 int csr1212_generate_csr_image(struct csr1212_csr *csr)
 {
@@ -959,8 +935,7 @@ int csr1212_generate_csr_image(struct csr1212_csr *csr)
        int ret;
        int init_offset;
 
-       if (!csr)
-               return CSR1212_EINVAL;
+       BUG_ON(!csr);
 
        cache = csr->cache_head;
 
@@ -983,7 +958,7 @@ int csr1212_generate_csr_image(struct csr1212_csr *csr)
                         * regions needed (it assumes that the cache holding
                         * the first 1K Config ROM space always exists). */
                        int est_c = agg_size / (CSR1212_EXTENDED_ROM_SIZE -
-                                               (2 * sizeof(u_int32_t))) + 1;
+                                               (2 * sizeof(u32))) + 1;
 
                        /* Add additional cache regions, extras will be
                         * removed later */
@@ -1000,7 +975,7 @@ int csr1212_generate_csr_image(struct csr1212_csr *csr)
                }
                kv = csr1212_generate_positions(cache, kv, init_offset);
                agg_size -= cache->len;
-               init_offset = sizeof(u_int32_t);
+               init_offset = sizeof(u32);
        }
 
        /* Remove unused, excess cache regions */
@@ -1020,8 +995,7 @@ int csr1212_generate_csr_image(struct csr1212_csr *csr)
 
                        /* Make sure the Extended ROM leaf is a multiple of
                         * max_rom in size. */
-                       if (csr->max_rom < 1)
-                               return CSR1212_EINVAL;
+                       BUG_ON(csr->max_rom < 1);
                        leaf_size = (cache->len + (csr->max_rom - 1)) &
                                ~(csr->max_rom - 1);
 
@@ -1030,7 +1004,7 @@ int csr1212_generate_csr_image(struct csr1212_csr *csr)
                               leaf_size - cache->len);
 
                        /* Subtract leaf header */
-                       leaf_size -= sizeof(u_int32_t);
+                       leaf_size -= sizeof(u32);
 
                        /* Update the Extended ROM leaf length */
                        cache->ext_rom->value.leaf.len =
@@ -1048,18 +1022,17 @@ int csr1212_generate_csr_image(struct csr1212_csr *csr)
                        /* Set the length and CRC of the extended ROM. */
                        struct csr1212_keyval_img *kvi =
                                (struct csr1212_keyval_img*)cache->data;
+                       u16 len = bytes_to_quads(cache->len) - 1;
 
-                       kvi->length = CSR1212_CPU_TO_BE16(bytes_to_quads(cache->len) - 1);
-                       kvi->crc = csr1212_crc16(kvi->data,
-                                                bytes_to_quads(cache->len) - 1);
-
+                       kvi->length = cpu_to_be16(len);
+                       kvi->crc = csr1212_crc16(kvi->data, len);
                }
        }
 
        return CSR1212_SUCCESS;
 }
 
-int csr1212_read(struct csr1212_csr *csr, u_int32_t offset, void *buffer, u_int32_t len)
+int csr1212_read(struct csr1212_csr *csr, u32 offset, void *buffer, u32 len)
 {
        struct csr1212_csr_rom_cache *cache;
 
@@ -1072,7 +1045,7 @@ int csr1212_read(struct csr1212_csr *csr, u_int32_t offset, void *buffer, u_int3
                        return CSR1212_SUCCESS;
                }
        }
-       return CSR1212_ENOENT;
+       return -ENOENT;
 }
 
 
@@ -1090,9 +1063,9 @@ static int csr1212_parse_bus_info_block(struct csr1212_csr *csr)
         * Unfortunately, many IEEE 1394 devices do not abide by that, so the
         * bus info block will be read 1 quadlet at a time.  The rest of the
         * ConfigROM will be read according to the max_rom field. */
-       for (i = 0; i < csr->bus_info_len; i += sizeof(csr1212_quad_t)) {
+       for (i = 0; i < csr->bus_info_len; i += sizeof(u32)) {
                ret = csr->ops->bus_read(csr, CSR1212_CONFIG_ROM_SPACE_BASE + i,
-                                        sizeof(csr1212_quad_t),
+                                        sizeof(u32),
                                         &csr->cache_head->data[bytes_to_quads(i)],
                                         csr->private);
                if (ret != CSR1212_SUCCESS)
@@ -1100,9 +1073,9 @@ static int csr1212_parse_bus_info_block(struct csr1212_csr *csr)
 
                /* check ROM header's info_length */
                if (i == 0 &&
-                   CSR1212_BE32_TO_CPU(csr->cache_head->data[0]) >> 24 !=
+                   be32_to_cpu(csr->cache_head->data[0]) >> 24 !=
                    bytes_to_quads(csr->bus_info_len) - 1)
-                       return CSR1212_EINVAL;
+                       return -EINVAL;
        }
 
        bi = (struct csr1212_bus_info_block_img*)csr->cache_head->data;
@@ -1110,9 +1083,9 @@ static int csr1212_parse_bus_info_block(struct csr1212_csr *csr)
 
        /* IEEE 1212 recommends that crc_len be equal to bus_info_len, but that is not
         * always the case, so read the rest of the crc area 1 quadlet at a time. */
-       for (i = csr->bus_info_len; i <= csr->crc_len; i += sizeof(csr1212_quad_t)) {
+       for (i = csr->bus_info_len; i <= csr->crc_len; i += sizeof(u32)) {
                ret = csr->ops->bus_read(csr, CSR1212_CONFIG_ROM_SPACE_BASE + i,
-                                        sizeof(csr1212_quad_t),
+                                        sizeof(u32),
                                         &csr->cache_head->data[bytes_to_quads(i)],
                                         csr->private);
                if (ret != CSR1212_SUCCESS)
@@ -1124,12 +1097,12 @@ static int csr1212_parse_bus_info_block(struct csr1212_csr *csr)
         * CRC algorithm that verifying them is moot. */
        if ((csr1212_crc16(bi->data, bi->crc_length) != bi->crc) &&
            (csr1212_msft_crc16(bi->data, bi->crc_length) != bi->crc))
-               return CSR1212_EINVAL;
+               return -EINVAL;
 #endif
 
        cr = CSR1212_MALLOC(sizeof(*cr));
        if (!cr)
-               return CSR1212_ENOMEM;
+               return -ENOMEM;
 
        cr->next = NULL;
        cr->prev = NULL;
@@ -1142,26 +1115,25 @@ static int csr1212_parse_bus_info_block(struct csr1212_csr *csr)
        return CSR1212_SUCCESS;
 }
 
-#define CSR1212_KV_KEY(q)      (CSR1212_BE32_TO_CPU(q) >> CSR1212_KV_KEY_SHIFT)
+#define CSR1212_KV_KEY(q)      (be32_to_cpu(q) >> CSR1212_KV_KEY_SHIFT)
 #define CSR1212_KV_KEY_TYPE(q) (CSR1212_KV_KEY(q) >> CSR1212_KV_KEY_TYPE_SHIFT)
 #define CSR1212_KV_KEY_ID(q)   (CSR1212_KV_KEY(q) & CSR1212_KV_KEY_ID_MASK)
 #define CSR1212_KV_VAL_MASK    0xffffff
-#define CSR1212_KV_VAL(q)      (CSR1212_BE32_TO_CPU(q) & CSR1212_KV_VAL_MASK)
+#define CSR1212_KV_VAL(q)      (be32_to_cpu(q) & CSR1212_KV_VAL_MASK)
 
 static int csr1212_parse_dir_entry(struct csr1212_keyval *dir,
-                                  csr1212_quad_t ki,
-                                  u_int32_t kv_pos)
+                                  u32 ki, u32 kv_pos)
 {
        int ret = CSR1212_SUCCESS;
        struct csr1212_keyval *k = NULL;
-       u_int32_t offset;
+       u32 offset;
 
        switch(CSR1212_KV_KEY_TYPE(ki)) {
        case CSR1212_KV_TYPE_IMMEDIATE:
                k = csr1212_new_immediate(CSR1212_KV_KEY_ID(ki),
                                          CSR1212_KV_VAL(ki));
                if (!k) {
-                       ret = CSR1212_ENOMEM;
+                       ret = -ENOMEM;
                        goto fail;
                }
 
@@ -1172,7 +1144,7 @@ static int csr1212_parse_dir_entry(struct csr1212_keyval *dir,
                k = csr1212_new_csr_offset(CSR1212_KV_KEY_ID(ki),
                                           CSR1212_KV_VAL(ki));
                if (!k) {
-                       ret = CSR1212_ENOMEM;
+                       ret = -ENOMEM;
                        goto fail;
                }
                k->refcnt = 0;  /* Don't keep local reference when parsing. */
@@ -1185,7 +1157,7 @@ static int csr1212_parse_dir_entry(struct csr1212_keyval *dir,
                        /* Uh-oh.  Can't have a relative offset of 0 for Leaves
                         * or Directories.  The Config ROM image is most likely
                         * messed up, so we'll just abort here. */
-                       ret = CSR1212_EIO;
+                       ret = -EIO;
                        goto fail;
                }
 
@@ -1200,7 +1172,7 @@ static int csr1212_parse_dir_entry(struct csr1212_keyval *dir,
                        k = csr1212_new_leaf(CSR1212_KV_KEY_ID(ki), NULL, 0);
                }
                if (!k) {
-                       ret = CSR1212_ENOMEM;
+                       ret = -ENOMEM;
                        goto fail;
                }
                k->refcnt = 0;  /* Don't keep local reference when parsing. */
@@ -1230,14 +1202,14 @@ int csr1212_parse_keyval(struct csr1212_keyval *kv,
 
        kvi = (struct csr1212_keyval_img*)&cache->data[bytes_to_quads(kv->offset -
                                                                      cache->offset)];
-       kvi_len = CSR1212_BE16_TO_CPU(kvi->length);
+       kvi_len = be16_to_cpu(kvi->length);
 
 #if 0
        /* Apparently there are too many differnt wrong implementations of the
         * CRC algorithm that verifying them is moot. */
        if ((csr1212_crc16(kvi->data, kvi_len) != kvi->crc) &&
            (csr1212_msft_crc16(kvi->data, kvi_len) != kvi->crc)) {
-               ret = CSR1212_EINVAL;
+               ret = -EINVAL;
                goto fail;
        }
 #endif
@@ -1245,7 +1217,7 @@ int csr1212_parse_keyval(struct csr1212_keyval *kv,
        switch(kv->key.type) {
        case CSR1212_KV_TYPE_DIRECTORY:
                for (i = 0; i < kvi_len; i++) {
-                       csr1212_quad_t ki = kvi->data[i];
+                       u32 ki = kvi->data[i];
 
                        /* Some devices put null entries in their unit
                         * directories.  If we come across such an entry,
@@ -1263,7 +1235,7 @@ int csr1212_parse_keyval(struct csr1212_keyval *kv,
                if (kv->key.id != CSR1212_KV_ID_EXTENDED_ROM) {
                        kv->value.leaf.data = CSR1212_MALLOC(quads_to_bytes(kvi_len));
                        if (!kv->value.leaf.data) {
-                               ret = CSR1212_ENOMEM;
+                               ret = -ENOMEM;
                                goto fail;
                        }
 
@@ -1285,12 +1257,11 @@ int _csr1212_read_keyval(struct csr1212_csr *csr, struct csr1212_keyval *kv)
        struct csr1212_keyval_img *kvi = NULL;
        struct csr1212_csr_rom_cache *cache;
        int cache_index;
-       u_int64_t addr;
-       u_int32_t *cache_ptr;
-       u_int16_t kv_len = 0;
+       u64 addr;
+       u32 *cache_ptr;
+       u16 kv_len = 0;
 
-       if (!csr || !kv || csr->max_rom < 1)
-               return CSR1212_EINVAL;
+       BUG_ON(!csr || !kv || csr->max_rom < 1);
 
        /* First find which cache the data should be in (or go in if not read
         * yet). */
@@ -1301,27 +1272,26 @@ int _csr1212_read_keyval(struct csr1212_csr *csr, struct csr1212_keyval *kv)
        }
 
        if (!cache) {
-               csr1212_quad_t q;
-               u_int32_t cache_size;
+               u32 q, cache_size;
 
                /* Only create a new cache for Extended ROM leaves. */
                if (kv->key.id != CSR1212_KV_ID_EXTENDED_ROM)
-                       return CSR1212_EINVAL;
+                       return -EINVAL;
 
                if (csr->ops->bus_read(csr,
                                       CSR1212_REGISTER_SPACE_BASE + kv->offset,
-                                      sizeof(csr1212_quad_t), &q, csr->private)) {
-                       return CSR1212_EIO;
+                                      sizeof(u32), &q, csr->private)) {
+                       return -EIO;
                }
 
-               kv->value.leaf.len = CSR1212_BE32_TO_CPU(q) >> 16;
+               kv->value.leaf.len = be32_to_cpu(q) >> 16;
 
                cache_size = (quads_to_bytes(kv->value.leaf.len + 1) +
                              (csr->max_rom - 1)) & ~(csr->max_rom - 1);
 
                cache = csr1212_rom_cache_malloc(kv->offset, cache_size);
                if (!cache)
-                       return CSR1212_ENOMEM;
+                       return -ENOMEM;
 
                kv->value.leaf.data = &cache->data[1];
                csr->cache_tail->next = cache;
@@ -1331,11 +1301,11 @@ int _csr1212_read_keyval(struct csr1212_csr *csr, struct csr1212_keyval *kv)
                cache->filled_head =
                        CSR1212_MALLOC(sizeof(*cache->filled_head));
                if (!cache->filled_head) {
-                       return CSR1212_ENOMEM;
+                       return -ENOMEM;
                }
 
                cache->filled_head->offset_start = 0;
-               cache->filled_head->offset_end = sizeof(csr1212_quad_t);
+               cache->filled_head->offset_end = sizeof(u32);
                cache->filled_tail = cache->filled_head;
                cache->filled_head->next = NULL;
                cache->filled_head->prev = NULL;
@@ -1353,7 +1323,7 @@ int _csr1212_read_keyval(struct csr1212_csr *csr, struct csr1212_keyval *kv)
                if (cache_index < cr->offset_start) {
                        newcr = CSR1212_MALLOC(sizeof(*newcr));
                        if (!newcr)
-                               return CSR1212_ENOMEM;
+                               return -ENOMEM;
 
                        newcr->offset_start = cache_index & ~(csr->max_rom - 1);
                        newcr->offset_end = newcr->offset_start;
@@ -1366,8 +1336,7 @@ int _csr1212_read_keyval(struct csr1212_csr *csr, struct csr1212_keyval *kv)
                           (cache_index < cr->offset_end)) {
                        kvi = (struct csr1212_keyval_img*)
                                (&cache->data[bytes_to_quads(cache_index)]);
-                       kv_len = quads_to_bytes(CSR1212_BE16_TO_CPU(kvi->length) +
-                                               1);
+                       kv_len = quads_to_bytes(be16_to_cpu(kvi->length) + 1);
                        break;
                } else if (cache_index == cr->offset_end)
                        break;
@@ -1377,7 +1346,7 @@ int _csr1212_read_keyval(struct csr1212_csr *csr, struct csr1212_keyval *kv)
                cr = cache->filled_tail;
                newcr = CSR1212_MALLOC(sizeof(*newcr));
                if (!newcr)
-                       return CSR1212_ENOMEM;
+                       return -ENOMEM;
 
                newcr->offset_start = cache_index & ~(csr->max_rom - 1);
                newcr->offset_end = newcr->offset_start;
@@ -1399,7 +1368,7 @@ int _csr1212_read_keyval(struct csr1212_csr *csr, struct csr1212_keyval *kv)
                                       csr->private)) {
                        if (csr->max_rom == 4)
                                /* We've got problems! */
-                               return CSR1212_EIO;
+                               return -EIO;
 
                        /* Apperently the max_rom value was a lie, set it to
                         * do quadlet reads and try again. */
@@ -1413,8 +1382,7 @@ int _csr1212_read_keyval(struct csr1212_csr *csr, struct csr1212_keyval *kv)
                if (!kvi && (cr->offset_end > cache_index)) {
                        kvi = (struct csr1212_keyval_img*)
                                (&cache->data[bytes_to_quads(cache_index)]);
-                       kv_len = quads_to_bytes(CSR1212_BE16_TO_CPU(kvi->length) +
-                                               1);
+                       kv_len = quads_to_bytes(be16_to_cpu(kvi->length) + 1);
                }
 
                if ((kv_len + (kv->offset - cache->offset)) > cache->size) {
@@ -1422,7 +1390,7 @@ int _csr1212_read_keyval(struct csr1212_csr *csr, struct csr1212_keyval *kv)
                         * beyond the ConfigROM image region and thus beyond the
                         * end of our cache region.  Therefore, we abort now
                         * rather than seg faulting later. */
-                       return CSR1212_EIO;
+                       return -EIO;
                }
 
                ncr = cr->next;
@@ -1450,8 +1418,7 @@ int csr1212_parse_csr(struct csr1212_csr *csr)
        struct csr1212_dentry *dentry;
        int ret;
 
-       if (!csr || !csr->ops || !csr->ops->bus_read)
-               return CSR1212_EINVAL;
+       BUG_ON(!csr || !csr->ops || !csr->ops->bus_read);
 
        ret = csr1212_parse_bus_info_block(csr);
        if (ret != CSR1212_SUCCESS)
@@ -1463,7 +1430,7 @@ int csr1212_parse_csr(struct csr1212_csr *csr)
                int i = csr->ops->get_max_rom(csr->bus_info_data,
                                              csr->private);
                if (i & ~0x3)
-                       return CSR1212_EINVAL;
+                       return -EINVAL;
                csr->max_rom = mr_map[i];
        }